All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mihai Carabas <mihai.carabas@oracle.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v1 3/3] pvpanic: Indentation fixes here and there
Date: Mon, 30 Aug 2021 09:29:50 +0300	[thread overview]
Message-ID: <6edf9acc-1385-f6b0-cf36-8d52e2bcf7b8@oracle.com> (raw)
In-Reply-To: <20210829124354.81653-3-andriy.shevchenko@linux.intel.com>

La 29.08.2021 15:43, Andy Shevchenko a scris:
> 1) replace double spaces with single;
> 2) relax line width limitation a bit.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mihai Carabas <mihai.carabas@oracle.com>
> ---
>   drivers/misc/pvpanic/pvpanic-mmio.c |  7 +++----
>   drivers/misc/pvpanic/pvpanic-pci.c  | 12 +++++-------
>   drivers/misc/pvpanic/pvpanic.c      | 11 ++++-------
>   3 files changed, 12 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/misc/pvpanic/pvpanic-mmio.c b/drivers/misc/pvpanic/pvpanic-mmio.c
> index 61dbff5f0065..eb97167c03fb 100644
> --- a/drivers/misc/pvpanic/pvpanic-mmio.c
> +++ b/drivers/misc/pvpanic/pvpanic-mmio.c
> @@ -24,8 +24,7 @@ MODULE_AUTHOR("Hu Tao <hutao@cn.fujitsu.com>");
>   MODULE_DESCRIPTION("pvpanic-mmio device driver");
>   MODULE_LICENSE("GPL");
>   
> -static ssize_t capability_show(struct device *dev,
> -			       struct device_attribute *attr, char *buf)
> +static ssize_t capability_show(struct device *dev, struct device_attribute *attr, char *buf)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
>   
> @@ -33,14 +32,14 @@ static ssize_t capability_show(struct device *dev,
>   }
>   static DEVICE_ATTR_RO(capability);
>   
> -static ssize_t events_show(struct device *dev,  struct device_attribute *attr, char *buf)
> +static ssize_t events_show(struct device *dev, struct device_attribute *attr, char *buf)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
>   
>   	return sysfs_emit(buf, "%x\n", pi->events);
>   }
>   
> -static ssize_t events_store(struct device *dev,  struct device_attribute *attr,
> +static ssize_t events_store(struct device *dev, struct device_attribute *attr,
>   			    const char *buf, size_t count)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
> index 7d1220f4c95b..07eddb5ea30f 100644
> --- a/drivers/misc/pvpanic/pvpanic-pci.c
> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
> @@ -19,11 +19,10 @@
>   #define PCI_DEVICE_ID_REDHAT_PVPANIC     0x0011
>   
>   MODULE_AUTHOR("Mihai Carabas <mihai.carabas@oracle.com>");
> -MODULE_DESCRIPTION("pvpanic device driver ");
> +MODULE_DESCRIPTION("pvpanic device driver");
>   MODULE_LICENSE("GPL");
>   
> -static ssize_t capability_show(struct device *dev,
> -			       struct device_attribute *attr, char *buf)
> +static ssize_t capability_show(struct device *dev, struct device_attribute *attr, char *buf)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
>   
> @@ -31,14 +30,14 @@ static ssize_t capability_show(struct device *dev,
>   }
>   static DEVICE_ATTR_RO(capability);
>   
> -static ssize_t events_show(struct device *dev,  struct device_attribute *attr, char *buf)
> +static ssize_t events_show(struct device *dev, struct device_attribute *attr, char *buf)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
>   
>   	return sysfs_emit(buf, "%x\n", pi->events);
>   }
>   
> -static ssize_t events_store(struct device *dev,  struct device_attribute *attr,
> +static ssize_t events_store(struct device *dev, struct device_attribute *attr,
>   			    const char *buf, size_t count)
>   {
>   	struct pvpanic_instance *pi = dev_get_drvdata(dev);
> @@ -65,8 +64,7 @@ static struct attribute *pvpanic_pci_dev_attrs[] = {
>   };
>   ATTRIBUTE_GROUPS(pvpanic_pci_dev);
>   
> -static int pvpanic_pci_probe(struct pci_dev *pdev,
> -			     const struct pci_device_id *ent)
> +static int pvpanic_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   {
>   	struct pvpanic_instance *pi;
>   	void __iomem *base;
> diff --git a/drivers/misc/pvpanic/pvpanic.c b/drivers/misc/pvpanic/pvpanic.c
> index 254d35efb0b7..c9b5a66697ea 100644
> --- a/drivers/misc/pvpanic/pvpanic.c
> +++ b/drivers/misc/pvpanic/pvpanic.c
> @@ -23,7 +23,7 @@
>   #include "pvpanic.h"
>   
>   MODULE_AUTHOR("Mihai Carabas <mihai.carabas@oracle.com>");
> -MODULE_DESCRIPTION("pvpanic device driver ");
> +MODULE_DESCRIPTION("pvpanic device driver");
>   MODULE_LICENSE("GPL");
>   
>   static struct list_head pvpanic_list;
> @@ -43,8 +43,7 @@ pvpanic_send_event(unsigned int event)
>   }
>   
>   static int
> -pvpanic_panic_notify(struct notifier_block *nb, unsigned long code,
> -		     void *unused)
> +pvpanic_panic_notify(struct notifier_block *nb, unsigned long code, void *unused)
>   {
>   	unsigned int event = PVPANIC_PANICKED;
>   
> @@ -94,8 +93,7 @@ static int pvpanic_init(void)
>   	INIT_LIST_HEAD(&pvpanic_list);
>   	spin_lock_init(&pvpanic_lock);
>   
> -	atomic_notifier_chain_register(&panic_notifier_list,
> -				       &pvpanic_panic_nb);
> +	atomic_notifier_chain_register(&panic_notifier_list, &pvpanic_panic_nb);
>   
>   	return 0;
>   }
> @@ -103,8 +101,7 @@ module_init(pvpanic_init);
>   
>   static void pvpanic_exit(void)
>   {
> -	atomic_notifier_chain_unregister(&panic_notifier_list,
> -					 &pvpanic_panic_nb);
> +	atomic_notifier_chain_unregister(&panic_notifier_list, &pvpanic_panic_nb);
>   
>   }
>   module_exit(pvpanic_exit);



  reply	other threads:[~2021-08-30  6:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29 12:43 [PATCH v1 1/3] pvpanic: Keep single style across modules Andy Shevchenko
2021-08-29 12:43 ` [PATCH v1 2/3] pvpanic: Fix typos in the comments Andy Shevchenko
2021-08-30  6:29   ` Mihai Carabas
2021-08-29 12:43 ` [PATCH v1 3/3] pvpanic: Indentation fixes here and there Andy Shevchenko
2021-08-30  6:29   ` Mihai Carabas [this message]
2021-08-30  6:28 ` [PATCH v1 1/3] pvpanic: Keep single style across modules Mihai Carabas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6edf9acc-1385-f6b0-cf36-8d52e2bcf7b8@oracle.com \
    --to=mihai.carabas@oracle.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.