From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED144C5519F for ; Mon, 30 Nov 2020 07:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD0FB20709 for ; Mon, 30 Nov 2020 07:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727699AbgK3Hwl (ORCPT ); Mon, 30 Nov 2020 02:52:41 -0500 Received: from mx2.suse.de ([195.135.220.15]:34190 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726762AbgK3Hwl (ORCPT ); Mon, 30 Nov 2020 02:52:41 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2190FAC8F; Mon, 30 Nov 2020 07:52:00 +0000 (UTC) Subject: Re: [PATCH 45/45] block: stop using bdget_disk for partition 0 To: Christoph Hellwig , Jens Axboe Cc: Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20201128161510.347752-1-hch@lst.de> <20201128161510.347752-46-hch@lst.de> From: Hannes Reinecke Message-ID: <6ee4669e-69c1-eb41-c37e-3794d3207e3a@suse.de> Date: Mon, 30 Nov 2020 08:51:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201128161510.347752-46-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/28/20 5:15 PM, Christoph Hellwig wrote: > We can just dereference the point in struct gendisk instead. Also > remove the now unused export. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Jan Kara > --- > block/genhd.c | 1 - > drivers/block/nbd.c | 4 +--- > drivers/block/xen-blkfront.c | 20 +++++--------------- > drivers/block/zram/zram_drv.c | 14 ++------------ > drivers/md/dm.c | 16 ++-------------- > drivers/s390/block/dasd_ioctl.c | 5 ++--- > fs/block_dev.c | 2 +- > 7 files changed, 13 insertions(+), 49 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3400C5519F for ; Mon, 30 Nov 2020 07:53:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E38420709 for ; Mon, 30 Nov 2020 07:53:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nasPJu+z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E38420709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OS/grM3+WhCgom3Hdaq5UgIVwG9cUPzPGw0vcn6z4AE=; b=nasPJu+zYJQZJWhqF1LIfAT0v /YCKhksrqctgu/vOw5p4/aXxxTyZh5TxmYHrc7plyRq79Q/RZW88uvL9P+S4HBT3qmaopgFqylmLf LE33my1qFSXf22spy45bNImqpPfld7EO03+KO11MByKkJ/MK/sq4QzPM4z6iSmOeJhiMLn0XszE5b 5E3aeTPdlgTgHAQzvNEEcDzv94W+LD8oXcbpmRxSvcuEXH+OW0DGyENpmj0J7Rv9xnahS+NeM/RR/ 2805s5e7KVTT6YhSQhg1Kz8F+l2mOr+Ccjft1yJ3EWz2vmp0P+RNYgq0Ww2bJj0OjISSwGWOFJR+Y KjqAVGINA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjdzG-00041F-Ng; Mon, 30 Nov 2020 07:52:42 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjdyc-0003e0-15 for linux-mtd@lists.infradead.org; Mon, 30 Nov 2020 07:52:02 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2190FAC8F; Mon, 30 Nov 2020 07:52:00 +0000 (UTC) Subject: Re: [PATCH 45/45] block: stop using bdget_disk for partition 0 To: Christoph Hellwig , Jens Axboe References: <20201128161510.347752-1-hch@lst.de> <20201128161510.347752-46-hch@lst.de> From: Hannes Reinecke Message-ID: <6ee4669e-69c1-eb41-c37e-3794d3207e3a@suse.de> Date: Mon, 30 Nov 2020 08:51:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201128161510.347752-46-hch@lst.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_025202_255427_6B9C4D65 X-CRM114-Status: GOOD ( 18.73 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-bcache@vger.kernel.org, Jan Kara , Mike Snitzer , linux-mm@kvack.org, Greg Kroah-Hartman , Jan Kara , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Johannes Thumshirn , Tejun Heo Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gMTEvMjgvMjAgNToxNSBQTSwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6Cj4gV2UgY2FuIGp1 c3QgZGVyZWZlcmVuY2UgdGhlIHBvaW50IGluIHN0cnVjdCBnZW5kaXNrIGluc3RlYWQuICBBbHNv Cj4gcmVtb3ZlIHRoZSBub3cgdW51c2VkIGV4cG9ydC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJp c3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4KPiBSZXZpZXdlZC1ieTogSmFuIEthcmEgPGphY2tA c3VzZS5jej4KPiAtLS0KPiAgIGJsb2NrL2dlbmhkLmMgICAgICAgICAgICAgICAgICAgfCAgMSAt Cj4gICBkcml2ZXJzL2Jsb2NrL25iZC5jICAgICAgICAgICAgIHwgIDQgKy0tLQo+ICAgZHJpdmVy cy9ibG9jay94ZW4tYmxrZnJvbnQuYyAgICB8IDIwICsrKysrLS0tLS0tLS0tLS0tLS0tCj4gICBk cml2ZXJzL2Jsb2NrL3pyYW0venJhbV9kcnYuYyAgIHwgMTQgKystLS0tLS0tLS0tLS0KPiAgIGRy aXZlcnMvbWQvZG0uYyAgICAgICAgICAgICAgICAgfCAxNiArKy0tLS0tLS0tLS0tLS0tCj4gICBk cml2ZXJzL3MzOTAvYmxvY2svZGFzZF9pb2N0bC5jIHwgIDUgKystLS0KPiAgIGZzL2Jsb2NrX2Rl di5jICAgICAgICAgICAgICAgICAgfCAgMiArLQo+ICAgNyBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNl cnRpb25zKCspLCA0OSBkZWxldGlvbnMoLSkKPiAKUmV2aWV3ZWQtYnk6IEhhbm5lcyBSZWluZWNr ZSA8aGFyZUBzdXNlLmRlPgoKQ2hlZXJzLAoKSGFubmVzCi0tIApEci4gSGFubmVzIFJlaW5lY2tl ICAgICAgICAgICAgICAgIEtlcm5lbCBTdG9yYWdlIEFyY2hpdGVjdApoYXJlQHN1c2UuZGUgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICArNDkgOTExIDc0MDUzIDY4OApTVVNFIFNvZnR3YXJl IFNvbHV0aW9ucyBHbWJILCBNYXhmZWxkc3RyLiA1LCA5MDQwOSBOw7xybmJlcmcKSFJCIDM2ODA5 IChBRyBOw7xybmJlcmcpLCBHZXNjaMOkZnRzZsO8aHJlcjogRmVsaXggSW1lbmTDtnJmZmVyCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGlu dXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87192C5519F for ; Mon, 30 Nov 2020 07:52:18 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D990B20709 for ; Mon, 30 Nov 2020 07:52:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D990B20709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-cU210Z69M0OBH91oqJD_JQ-1; Mon, 30 Nov 2020 02:52:14 -0500 X-MC-Unique: cU210Z69M0OBH91oqJD_JQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB139107ACE8; Mon, 30 Nov 2020 07:52:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 985E810016FF; Mon, 30 Nov 2020 07:52:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 66B1C4E58F; Mon, 30 Nov 2020 07:52:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AU7q86e027088 for ; Mon, 30 Nov 2020 02:52:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id A59D62166B2B; Mon, 30 Nov 2020 07:52:08 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A0E0D2166B2A for ; Mon, 30 Nov 2020 07:52:06 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64875800969 for ; Mon, 30 Nov 2020 07:52:06 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-456-3oeFrr03MSatzhERsDpLbw-1; Mon, 30 Nov 2020 02:52:01 -0500 X-MC-Unique: 3oeFrr03MSatzhERsDpLbw-1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2190FAC8F; Mon, 30 Nov 2020 07:52:00 +0000 (UTC) To: Christoph Hellwig , Jens Axboe References: <20201128161510.347752-1-hch@lst.de> <20201128161510.347752-46-hch@lst.de> From: Hannes Reinecke Message-ID: <6ee4669e-69c1-eb41-c37e-3794d3207e3a@suse.de> Date: Mon, 30 Nov 2020 08:51:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201128161510.347752-46-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 0AU7q86e027088 X-loop: dm-devel@redhat.com Cc: linux-bcache@vger.kernel.org, Jan Kara , Mike Snitzer , linux-mm@kvack.org, Greg Kroah-Hartman , Jan Kara , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Johannes Thumshirn , Tejun Heo Subject: Re: [dm-devel] [PATCH 45/45] block: stop using bdget_disk for partition 0 X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" T24gMTEvMjgvMjAgNToxNSBQTSwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6Cj4gV2UgY2FuIGp1 c3QgZGVyZWZlcmVuY2UgdGhlIHBvaW50IGluIHN0cnVjdCBnZW5kaXNrIGluc3RlYWQuICBBbHNv Cj4gcmVtb3ZlIHRoZSBub3cgdW51c2VkIGV4cG9ydC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJp c3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4KPiBSZXZpZXdlZC1ieTogSmFuIEthcmEgPGphY2tA c3VzZS5jej4KPiAtLS0KPiAgIGJsb2NrL2dlbmhkLmMgICAgICAgICAgICAgICAgICAgfCAgMSAt Cj4gICBkcml2ZXJzL2Jsb2NrL25iZC5jICAgICAgICAgICAgIHwgIDQgKy0tLQo+ICAgZHJpdmVy cy9ibG9jay94ZW4tYmxrZnJvbnQuYyAgICB8IDIwICsrKysrLS0tLS0tLS0tLS0tLS0tCj4gICBk cml2ZXJzL2Jsb2NrL3pyYW0venJhbV9kcnYuYyAgIHwgMTQgKystLS0tLS0tLS0tLS0KPiAgIGRy aXZlcnMvbWQvZG0uYyAgICAgICAgICAgICAgICAgfCAxNiArKy0tLS0tLS0tLS0tLS0tCj4gICBk cml2ZXJzL3MzOTAvYmxvY2svZGFzZF9pb2N0bC5jIHwgIDUgKystLS0KPiAgIGZzL2Jsb2NrX2Rl di5jICAgICAgICAgICAgICAgICAgfCAgMiArLQo+ICAgNyBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNl cnRpb25zKCspLCA0OSBkZWxldGlvbnMoLSkKPiAKUmV2aWV3ZWQtYnk6IEhhbm5lcyBSZWluZWNr ZSA8aGFyZUBzdXNlLmRlPgoKQ2hlZXJzLAoKSGFubmVzCi0tIApEci4gSGFubmVzIFJlaW5lY2tl ICAgICAgICAgICAgICAgIEtlcm5lbCBTdG9yYWdlIEFyY2hpdGVjdApoYXJlQHN1c2UuZGUgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICArNDkgOTExIDc0MDUzIDY4OApTVVNFIFNvZnR3YXJl IFNvbHV0aW9ucyBHbWJILCBNYXhmZWxkc3RyLiA1LCA5MDQwOSBOw7xybmJlcmcKSFJCIDM2ODA5 IChBRyBOw7xybmJlcmcpLCBHZXNjaMOkZnRzZsO8aHJlcjogRmVsaXggSW1lbmTDtnJmZmVyCgoK LS0KZG0tZGV2ZWwgbWFpbGluZyBsaXN0CmRtLWRldmVsQHJlZGhhdC5jb20KaHR0cHM6Ly93d3cu cmVkaGF0LmNvbS9tYWlsbWFuL2xpc3RpbmZvL2RtLWRldmVs