From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755416AbcJMLkC (ORCPT ); Thu, 13 Oct 2016 07:40:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:54015 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754800AbcJMLib (ORCPT ); Thu, 13 Oct 2016 07:38:31 -0400 Subject: Re: [PATCH v2 07/16] scsi: libfc: don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() To: Johannes Thumshirn , "Martin K . Petersen" References: Cc: Christoph Hellwig , Linux Kernel Mailinglist , Linux SCSI Mailinglist , Johannes Thumshirn , "James E.J. Bottomley" , "open list:FCOE SUBSYSTEM (libfc, libfcoe, fcoe)" From: Hannes Reinecke Message-ID: <6eecb558-bd61-aa08-9582-d836ea2c343c@suse.de> Date: Thu, 13 Oct 2016 13:38:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() as > fc_bsg_jobdone() calls blk_complete_requeust() which raises a soft-IRQ that > ends up in fc_bsg_sofirq_done() and fc_bsg_softirq_done() sets the > FC_RQST_STATE_DONE flag. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/libfc/fc_lport.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c > index 156708a..53d13721 100644 > --- a/drivers/scsi/libfc/fc_lport.c > +++ b/drivers/scsi/libfc/fc_lport.c > @@ -1911,7 +1911,6 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, struct fc_frame *fp, > bsg_reply->result = (PTR_ERR(fp) == -FC_EX_CLOSED) ? > -ECONNABORTED : -ETIMEDOUT; > job->reply_len = sizeof(uint32_t); > - job->state_flags |= FC_RQST_STATE_DONE; > fc_bsg_jobdone(job, bsg_reply->result, > bsg_reply->reply_payload_rcv_len); > kfree(info); > @@ -1947,7 +1946,6 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, struct fc_frame *fp, > bsg_reply->reply_payload_rcv_len = > job->reply_payload.payload_len; > bsg_reply->result = 0; > - job->state_flags |= FC_RQST_STATE_DONE; > fc_bsg_jobdone(job, bsg_reply->result, > bsg_reply->reply_payload_rcv_len); > kfree(info); > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH v2 07/16] scsi: libfc: don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() Date: Thu, 13 Oct 2016 13:38:06 +0200 Message-ID: <6eecb558-bd61-aa08-9582-d836ea2c343c@suse.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fcoe-devel-bounces-s9riP+hp16TNLxjTenLetw@public.gmane.org Sender: "fcoe-devel" To: Johannes Thumshirn , "Martin K . Petersen" Cc: "James E.J. Bottomley" , Linux SCSI Mailinglist , Linux Kernel Mailinglist , Christoph Hellwig , "open list:FCOE SUBSYSTEM (libfc, libfcoe, fcoe)" , Johannes Thumshirn List-Id: linux-scsi@vger.kernel.org On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() as > fc_bsg_jobdone() calls blk_complete_requeust() which raises a soft-IRQ th= at > ends up in fc_bsg_sofirq_done() and fc_bsg_softirq_done() sets the > FC_RQST_STATE_DONE flag. > = > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/libfc/fc_lport.c | 2 -- > 1 file changed, 2 deletions(-) > = > diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c > index 156708a..53d13721 100644 > --- a/drivers/scsi/libfc/fc_lport.c > +++ b/drivers/scsi/libfc/fc_lport.c > @@ -1911,7 +1911,6 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, st= ruct fc_frame *fp, > bsg_reply->result =3D (PTR_ERR(fp) =3D=3D -FC_EX_CLOSED) ? > -ECONNABORTED : -ETIMEDOUT; > job->reply_len =3D sizeof(uint32_t); > - job->state_flags |=3D FC_RQST_STATE_DONE; > fc_bsg_jobdone(job, bsg_reply->result, > bsg_reply->reply_payload_rcv_len); > kfree(info); > @@ -1947,7 +1946,6 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, st= ruct fc_frame *fp, > bsg_reply->reply_payload_rcv_len =3D > job->reply_payload.payload_len; > bsg_reply->result =3D 0; > - job->state_flags |=3D FC_RQST_STATE_DONE; > fc_bsg_jobdone(job, bsg_reply->result, > bsg_reply->reply_payload_rcv_len); > kfree(info); > = Reviewed-by: Hannes Reinecke Cheers, Hannes -- = Dr. Hannes Reinecke Teamlead Storage & Networking hare-l3A5Bk7waGM@public.gmane.org +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: F. Imend=F6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N=FCrnberg)