From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v3 3/5] x86: split PV dom0 builder to pv/dom0_builder.c Date: Mon, 20 Mar 2017 14:43:52 +0000 Message-ID: <6ef6811a-829f-da48-aaec-fa5218668e38@citrix.com> References: <20170320141426.20780-1-wei.liu2@citrix.com> <20170320141426.20780-4-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpycP-0002W7-SB for xen-devel@lists.xenproject.org; Mon, 20 Mar 2017 14:49:09 +0000 In-Reply-To: <20170320141426.20780-4-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu , Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= List-Id: xen-devel@lists.xenproject.org T24gMjAvMDMvMTcgMTQ6MTQsIFdlaSBMaXUgd3JvdGU6Cj4gTG9uZyB0ZXJtIHdlIHdhbnQgdG8g YmUgYWJsZSB0byBkaXNlbnRhbmdsZSBQViBhbmQgSFZNIGNvZGUuIE1vdmUgdGhlIFBWCj4gZG9t YWluIGJ1aWxkZXIgdG8gYSBkZWRpY2F0ZWQgZmlsZS4KPgo+IFRoaXMgaW4gdHVybiByZXF1aXJl cyBleHBvc2luZyBhIGZldyBmdW5jdGlvbnMgYW5kIHZhcmlhYmxlcyB2aWEgYSBuZXcKPiBoZWFk ZXIgZG9tMF9idWlsZC5oLiBUaGVzZSBmdW5jdGlvbnMgYW5kIHZhcmlhYmxlcyBhcmUgbm93IHBy ZWZpeGVkIHdpdGgKPiAiZG9tMF8iIGlmIHRoZXkgd2VyZW4ndCBhbHJlYWR5IHNvLgo+Cj4gTm8g ZnVuY3Rpb25hbCBjaGFuZ2UuCj4KPiBTaWduZWQtb2ZmLWJ5OiBXZWkgTGl1IDx3ZWkubGl1MkBj aXRyaXguY29tPgoKQSBmZXcgbWlub3Igc3R5bGUgZml4ZXMuLi4KCj4gPGJpZyBzbmlwPgo+ICsg ICAgLyogY29tcGF0aWJpbGl0eSBjaGVjayAqLwo+ICsgICAgY29tcGF0aWJsZSA9IDA7Cj4gKyAg ICBjb21wYXQzMiAgID0gMDsKPiArICAgIG1hY2hpbmUgPSBlbGZfdXZhbCgmZWxmLCBlbGYuZWhk ciwgZV9tYWNoaW5lKTsKPiArICAgIHByaW50aygiIFhlbiAga2VybmVsOiA2NC1iaXQsIGxzYiwg Y29tcGF0MzJcbiIpOwo+ICsgICAgaWYgKGVsZl8zMmJpdCgmZWxmKSAmJiBwYXJtcy5wYWUgPT0g WEVOX1BBRV9CSU1PREFMKQoKSGVyZS4KCj4gKyAgICAgICAgcGFybXMucGFlID0gWEVOX1BBRV9F WFRDUjM7Cj4gKyAgICBpZiAoZWxmXzMyYml0KCZlbGYpICYmIHBhcm1zLnBhZSAmJiBtYWNoaW5l ID09IEVNXzM4NikKCkhlcmUKCj4gKyAgICB7Cj4gKyAgICAgICAgY29tcGF0MzIgPSAxOwo+ICsg ICAgICAgIGNvbXBhdGlibGUgPSAxOwo+ICsgICAgfQo+ICsgICAgaWYgKGVsZl82NGJpdCgmZWxm KSAmJiBtYWNoaW5lID09IEVNX1g4Nl82NCkKCkhlcmUuCgo+IDxzbmlwPgo+ICsKPiArICAgIGw0 dGFiICs9IGw0X3RhYmxlX29mZnNldCh2X3N0YXJ0KTsKPiArICAgIHBmbiA9IGFsbG9jX3NwZm47 Cj4gKyAgICBmb3IgKCBjb3VudCA9IDA7IGNvdW50IDwgKCh2X2VuZC12X3N0YXJ0KT4+UEFHRV9T SElGVCk7IGNvdW50KysgKQoKSGVyZS4KCj4gPHNuaXA+Cj4gKyNpZm5kZWYgTkRFQlVHCj4gKyNk ZWZpbmUgUkVWRVJTRV9TVEFSVCAoKHZfZW5kIC0gdl9zdGFydCkgPj4gUEFHRV9TSElGVCkKPiAr ICAgICAgICBpZiAoIHBmbiA+IFJFVkVSU0VfU1RBUlQgJiYgKHZpbml0cmRfc3RhcnQgfHwgcGZu IDwgaW5pdHJkX3BmbikgKQo+ICsgICAgICAgICAgICBtZm4gPSBhbGxvY19lcGZuIC0gKHBmbiAt IFJFVkVSU0VfU1RBUlQpOwo+ICsjZW5kaWYKPiArICAgICAgICBkb20wX3VwZGF0ZV9waHlzbWFw KGQsIHBmbiwgbWZuLCB2cGh5c21hcF9zdGFydCk7Cj4gKyAgICAgICAgaWYgKCEocGZuICYgMHhm ZmZmZikpCgpIZXJlLgoKPiArICAgICAgICAgICAgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7 Cj4gKyAgICB9Cj4gKyAgICBzaS0+Zmlyc3RfcDJtX3BmbiA9IHBmbjsKPiArICAgIHNpLT5ucl9w Mm1fZnJhbWVzID0gZC0+dG90X3BhZ2VzIC0gY291bnQ7Cj4gKyAgICBwYWdlX2xpc3RfZm9yX2Vh Y2ggKCBwYWdlLCAmZC0+cGFnZV9saXN0ICkKPiArICAgIHsKPiArICAgICAgICBtZm4gPSBwYWdl X3RvX21mbihwYWdlKTsKPiArICAgICAgICBCVUdfT04oU0hBUkVEX00yUChnZXRfZ3Bmbl9mcm9t X21mbihtZm4pKSk7Cj4gKyAgICAgICAgaWYgKCBnZXRfZ3Bmbl9mcm9tX21mbihtZm4pID49IGNv dW50ICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIEJVR19PTihpc19wdl8zMmJpdF9kb21h aW4oZCkpOwo+ICsgICAgICAgICAgICBpZiAoICFwYWdpbmdfbW9kZV90cmFuc2xhdGUoZCkgJiYg IXBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYmCj4gKyAgICAgICAgICAgICAgICAgIWdldF9wYWdl X2FuZF90eXBlKHBhZ2UsIGQsIFBHVF93cml0YWJsZV9wYWdlKSApCj4gKyAgICAgICAgICAgICAg ICBCVUcoKTsKPiArCj4gKyAgICAgICAgICAgIGRvbTBfdXBkYXRlX3BoeXNtYXAoZCwgcGZuLCBt Zm4sIHZwaHlzbWFwX3N0YXJ0KTsKPiArICAgICAgICAgICAgKytwZm47Cj4gKyAgICAgICAgICAg IGlmICghKHBmbiAmIDB4ZmZmZmYpKQoKSGVyZS4KCj4gKyAgICAgICAgICAgICAgICBwcm9jZXNz X3BlbmRpbmdfc29mdGlycXMoKTsKPiArICAgICAgICB9Cj4gKyAgICB9Cj4gKyAgICBCVUdfT04o cGZuICE9IGQtPnRvdF9wYWdlcyk7Cj4gKyNpZm5kZWYgTkRFQlVHCj4gKyAgICBhbGxvY19lcGZu ICs9IFBGTl9VUChpbml0cmRfbGVuKSArIHNpLT5ucl9wMm1fZnJhbWVzOwo+ICsjZW5kaWYKPiAr ICAgIHdoaWxlICggcGZuIDwgbnJfcGFnZXMgKQo+ICsgICAgewo+ICsgICAgICAgIGlmICggKHBh Z2UgPSBhbGxvY19jaHVuayhkLCBucl9wYWdlcyAtIGQtPnRvdF9wYWdlcykpID09IE5VTEwgKQo+ ICsgICAgICAgICAgICBwYW5pYygiTm90IGVub3VnaCBSQU0gZm9yIERPTTAgcmVzZXJ2YXRpb24i KTsKPiArICAgICAgICB3aGlsZSAoIHBmbiA8IGQtPnRvdF9wYWdlcyApCj4gKyAgICAgICAgewo+ ICsgICAgICAgICAgICBtZm4gPSBwYWdlX3RvX21mbihwYWdlKTsKPiArI2lmbmRlZiBOREVCVUcK PiArI2RlZmluZSBwZm4gKG5yX3BhZ2VzIC0gMSAtIChwZm4gLSAoYWxsb2NfZXBmbiAtIGFsbG9j X3NwZm4pKSkKPiArI2VuZGlmCj4gKyAgICAgICAgICAgIGRvbTBfdXBkYXRlX3BoeXNtYXAoZCwg cGZuLCBtZm4sIHZwaHlzbWFwX3N0YXJ0KTsKPiArI3VuZGVmIHBmbgo+ICsgICAgICAgICAgICBw YWdlKys7IHBmbisrOwo+ICsgICAgICAgICAgICBpZiAoIShwZm4gJiAweGZmZmZmKSkKCkFuZCBo ZXJlLgoKV2l0aCB0aGVzZSBmaXhlZCwgUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4u b3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK