From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Tony Luck <tony.luck@intel.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, gwml@vger.gnuweeb.org, x86@kernel.org,
David Laight <David.Laight@aculab.com>,
Jiri Hladky <hladky.jiri@googlemail.com>
Subject: Re: [PATCH v5 1/2] x86/delay: Fix the wrong asm constraint in `delay_loop()`
Date: Mon, 28 Mar 2022 11:29:26 +0700 [thread overview]
Message-ID: <6f020f3a-da63-09a5-95f4-167429ff3727@gnuweeb.org> (raw)
In-Reply-To: <YkDZY8n1k5SJw9st@zn.tnic>
On 3/28/22 4:38 AM, Borislav Petkov wrote:
> On Thu, Mar 10, 2022 at 08:53:05AM +0700, Ammar Faizi wrote:
>> The asm constraint does not reflect that the asm statement can modify
>> the value of @loops. But the asm statement in delay_loop() does modify
>> the @loops.
>>
>> Specifiying the wrong constraint may lead to undefined behavior, it may
>> clobber random stuff (e.g. local variable, important temporary value in
>> regs, etc.).
>
> This is especially dangerous when the compiler decides to inline the
> function and since it doesn't know that the value gets modified, it
> might decide to use it from a register directly without reloading it.
>
> Add that to the commit message pls.
Will add that in the v6.
>> Cc: stable@vger.kernel.org # v2.6.27+
>
> I don't see the need for the stable Cc. Or do you have a case where
> a corruption really does happen?
I don't find any visible issue on this. But that's undefined behavior,
different compiler may yield different result (e.g. there is no guarantee
newer compilers will produce the appropriate result due to UB). So it's not
something we should rely on.
============
Side note for inline:
Even if it is not inlined, it's still dangerous, because if the compiler is
able to see that the function to be called doesn't clobber some call-clobbered
regs, the compiler can assume the call-clobbered regs are not clobbered and it
reuses the value without reloading.
See the example from Alviro here:
https://lore.kernel.org/lkml/CAOG64qPgTv5tQNknuG9d-=oL2EPQQ1ys7xu2FoBpNLyzv1qYzA@mail.gmail.com/
--
Ammar Faizi
next prev parent reply other threads:[~2022-03-28 4:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 1:53 [PATCH v5 0/2] Two x86 fixes Ammar Faizi
2022-03-10 1:53 ` [PATCH v5 1/2] x86/delay: Fix the wrong asm constraint in `delay_loop()` Ammar Faizi
2022-03-27 21:38 ` Borislav Petkov
2022-03-28 4:16 ` Ammar Faizi
2022-03-28 4:29 ` Ammar Faizi [this message]
2022-03-28 7:56 ` Borislav Petkov
2022-03-10 1:53 ` [PATCH v5 2/2] x86/MCE/AMD: Fix memory leak when `threshold_create_bank()` fails Ammar Faizi
2022-03-27 22:52 ` Borislav Petkov
2022-03-28 4:12 ` Ammar Faizi
2022-03-28 8:05 ` Borislav Petkov
2022-03-17 8:19 ` [PATCH v5 0/2] Two x86 fixes Ammar Faizi
2022-03-17 9:27 ` Borislav Petkov
2022-03-17 9:50 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f020f3a-da63-09a5-95f4-167429ff3727@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=David.Laight@aculab.com \
--cc=alviro.iskandar@gmail.com \
--cc=alviro.iskandar@gnuweeb.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwml@vger.gnuweeb.org \
--cc=hladky.jiri@googlemail.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.