On 5/27/21 7:47 PM, Andrew Zaborowski wrote:
> Deprecate the global [General].APRanges setting in favour of
> [IPv4].APAddressPool with an extended (but backwards-compatible) syntax.
> Drop the existing address pool creation code.
> 
> The new APAddressPool setting has the same syntax as the profile-local
> [IPv4].Address setting and the subnet selection code will fall back
> to the global setting if it's missing, this way we use common code to
> handle both settings.
> ---
>   src/ap.c | 185 +++++++++++++------------------------------------------
>   1 file changed, 42 insertions(+), 143 deletions(-)
> 

<snip>

> +	if (netconfig_enabled) {
> +		if (l_settings_get_value(settings, "IPv4", "APAddressPool")) {
> +			global_addr4_strs = l_settings_get_string_list(settings,
> +								"IPv4",
> +								"APAddressPool",
> +								',');
> +			if (!global_addr4_strs || !*global_addr4_strs) {
> +				l_error("Can't parse the [IPv4].APAddressPool "
> +					"setting as a string list");
> +				l_strv_free(global_addr4_strs);
> +				global_addr4_strs = NULL;
> +			}
> +		} else if (l_settings_get_value(settings,
> +						"General", "APRanges")) {
> +			global_addr4_strs = l_settings_get_string_list(settings,
> +								"General",
> +								"APRanges",
> +								',');

Do you want to print a warning that this setting is deprecated?

> +			if (!global_addr4_strs || !*global_addr4_strs) {
> +				l_error("Can't parse the [General].APRanges "
> +					"setting as a string list");
> +				l_strv_free(global_addr4_strs);
> +				global_addr4_strs = NULL;
> +			}
>   		}
>   

Applied, thanks.

Regards,
-Denis