All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raphael Bauer <raphael@pdev.de>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git ML <git@vger.kernel.org>
Subject: Re: Pretty format color bug
Date: Tue, 22 Feb 2022 01:15:47 +0100	[thread overview]
Message-ID: <6f0d1c12-4cf8-bbdd-96d4-eae99317e2e4@pdev.de> (raw)
In-Reply-To: <220222.865yp7aj6z.gmgdl@evledraar.gmail.com>

> I think you've found a "bug" or unexpected feature, but it's not in git,
> but in your pager.
> 
> Try:
>      PAGER=cat git log --pretty=format:'%h%Cred%+d test'

Interesting, cat works correctly.
But this still fails for me:
PAGER=cat git log --pretty=format:'%h%Cred%+d test' --graph

The pipe symbol printed (because of --graph) for the second line is 
colored and resets the color of the refnames and 'test'.
Now this looks like a bug in git?

> I'm assuming you're using "less" and are about to read about its
> behavior of resetting colors that are still in effect when it hits a
> newline.

There is a section (-R) that mentions less assumes every line starts 
normal / uncolored. Shouldn't git follow this assumption when printing 
colorized to less?

  reply	other threads:[~2022-02-22  0:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 22:38 Pretty format color bug Raphael Bauer
2022-02-21 23:29 ` Ævar Arnfjörð Bjarmason
2022-02-22  0:15   ` Raphael Bauer [this message]
2022-03-22 23:42     ` BUG: %+ format placeholder and colors Raphael Bauer
2022-03-23  2:49       ` Ævar Arnfjörð Bjarmason
2022-03-23 18:12         ` Raphael
2022-04-05 15:45           ` [PATCH] pretty format: fix colors on %+ placeholder newline Raphael Bauer
2022-04-06 21:16             ` Junio C Hamano
2022-04-08 13:18               ` Raphael
2022-04-08 15:14                 ` Ævar Arnfjörð Bjarmason
2022-04-08 23:40                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f0d1c12-4cf8-bbdd-96d4-eae99317e2e4@pdev.de \
    --to=raphael@pdev.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.