From: Larry Finger <Larry.Finger@lwfinger.net>
To: Reto Schneider <code@reto-schneider.ch>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] rtl8192cu: Fix deadlock
Date: Mon, 22 Jun 2020 13:01:26 -0500 [thread overview]
Message-ID: <6f1000a0-7a0a-36c9-21a3-1ea39175d051@lwfinger.net> (raw)
In-Reply-To: <20200622132113.14508-2-code@reto-schneider.ch>
On 6/22/20 8:21 AM, Reto Schneider wrote:
> Prevent code from calling itself indirectly, causing the driver to hang
> and consume 100% CPU.
>
> Without this fix, the following script can bring down a single CPU
> system:
> ```
> while true; do
> rmmod rtl8192cu
> modprobe rtl8192cu
> done
> ```
>
> Signed-off-by: Reto Schneider <code@reto-schneider.ch>
I have one small comment. Patches for the rtlwifi family of drivers have patch
subjects of the form [PATCH] rtlwifi: rtl8192cu: blah blah. I'll let Kalle
decide if he wants ignore my comment, manually change the subjects, or request a
V2. Otherwise all 3 patches are OK.
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
next prev parent reply other threads:[~2020-06-22 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 13:21 [PATCH 0/3] rtl8192cu: Fixes for leaks and deadlock Reto Schneider
2020-06-22 13:21 ` [PATCH 1/3] rtl8192cu: Fix deadlock Reto Schneider
2020-06-22 18:01 ` Larry Finger [this message]
2020-06-23 9:20 ` Kalle Valo
2020-07-15 10:37 ` [PATCH 1/3] rtlwifi: " Kalle Valo
2020-06-22 13:21 ` [PATCH 2/3] rtl8192cu: Prevent leaking urb Reto Schneider
2020-06-22 13:21 ` [PATCH 3/3] rtl8192cu: Free ieee80211_hw if probing fails Reto Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f1000a0-7a0a-36c9-21a3-1ea39175d051@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=code@reto-schneider.ch \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.