From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932959AbdBPQk1 (ORCPT ); Thu, 16 Feb 2017 11:40:27 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:35231 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932358AbdBPQkZ (ORCPT ); Thu, 16 Feb 2017 11:40:25 -0500 Subject: Re: [PATCH v3 0/2] drm: Support framebuffer panning To: Maxime Ripard , Daniel Vetter , David Airlie , Sean Paul , Jani Nikula References: Cc: Stefan Christ , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "open list:ARM/Amlogic Meson..." From: Neil Armstrong Organization: Baylibre Message-ID: <6f108ce7-1e36-0177-2c23-c62fab6ebaad@baylibre.com> Date: Thu, 16 Feb 2017 17:40:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/15/2017 05:19 PM, Maxime Ripard wrote: > Hi, > > This is a respin of the previous serie called "Support fast framebuffer > panning for i.MX6" made by Stefan 6 monthes ago. The imx6 bits have been > removed, and the comments that were made at that time fixed (hopefully). > > Let me know what you think, > Maxime > > Changes from v2: > - Renamed the CONFIG_DRM_CMA_FBDEV_BUFFER_NUM to > CONFIG_DRM_FBDEV_OVERALLOC, and changed it for a percentage > - Moved the overallocation code into the core fbdev helpers to not rely > on CMA anymore > - Changed the locks taken by drm_fb_helper_ioctl to the mode_config mutex > intead of calling drm_modeset_lock_all > - Don't test against drm_crtc's enabled anymore, but rely on the error > code of drm_crtc_vblank_get instead > - Defined drm_fb_helper_ioctl when DRM_FBDEV_EMULATION is not set in > order to fix a compilation error > - Don't wait for all CRTC's vblank but only the one given in the ioctl > argument > > Changes from v1: > - Added drm_fb_helper_ioctl to DRM_FB_HELPER_DEFAULT_OPS > - Expanded a bit the kerneldoc for drm_fb_helper_ioctl > - Added some locking to drm_fb_helper_ioctl > - Checked that the framebuffer is indeed attached before allowing ioctl > - Added a module parameter to specify the number of framebuffers to > allocate > > Initial cover letter: Support fast framebuffer panning for i.MX6 > > im currently working on supporting double/tripple buffering for the > framebuffer emulation on the i.MX6. While working on it I noticed that the > mainline kernel does not support some features in the generic drm > framebuffer emulation for framebuffer panning and vsync synchronisation. > They are needed for simple framebuffer applications and some OpenGL > libraries using double buffering with FBIOPUT_VSCREENINFO, > FBIO_WAITFORVSYNC and FBIOPAN_DISPLAY. > > Stefan Christ (1): > drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC > > Xinliang Liu (1): > drm/fb-helper: Add multi buffer support for cma fbdev > > drivers/gpu/drm/Kconfig | 9 ++++- > drivers/gpu/drm/drm_fb_helper.c | 73 ++++++++++++++++++++++++++++++++++- > include/drm/drm_fb_helper.h | 12 +++++- > 3 files changed, 93 insertions(+), 1 deletion(-) > > base-commit: 0879b944c95d65f7523d178d3addaebe84e510ec > Hi Maxime, Just tested these patches on Amlogic GXBB to provide 3D Mali acceleration on framebuffer. Tested-by: Neil Armstrong Thanks, Neil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Subject: Re: [PATCH v3 0/2] drm: Support framebuffer panning Date: Thu, 16 Feb 2017 17:40:08 +0100 Message-ID: <6f108ce7-1e36-0177-2c23-c62fab6ebaad@baylibre.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4919D6EBAE for ; Thu, 16 Feb 2017 16:40:25 +0000 (UTC) Received: by mail-wm0-x235.google.com with SMTP id c85so71042302wmi.1 for ; Thu, 16 Feb 2017 08:40:25 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard , Daniel Vetter , David Airlie , Sean Paul , Jani Nikula Cc: "open list:ARM/Amlogic Meson..." , Stefan Christ , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMDIvMTUvMjAxNyAwNToxOSBQTSwgTWF4aW1lIFJpcGFyZCB3cm90ZToKPiBIaSwKPiAKPiBU aGlzIGlzIGEgcmVzcGluIG9mIHRoZSBwcmV2aW91cyBzZXJpZSBjYWxsZWQgIlN1cHBvcnQgZmFz dCBmcmFtZWJ1ZmZlcgo+IHBhbm5pbmcgZm9yIGkuTVg2IiBtYWRlIGJ5IFN0ZWZhbiA2IG1vbnRo ZXMgYWdvLiBUaGUgaW14NiBiaXRzIGhhdmUgYmVlbgo+IHJlbW92ZWQsIGFuZCB0aGUgY29tbWVu dHMgdGhhdCB3ZXJlIG1hZGUgYXQgdGhhdCB0aW1lIGZpeGVkIChob3BlZnVsbHkpLgo+IAo+IExl dCBtZSBrbm93IHdoYXQgeW91IHRoaW5rLAo+IE1heGltZQo+IAo+IENoYW5nZXMgZnJvbSB2MjoK PiAgIC0gUmVuYW1lZCB0aGUgQ09ORklHX0RSTV9DTUFfRkJERVZfQlVGRkVSX05VTSB0bwo+ICAg ICBDT05GSUdfRFJNX0ZCREVWX09WRVJBTExPQywgYW5kIGNoYW5nZWQgaXQgZm9yIGEgcGVyY2Vu dGFnZQo+ICAgLSBNb3ZlZCB0aGUgb3ZlcmFsbG9jYXRpb24gY29kZSBpbnRvIHRoZSBjb3JlIGZi ZGV2IGhlbHBlcnMgdG8gbm90IHJlbHkKPiAgICAgb24gQ01BIGFueW1vcmUKPiAgIC0gQ2hhbmdl ZCB0aGUgbG9ja3MgdGFrZW4gYnkgZHJtX2ZiX2hlbHBlcl9pb2N0bCB0byB0aGUgbW9kZV9jb25m aWcgbXV0ZXgKPiAgICAgaW50ZWFkIG9mIGNhbGxpbmcgZHJtX21vZGVzZXRfbG9ja19hbGwKPiAg IC0gRG9uJ3QgdGVzdCBhZ2FpbnN0IGRybV9jcnRjJ3MgZW5hYmxlZCBhbnltb3JlLCBidXQgcmVs eSBvbiB0aGUgZXJyb3IKPiAgICAgY29kZSBvZiBkcm1fY3J0Y192YmxhbmtfZ2V0IGluc3RlYWQK PiAgIC0gRGVmaW5lZCBkcm1fZmJfaGVscGVyX2lvY3RsIHdoZW4gRFJNX0ZCREVWX0VNVUxBVElP TiBpcyBub3Qgc2V0IGluCj4gICAgIG9yZGVyIHRvIGZpeCBhIGNvbXBpbGF0aW9uIGVycm9yCj4g ICAtIERvbid0IHdhaXQgZm9yIGFsbCBDUlRDJ3MgdmJsYW5rIGJ1dCBvbmx5IHRoZSBvbmUgZ2l2 ZW4gaW4gdGhlIGlvY3RsCj4gICAgIGFyZ3VtZW50Cj4gCj4gQ2hhbmdlcyBmcm9tIHYxOgo+ICAg LSBBZGRlZCBkcm1fZmJfaGVscGVyX2lvY3RsIHRvIERSTV9GQl9IRUxQRVJfREVGQVVMVF9PUFMK PiAgIC0gRXhwYW5kZWQgYSBiaXQgdGhlIGtlcm5lbGRvYyBmb3IgZHJtX2ZiX2hlbHBlcl9pb2N0 bAo+ICAgLSBBZGRlZCBzb21lIGxvY2tpbmcgdG8gZHJtX2ZiX2hlbHBlcl9pb2N0bAo+ICAgLSBD aGVja2VkIHRoYXQgdGhlIGZyYW1lYnVmZmVyIGlzIGluZGVlZCBhdHRhY2hlZCBiZWZvcmUgYWxs b3dpbmcgaW9jdGwKPiAgIC0gQWRkZWQgYSBtb2R1bGUgcGFyYW1ldGVyIHRvIHNwZWNpZnkgdGhl IG51bWJlciBvZiBmcmFtZWJ1ZmZlcnMgdG8KPiAgICAgYWxsb2NhdGUKPiAKPiBJbml0aWFsIGNv dmVyIGxldHRlcjogU3VwcG9ydCBmYXN0IGZyYW1lYnVmZmVyIHBhbm5pbmcgZm9yIGkuTVg2Cj4g Cj4gaW0gY3VycmVudGx5IHdvcmtpbmcgb24gc3VwcG9ydGluZyBkb3VibGUvdHJpcHBsZSBidWZm ZXJpbmcgZm9yIHRoZQo+IGZyYW1lYnVmZmVyIGVtdWxhdGlvbiBvbiB0aGUgaS5NWDYuICBXaGls ZSB3b3JraW5nIG9uIGl0IEkgbm90aWNlZCB0aGF0IHRoZQo+IG1haW5saW5lIGtlcm5lbCBkb2Vz IG5vdCBzdXBwb3J0IHNvbWUgZmVhdHVyZXMgaW4gdGhlIGdlbmVyaWMgZHJtCj4gZnJhbWVidWZm ZXIgZW11bGF0aW9uIGZvciBmcmFtZWJ1ZmZlciBwYW5uaW5nIGFuZCB2c3luYyBzeW5jaHJvbmlz YXRpb24uCj4gVGhleSBhcmUgbmVlZGVkIGZvciBzaW1wbGUgZnJhbWVidWZmZXIgYXBwbGljYXRp b25zIGFuZCBzb21lIE9wZW5HTAo+IGxpYnJhcmllcyB1c2luZyBkb3VibGUgYnVmZmVyaW5nIHdp dGggRkJJT1BVVF9WU0NSRUVOSU5GTywKPiBGQklPX1dBSVRGT1JWU1lOQyBhbmQgRkJJT1BBTl9E SVNQTEFZLgo+IAo+IFN0ZWZhbiBDaHJpc3QgKDEpOgo+ICAgZHJtL2ZiLWhlbHBlcjogaW1wbGVt ZW50IGlvY3RsIEZCSU9fV0FJVEZPUlZTWU5DCj4gCj4gWGlubGlhbmcgTGl1ICgxKToKPiAgIGRy bS9mYi1oZWxwZXI6IEFkZCBtdWx0aSBidWZmZXIgc3VwcG9ydCBmb3IgY21hIGZiZGV2Cj4gCj4g IGRyaXZlcnMvZ3B1L2RybS9LY29uZmlnICAgICAgICAgfCAgOSArKysrLQo+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX2ZiX2hlbHBlci5jIHwgNzMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKy0KPiAgaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oICAgICB8IDEyICsrKysrLQo+ICAz IGZpbGVzIGNoYW5nZWQsIDkzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBiYXNl LWNvbW1pdDogMDg3OWI5NDRjOTVkNjVmNzUyM2QxNzhkM2FkZGFlYmU4NGU1MTBlYwo+IApIaSBN YXhpbWUsCgpKdXN0IHRlc3RlZCB0aGVzZSBwYXRjaGVzIG9uIEFtbG9naWMgR1hCQiB0byBwcm92 aWRlIDNEIE1hbGkgYWNjZWxlcmF0aW9uIG9uIGZyYW1lYnVmZmVyLgoKVGVzdGVkLWJ5OiBOZWls IEFybXN0cm9uZyA8bmFybXN0cm9uZ0BiYXlsaWJyZS5jb20+CgpUaGFua3MsCk5laWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: narmstrong@baylibre.com (Neil Armstrong) Date: Thu, 16 Feb 2017 17:40:08 +0100 Subject: [PATCH v3 0/2] drm: Support framebuffer panning In-Reply-To: References: Message-ID: <6f108ce7-1e36-0177-2c23-c62fab6ebaad@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On 02/15/2017 05:19 PM, Maxime Ripard wrote: > Hi, > > This is a respin of the previous serie called "Support fast framebuffer > panning for i.MX6" made by Stefan 6 monthes ago. The imx6 bits have been > removed, and the comments that were made at that time fixed (hopefully). > > Let me know what you think, > Maxime > > Changes from v2: > - Renamed the CONFIG_DRM_CMA_FBDEV_BUFFER_NUM to > CONFIG_DRM_FBDEV_OVERALLOC, and changed it for a percentage > - Moved the overallocation code into the core fbdev helpers to not rely > on CMA anymore > - Changed the locks taken by drm_fb_helper_ioctl to the mode_config mutex > intead of calling drm_modeset_lock_all > - Don't test against drm_crtc's enabled anymore, but rely on the error > code of drm_crtc_vblank_get instead > - Defined drm_fb_helper_ioctl when DRM_FBDEV_EMULATION is not set in > order to fix a compilation error > - Don't wait for all CRTC's vblank but only the one given in the ioctl > argument > > Changes from v1: > - Added drm_fb_helper_ioctl to DRM_FB_HELPER_DEFAULT_OPS > - Expanded a bit the kerneldoc for drm_fb_helper_ioctl > - Added some locking to drm_fb_helper_ioctl > - Checked that the framebuffer is indeed attached before allowing ioctl > - Added a module parameter to specify the number of framebuffers to > allocate > > Initial cover letter: Support fast framebuffer panning for i.MX6 > > im currently working on supporting double/tripple buffering for the > framebuffer emulation on the i.MX6. While working on it I noticed that the > mainline kernel does not support some features in the generic drm > framebuffer emulation for framebuffer panning and vsync synchronisation. > They are needed for simple framebuffer applications and some OpenGL > libraries using double buffering with FBIOPUT_VSCREENINFO, > FBIO_WAITFORVSYNC and FBIOPAN_DISPLAY. > > Stefan Christ (1): > drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC > > Xinliang Liu (1): > drm/fb-helper: Add multi buffer support for cma fbdev > > drivers/gpu/drm/Kconfig | 9 ++++- > drivers/gpu/drm/drm_fb_helper.c | 73 ++++++++++++++++++++++++++++++++++- > include/drm/drm_fb_helper.h | 12 +++++- > 3 files changed, 93 insertions(+), 1 deletion(-) > > base-commit: 0879b944c95d65f7523d178d3addaebe84e510ec > Hi Maxime, Just tested these patches on Amlogic GXBB to provide 3D Mali acceleration on framebuffer. Tested-by: Neil Armstrong Thanks, Neil