From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751890AbdBIMAQ (ORCPT ); Thu, 9 Feb 2017 07:00:16 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:18143 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbdBIMAM (ORCPT ); Thu, 9 Feb 2017 07:00:12 -0500 Subject: Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration To: Jack Pham , Peter Chen References: <1486372421-29073-1-git-send-email-peter.chen@nxp.com> <1486372421-29073-7-git-send-email-peter.chen@nxp.com> <20170208204300.GC8068@usblab-sd-06.qualcomm.com> <85873d69-5664-0603-8cbd-a250d29ac335@ti.com> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Sriram Dash , Mathias Nyman From: Roger Quadros Message-ID: <6f131f15-d2f0-c8ac-c6af-accd23afab62@ti.com> Date: Thu, 9 Feb 2017 13:54:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <85873d69-5664-0603-8cbd-a250d29ac335@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/17 13:53, Roger Quadros wrote: > > > On 08/02/17 22:43, Jack Pham wrote: >> Hi Peter, Sriram, Arnd, >> >> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: >>> From: Arnd Bergmann >>> >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops for dwc3 devices. So, set >>> the dma for xhci from sysdev. sysdev is pointing to device that >>> is known to the system firmware or hardware. >>> >>> Signed-off-by: Arnd Bergmann >>> Signed-off-by: Sriram Dash >>> Tested-by: Baolin Wang >>> Tested-by: Vivek Gautam >>> Tested-by: Alexander Sverdlin >>> Signed-off-by: Mathias Nyman >>> --- >>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c >>> index 6d33b42..7a9c860 100644 >>> --- a/drivers/usb/host/xhci-plat.c >>> +++ b/drivers/usb/host/xhci-plat.c >> >>> - hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev)); >>> + hcd = __usb_create_hcd(driver, sysdev, &pdev->dev, >>> + dev_name(&pdev->dev), NULL); >> >> As mentioned already in [1], usb_create_shared_hcd() is called to create >> the second bus, however it also needs to be converted. >> >> Not exactly as Roger's suggestion but this worked for me: >> >> - xhci->shared_hcd = usb_create_shared_hcd(driver, &pdev->dev, >> + xhci->shared_hcd = __usb_create_hcd(driver, sysdev, &pdev->dev, >> dev_name(&pdev->dev), hcd); > > But we're creating a shared_hcd and there is an API for that so why not use it > instead of calling __usb_create_hcd()? > Just realized after I pressed send that there is no sysdev parameter for create_shared_hcd(). >> if (!xhci->shared_hcd) { >> ret = -ENOMEM; >> >> Without this, SuperSpeed devices fail to enumerate: >> >> usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> >> >> Thanks, >> Jack >> >> [1] https://lkml.org/lkml/2016/12/9/240 >> > -- cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration Date: Thu, 9 Feb 2017 13:54:58 +0200 Message-ID: <6f131f15-d2f0-c8ac-c6af-accd23afab62@ti.com> References: <1486372421-29073-1-git-send-email-peter.chen@nxp.com> <1486372421-29073-7-git-send-email-peter.chen@nxp.com> <20170208204300.GC8068@usblab-sd-06.qualcomm.com> <85873d69-5664-0603-8cbd-a250d29ac335@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <85873d69-5664-0603-8cbd-a250d29ac335@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jack Pham , Peter Chen Cc: mark.rutland@arm.com, ulf.hansson@linaro.org, heiko@sntech.de, stephen.boyd@linaro.org, linux-kernel@vger.kernel.org, gary.bisson@boundarydevices.com, Sriram Dash , festevam@gmail.com, stillcompiling@gmail.com, arnd@arndb.de, dbaryshkov@gmail.com, vaibhav.hiremath@linaro.org, krzk@kernel.org, mka@chromium.org, stern@rowland.harvard.edu, devicetree@vger.kernel.org, mail@maciej.szmigiero.name, pawel.moll@arm.com, linux-pm@vger.kernel.org, s.hauer@pengutronix.de, troy.kisky@boundarydevices.com, robh+dt@kernel.org, Mathias Nyman , linux-arm-kernel@lists.infradead.org, hverkuil@xs4all.nl, oscar@naiandei.net, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, rjw@rjwysocki.net, sre@kernel.org, broonie@kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org List-Id: devicetree@vger.kernel.org On 09/02/17 13:53, Roger Quadros wrote: > > > On 08/02/17 22:43, Jack Pham wrote: >> Hi Peter, Sriram, Arnd, >> >> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: >>> From: Arnd Bergmann >>> >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops for dwc3 devices. So, set >>> the dma for xhci from sysdev. sysdev is pointing to device that >>> is known to the system firmware or hardware. >>> >>> Signed-off-by: Arnd Bergmann >>> Signed-off-by: Sriram Dash >>> Tested-by: Baolin Wang >>> Tested-by: Vivek Gautam >>> Tested-by: Alexander Sverdlin >>> Signed-off-by: Mathias Nyman >>> --- >>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c >>> index 6d33b42..7a9c860 100644 >>> --- a/drivers/usb/host/xhci-plat.c >>> +++ b/drivers/usb/host/xhci-plat.c >> >>> - hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev)); >>> + hcd = __usb_create_hcd(driver, sysdev, &pdev->dev, >>> + dev_name(&pdev->dev), NULL); >> >> As mentioned already in [1], usb_create_shared_hcd() is called to create >> the second bus, however it also needs to be converted. >> >> Not exactly as Roger's suggestion but this worked for me: >> >> - xhci->shared_hcd = usb_create_shared_hcd(driver, &pdev->dev, >> + xhci->shared_hcd = __usb_create_hcd(driver, sysdev, &pdev->dev, >> dev_name(&pdev->dev), hcd); > > But we're creating a shared_hcd and there is an API for that so why not use it > instead of calling __usb_create_hcd()? > Just realized after I pressed send that there is no sysdev parameter for create_shared_hcd(). >> if (!xhci->shared_hcd) { >> ret = -ENOMEM; >> >> Without this, SuperSpeed devices fail to enumerate: >> >> usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> >> >> Thanks, >> Jack >> >> [1] https://lkml.org/lkml/2016/12/9/240 >> > -- cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 From: rogerq@ti.com (Roger Quadros) Date: Thu, 9 Feb 2017 13:54:58 +0200 Subject: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration In-Reply-To: <85873d69-5664-0603-8cbd-a250d29ac335@ti.com> References: <1486372421-29073-1-git-send-email-peter.chen@nxp.com> <1486372421-29073-7-git-send-email-peter.chen@nxp.com> <20170208204300.GC8068@usblab-sd-06.qualcomm.com> <85873d69-5664-0603-8cbd-a250d29ac335@ti.com> Message-ID: <6f131f15-d2f0-c8ac-c6af-accd23afab62@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/02/17 13:53, Roger Quadros wrote: > > > On 08/02/17 22:43, Jack Pham wrote: >> Hi Peter, Sriram, Arnd, >> >> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: >>> From: Arnd Bergmann >>> >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops for dwc3 devices. So, set >>> the dma for xhci from sysdev. sysdev is pointing to device that >>> is known to the system firmware or hardware. >>> >>> Signed-off-by: Arnd Bergmann >>> Signed-off-by: Sriram Dash >>> Tested-by: Baolin Wang >>> Tested-by: Vivek Gautam >>> Tested-by: Alexander Sverdlin >>> Signed-off-by: Mathias Nyman >>> --- >>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c >>> index 6d33b42..7a9c860 100644 >>> --- a/drivers/usb/host/xhci-plat.c >>> +++ b/drivers/usb/host/xhci-plat.c >> >>> - hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev)); >>> + hcd = __usb_create_hcd(driver, sysdev, &pdev->dev, >>> + dev_name(&pdev->dev), NULL); >> >> As mentioned already in [1], usb_create_shared_hcd() is called to create >> the second bus, however it also needs to be converted. >> >> Not exactly as Roger's suggestion but this worked for me: >> >> - xhci->shared_hcd = usb_create_shared_hcd(driver, &pdev->dev, >> + xhci->shared_hcd = __usb_create_hcd(driver, sysdev, &pdev->dev, >> dev_name(&pdev->dev), hcd); > > But we're creating a shared_hcd and there is an API for that so why not use it > instead of calling __usb_create_hcd()? > Just realized after I pressed send that there is no sysdev parameter for create_shared_hcd(). >> if (!xhci->shared_hcd) { >> ret = -ENOMEM; >> >> Without this, SuperSpeed devices fail to enumerate: >> >> usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd >> usb 2-1: device descriptor read/8, error -11 >> >> >> Thanks, >> Jack >> >> [1] https://lkml.org/lkml/2016/12/9/240 >> > -- cheers, -roger