All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto : asymmetric_keys: Fix function description to match prototype
@ 2021-10-06 17:23 Colin King
  2021-10-06 17:41 ` Ben Boeckel
  2021-10-06 17:45 ` Randy Dunlap
  0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2021-10-06 17:23 UTC (permalink / raw)
  To: David Howells, Herbert Xu, David S . Miller, keyrings, linux-crypto
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The function arguments in the description does not match the prototype.
Fix this by renaming trust_keys to trusted_keys.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 crypto/asymmetric_keys/verify_pefile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c
index 7553ab18db89..148cad70fe79 100644
--- a/crypto/asymmetric_keys/verify_pefile.c
+++ b/crypto/asymmetric_keys/verify_pefile.c
@@ -387,7 +387,7 @@ static int pefile_digest_pe(const void *pebuf, unsigned int pelen,
  * verify_pefile_signature - Verify the signature on a PE binary image
  * @pebuf: Buffer containing the PE binary image
  * @pelen: Length of the binary image
- * @trust_keys: Signing certificate(s) to use as starting points
+ * @trusted_keys: Signing certificate(s) to use as starting points
  * @usage: The use to which the key is being put.
  *
  * Validate that the certificate chain inside the PKCS#7 message inside the PE
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto : asymmetric_keys: Fix function description to match prototype
  2021-10-06 17:23 [PATCH] crypto : asymmetric_keys: Fix function description to match prototype Colin King
@ 2021-10-06 17:41 ` Ben Boeckel
  2021-10-06 17:45 ` Randy Dunlap
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Boeckel @ 2021-10-06 17:41 UTC (permalink / raw)
  To: Colin King
  Cc: David Howells, Herbert Xu, David S . Miller, keyrings,
	linux-crypto, kernel-janitors, linux-kernel, Randy Dunlap

On Wed, Oct 06, 2021 at 18:23:50 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function arguments in the description does not match the prototype.
> Fix this by renaming trust_keys to trusted_keys.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  crypto/asymmetric_keys/verify_pefile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c
> index 7553ab18db89..148cad70fe79 100644
> --- a/crypto/asymmetric_keys/verify_pefile.c
> +++ b/crypto/asymmetric_keys/verify_pefile.c
> @@ -387,7 +387,7 @@ static int pefile_digest_pe(const void *pebuf, unsigned int pelen,
>   * verify_pefile_signature - Verify the signature on a PE binary image
>   * @pebuf: Buffer containing the PE binary image
>   * @pelen: Length of the binary image
> - * @trust_keys: Signing certificate(s) to use as starting points
> + * @trusted_keys: Signing certificate(s) to use as starting points
>   * @usage: The use to which the key is being put.
>   *
>   * Validate that the certificate chain inside the PKCS#7 message inside the PE

FYI, this was submitted earlier this week with Message-Id:

    20211004001731.26240-1-rdunlap@infradead.org

which also fixes the `Return:` notation for the return value docs.

--Ben

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto : asymmetric_keys: Fix function description to match prototype
  2021-10-06 17:23 [PATCH] crypto : asymmetric_keys: Fix function description to match prototype Colin King
  2021-10-06 17:41 ` Ben Boeckel
@ 2021-10-06 17:45 ` Randy Dunlap
  1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-10-06 17:45 UTC (permalink / raw)
  To: Colin King, David Howells, Herbert Xu, David S . Miller,
	keyrings, linux-crypto
  Cc: kernel-janitors, linux-kernel

On 10/6/21 10:23 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function arguments in the description does not match the prototype.
> Fix this by renaming trust_keys to trusted_keys.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   crypto/asymmetric_keys/verify_pefile.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c
> index 7553ab18db89..148cad70fe79 100644
> --- a/crypto/asymmetric_keys/verify_pefile.c
> +++ b/crypto/asymmetric_keys/verify_pefile.c
> @@ -387,7 +387,7 @@ static int pefile_digest_pe(const void *pebuf, unsigned int pelen,
>    * verify_pefile_signature - Verify the signature on a PE binary image
>    * @pebuf: Buffer containing the PE binary image
>    * @pelen: Length of the binary image
> - * @trust_keys: Signing certificate(s) to use as starting points
> + * @trusted_keys: Signing certificate(s) to use as starting points
>    * @usage: The use to which the key is being put.
>    *
>    * Validate that the certificate chain inside the PKCS#7 message inside the PE
> 

or this one (which I have sent 2x):
https://lore.kernel.org/all/20211004001731.26240-1-rdunlap@infradead.org/

-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-06 17:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 17:23 [PATCH] crypto : asymmetric_keys: Fix function description to match prototype Colin King
2021-10-06 17:41 ` Ben Boeckel
2021-10-06 17:45 ` Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.