From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCHv3 27/30] drm/omap: dispc: improve debug print of display flags Date: Wed, 29 Mar 2017 13:27:24 +0300 Message-ID: <6f225b02-b55c-00d3-4a41-55005ae85326@ti.com> References: <1490706496-4959-1-git-send-email-tomi.valkeinen@ti.com> <1490706496-4959-28-git-send-email-tomi.valkeinen@ti.com> <1699678.sT0gvRgBUH@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0698653692==" Return-path: Received: from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7EEE6E3DC for ; Wed, 29 Mar 2017 10:27:29 +0000 (UTC) In-Reply-To: <1699678.sT0gvRgBUH@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Jyri Sarha , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0698653692== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2asoUeai0cLOewUUXLdEebvNHa82FJtxi" --2asoUeai0cLOewUUXLdEebvNHa82FJtxi Content-Type: multipart/mixed; boundary="Rt1TqPPsxXc9ffMmwrkQ4LGCTrvRwuDOT"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Jyri Sarha Message-ID: <6f225b02-b55c-00d3-4a41-55005ae85326@ti.com> Subject: Re: [PATCHv3 27/30] drm/omap: dispc: improve debug print of display flags References: <1490706496-4959-1-git-send-email-tomi.valkeinen@ti.com> <1490706496-4959-28-git-send-email-tomi.valkeinen@ti.com> <1699678.sT0gvRgBUH@avalon> In-Reply-To: <1699678.sT0gvRgBUH@avalon> --Rt1TqPPsxXc9ffMmwrkQ4LGCTrvRwuDOT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 29/03/17 12:00, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. >=20 > On Tuesday 28 Mar 2017 16:08:13 Tomi Valkeinen wrote: >> Instead of printing 0/1 for display flags like vsync high/low, use a >> tri-state print (-1/0/1) to indicate the "undefined" state. >=20 > Even better would be to use high/low/unknown (or H/L/U or any similar s= et of=20 > values). Hmm I don't know... high/low/unknown would make the debug print much longer, whereas H/L/U doesn't mean anything unless you check it from the driver code. Well, probably -1/0/1 is not exactly clear either, but it's the shortest and clearest option I have in mind. Tomi --Rt1TqPPsxXc9ffMmwrkQ4LGCTrvRwuDOT-- --2asoUeai0cLOewUUXLdEebvNHa82FJtxi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJY24wMAAoJEPo9qoy8lh71iSIQAJzq0PMVG3wenUVofbpaNrcX 8WF+v3NYv1ojn9KskqCMU9eQcpKbR79L65s1tsSyjz09bTEWkWC/5Nv7wjivJMlP fAgFd2hkEmXG7ql3lhnWwCykr+sOicm5pZVVAG+XN5M55nalGQk+0seUNNRaVTXS WYZy940wIHyHqDT7rNFnNCe6GbHteMOZ6P22KkI/D4F1ToANzINK3mUpZ7jNF515 J59WbSb5rcjekGelcClU9hIDnd30+u4zmbLv08O/M4FhffXEQ0exSay8WaMw0TXA o6680qnbxH6+CJ68UUDKSvYCUtvwxNDptMSdS1WaXWtsho30bGqqf40LREk0ubZJ 1CUb2gaSdEhN9ykyMCspzT9ZFX/ITEoJ0wAFKNB/45TjsHS3N0AaHJehEQBHkNrh 7msjOi5UfGYympMrUO1i8C8QXpigs6NJa/HWtLCZDD7YUAPSEcy11CUmhmiKMv5H xFfX8r9umr3TkeaGHgfxCa0GDrt98QRmqFLCDBEZImskrV+z58s2vXlAOtGhi5Tk kDhq5VH9i2KP80Jqd7KpA6ako5kquyRW0gzSd9oiSI0u9QsEQlBshAPgPXrJuxjN c7qAJrTuNOYdW+lVxQYKWoqZIeUPxfc3YaPCLHQolI91DqPvBnGh9cwXUuGkqKpk fmYZjDSdW9sX86BhBHR/ =L1Ws -----END PGP SIGNATURE----- --2asoUeai0cLOewUUXLdEebvNHa82FJtxi-- --===============0698653692== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0698653692==--