From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70380C2B9F4 for ; Fri, 25 Jun 2021 15:44:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 533B261945 for ; Fri, 25 Jun 2021 15:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229959AbhFYPqc (ORCPT ); Fri, 25 Jun 2021 11:46:32 -0400 Received: from mga01.intel.com ([192.55.52.88]:62970 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbhFYPqb (ORCPT ); Fri, 25 Jun 2021 11:46:31 -0400 IronPort-SDR: Lps/CfaG0jrd6eQIFEoZJLK3akLn2Nv5+ZHY81DihrSrqtzNnTzv5RwXHvTuAhYw3WO0YyJz+2 ZBcCcKvxtsnA== X-IronPort-AV: E=McAfee;i="6200,9189,10026"; a="229289098" X-IronPort-AV: E=Sophos;i="5.83,299,1616482800"; d="scan'208";a="229289098" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2021 08:44:10 -0700 IronPort-SDR: 5bPanxU12mvPDvTlogfFG4dT8fLYFZ/4BLxZD6jKIRYjohTxacPTaNXDYBN7cLfG4BblN1XeSg aLAdvnmOh4QA== X-IronPort-AV: E=Sophos;i="5.83,299,1616482800"; d="scan'208";a="488228748" Received: from akleen-mobl1.amr.corp.intel.com (HELO [10.209.62.195]) ([10.209.62.195]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2021 08:44:10 -0700 Subject: Re: [PATCH 2/7] perf: Create a symlink for a PMU To: "Liang, Kan" , Greg KH Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, eranian@google.com, namhyung@kernel.org, acme@kernel.org, jolsa@redhat.com References: <1624497729-158864-1-git-send-email-kan.liang@linux.intel.com> <1624497729-158864-3-git-send-email-kan.liang@linux.intel.com> <1e536604-cf93-0f09-401e-2073924c5582@linux.intel.com> <29d5f315-578f-103c-9523-ae890e29c7e7@linux.intel.com> <540d8a38-da12-56c8-8306-8d3d61ae1d6b@linux.intel.com> From: Andi Kleen Message-ID: <6f2941a4-4a32-ea09-bbc6-5a8e4836411b@linux.intel.com> Date: Fri, 25 Jun 2021 08:44:09 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > We have an attribute "caps/pmu_name" for the core PMU. Maybe we should > add it for uncore PMU as well. For example, > > $ cat /sys/devices/uncore_type_0_0/caps/pmu_name > cha_0 > > Userspace tool can get clues about what type_0_0 is. It would break all the old tools, but I suppose it could work for updated tools. It isn't only perf that is parsing this, but some other libraries too. They all would need to be updated too. I think I still prefer the symlink. It would just work and keep full compatibility. But yes maybe there is no choice. -Andi