From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbcKYV3n (ORCPT ); Fri, 25 Nov 2016 16:29:43 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:60248 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbcKYV3W (ORCPT ); Fri, 25 Nov 2016 16:29:22 -0500 Subject: Re: [PATCH] cxgb4: fix memory leak on txq_info To: David Miller References: <20161123110244.16111-1-colin.king@canonical.com> <20161125.161058.2283539123524395654.davem@davemloft.net> Cc: hariprasad@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: <6f2da092-213e-3c0b-d1be-97963b393f42@canonical.com> Date: Fri, 25 Nov 2016 21:28:13 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161125.161058.2283539123524395654.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/11/16 21:10, David Miller wrote: > From: Colin King > Date: Wed, 23 Nov 2016 11:02:44 +0000 > >> From: Colin Ian King >> >> Currently if txq_info->uldtxq cannot be allocated then >> txq_info->txq is being kfree'd (which is redundant because it >> is NULL) instead of txq_info. Fix this by instead kfree'ing >> txq_info. >> >> Signed-off-by: Colin Ian King > > Applied, but Colin you _really_ need to start properly marking your > networking patch submissions by indicating in the subject which > tree your change is for. In this case I figured out it was > net-next, but you must say this explicitly in the Subject line > via "Subject: [PATCH net-next] ..." > > Thanks. > Understood, will do next time, apologies for that. Colin