All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Przywara" <andre.przywara@arm.com>
To: Leo Yan <leo.yan@linaro.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Wei Li <liwei391@huawei.com>, James Clark <james.clark@arm.com>,
	Al Grant <Al.Grant@arm.com>, Dave Martin <Dave.Martin@arm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 13/21] perf arm-spe: Refactor counter packet handling
Date: Tue, 27 Oct 2020 14:54:19 +0000	[thread overview]
Message-ID: <6f2e6fa9-81a0-d66b-9d2e-2e4955c105ef@arm.com> (raw)
In-Reply-To: <20201027030917.15404-14-leo.yan@linaro.org>

On 27/10/2020 03:09, Leo Yan wrote:
> This patch defines macros for counter packet header, and uses macros to
> replace hard code values in functions arm_spe_get_counter() and
> arm_spe_pkt_desc().
> 
> In the function arm_spe_get_counter(), adds a new line for more
> readable.
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 11 ++++++-----
>  tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h |  5 +++++
>  2 files changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> index 8f481c6ea054..4be649c26002 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> @@ -152,10 +152,11 @@ static int arm_spe_get_counter(const unsigned char *buf, size_t len,
>  			       const unsigned char ext_hdr, struct arm_spe_pkt *packet)
>  {
>  	packet->type = ARM_SPE_COUNTER;
> +
>  	if (ext_hdr)
> -		packet->index = ((buf[0] & 0x3) << 3) | (buf[1] & 0x7);
> +		packet->index = SPE_HDR_EXTENDED_INDEX(buf[0], buf[1]);
>  	else
> -		packet->index = buf[0] & 0x7;
> +		packet->index = SPE_HDR_SHORT_INDEX(buf[0]);
>  
>  	return arm_spe_get_payload(buf, len, ext_hdr, packet);
>  }
> @@ -307,17 +308,17 @@ static int arm_spe_pkt_desc_counter(const struct arm_spe_pkt *packet,
>  		return ret;
>  
>  	switch (packet->index) {
> -	case 0:
> +	case SPE_CNT_PKT_HDR_INDEX_TOTAL_LAT:
>  		ret = arm_spe_pkt_snprintf(&buf, &blen, "TOT");
>  		if (ret < 0)
>  			return ret;
>  		break;
> -	case 1:
> +	case SPE_CNT_PKT_HDR_INDEX_ISSUE_LAT:
>  		ret = arm_spe_pkt_snprintf(&buf, &blen, "ISSUE");
>  		if (ret < 0)
>  			return ret;
>  		break;
> -	case 2:
> +	case SPE_CNT_PKT_HDR_INDEX_TRANS_LAT:
>  		ret = arm_spe_pkt_snprintf(&buf, &blen, "XLAT");
>  		if (ret < 0)
>  			return ret;
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
> index 9bc876bffd35..7d8e34e35f05 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
> @@ -82,6 +82,11 @@ struct arm_spe_pkt {
>  /* Context packet header */
>  #define SPE_CTX_PKT_HDR_INDEX(h)		((h) & GENMASK_ULL(1, 0))
>  
> +/* Counter packet header */
> +#define SPE_CNT_PKT_HDR_INDEX_TOTAL_LAT		0x0
> +#define SPE_CNT_PKT_HDR_INDEX_ISSUE_LAT		0x1
> +#define SPE_CNT_PKT_HDR_INDEX_TRANS_LAT		0x2
> +
>  const char *arm_spe_pkt_name(enum arm_spe_pkt_type);
>  
>  int arm_spe_get_packet(const unsigned char *buf, size_t len,
> 


  reply	other threads:[~2020-10-27 17:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27  3:08 [PATCH v4 00/21] perf arm-spe: Refactor decoding & dumping flow Leo Yan
2020-10-27  3:08 ` [PATCH v4 01/21] perf arm-spe: Include bitops.h for BIT() macro Leo Yan
2020-10-27  3:08 ` [PATCH v4 02/21] perf arm-spe: Fix a typo in comment Leo Yan
2020-10-27  3:08 ` [PATCH v4 03/21] perf arm-spe: Refactor payload size calculation Leo Yan
2020-10-27 14:53   ` André Przywara
2020-10-27  3:09 ` [PATCH v4 04/21] perf arm-spe: Refactor arm_spe_get_events() Leo Yan
2020-10-27  3:09 ` [PATCH v4 05/21] perf arm-spe: Fix packet length handling Leo Yan
2020-10-27  3:09 ` [PATCH v4 06/21] perf arm-spe: Refactor printing string to buffer Leo Yan
2020-10-27 14:31   ` Dave Martin
2020-10-27 14:50     ` Leo Yan
2020-10-27  3:09 ` [PATCH v4 07/21] perf arm-spe: Refactor packet header parsing Leo Yan
2020-10-27  3:09 ` [PATCH v4 08/21] perf arm-spe: Add new function arm_spe_pkt_desc_addr() Leo Yan
2020-10-27  3:09 ` [PATCH v4 09/21] perf arm-spe: Refactor address packet handling Leo Yan
2020-10-27 14:53   ` André Przywara
2020-10-27  3:09 ` [PATCH v4 10/21] perf arm_spe: Fixup top byte for data virtual address Leo Yan
2020-10-27 15:01   ` André Przywara
2020-10-28  6:49     ` Leo Yan
2020-10-27  3:09 ` [PATCH v4 11/21] perf arm-spe: Refactor context packet handling Leo Yan
2020-10-27  3:09 ` [PATCH v4 12/21] perf arm-spe: Add new function arm_spe_pkt_desc_counter() Leo Yan
2020-10-27  3:09 ` [PATCH v4 13/21] perf arm-spe: Refactor counter packet handling Leo Yan
2020-10-27 14:54   ` André Przywara [this message]
2020-10-27  3:09 ` [PATCH v4 14/21] perf arm-spe: Add new function arm_spe_pkt_desc_event() Leo Yan
2020-10-27  3:09 ` [PATCH v4 15/21] perf arm-spe: Refactor event type handling Leo Yan
2020-10-27  3:09 ` [PATCH v4 16/21] perf arm-spe: Remove size condition checking for events Leo Yan
2020-10-27  3:09 ` [PATCH v4 17/21] perf arm-spe: Add new function arm_spe_pkt_desc_op_type() Leo Yan
2020-10-27  3:09 ` [PATCH v4 18/21] perf arm-spe: Refactor operation packet handling Leo Yan
2020-10-27 14:54   ` André Przywara
2020-10-27  3:09 ` [PATCH v4 19/21] perf arm-spe: Add more sub classes for operation packet Leo Yan
2020-10-27  3:09 ` [PATCH v4 20/21] perf arm_spe: Decode memory tagging properties Leo Yan
2020-10-27  3:09 ` [PATCH v4 21/21] perf arm-spe: Add support for ARMv8.3-SPE Leo Yan
2020-10-27 14:54   ` André Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f2e6fa9-81a0-d66b-9d2e-2e4955c105ef@arm.com \
    --to=andre.przywara@arm.com \
    --cc=Al.Grant@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwei391@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.