From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46DBDC433B4 for ; Tue, 18 May 2021 10:00:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C58526024A for ; Tue, 18 May 2021 10:00:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C58526024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liwWA-0005Q2-Sr for qemu-devel@archiver.kernel.org; Tue, 18 May 2021 06:00:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liw9o-00023y-Fv for qemu-devel@nongnu.org; Tue, 18 May 2021 05:36:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liw9m-0005WA-RA for qemu-devel@nongnu.org; Tue, 18 May 2021 05:36:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621330614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MTN0yGLbtPzopc9zBVT6PRV8hDfLfbfmzXtEQzDQLL4=; b=ODe+2yJmGepK7t22L+Lz5oLodm28bhL/QPMwmVSUgfk+zpt3rg3Mflu4bSMENNHl3tFIAe M6XbwHF+3sfF9DLUNlWHTRzC7FwE0wKNIXILfP9XX7BLnP58ESOupNPmLR239JrH3F/TVz qX7Wq7aR/wkwqePAFQ/E6Mu08dEs3+8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-577-tTSZgJEWNryDz5ITf-yhBw-1; Tue, 18 May 2021 05:36:53 -0400 X-MC-Unique: tTSZgJEWNryDz5ITf-yhBw-1 Received: by mail-wr1-f72.google.com with SMTP id d12-20020adfc3cc0000b029011166e2f1a7so4359055wrg.19 for ; Tue, 18 May 2021 02:36:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MTN0yGLbtPzopc9zBVT6PRV8hDfLfbfmzXtEQzDQLL4=; b=jnKlukYjnntBi3iDuQ9Vn1H49DE/iMK7AasC0wxaI4X7E64YuhF3WGV1aONGJ0tlck MlI4RtRMZWj8C6T9PD4bC/IgDnUkJ23zw25vahqAgyWm6SI+eO7KSiVj6JKVKC6t8Gpc DzPDGcf+Ot4bi59Dw2RcO/4tQYBIfC5HaGQ0U+u5zCFbhqD7+Y88MOA8in2bvjxYYp3c a8ZPBEvZrfcv/B0NhEJlCxOAcyrdR6aBOyR0E+l5NcJfH2I/LmPtvQ9PDrzJbEqOTw54 ZLotfueWqePaRWDn7JRHSU57DIA0KMhNIE+ASYstDsKWgLlTlbEc1BtIUAcjtjIMLum+ RdEQ== X-Gm-Message-State: AOAM533lWVI0gmvCVH3Sbjx+ZVZV/aLqmgy7HkNV9/e/LufKxtzG7mvB iQQQcsFsnxf4l52y4b/L3+wmCC+9MMtmh0wCz3cYLK3hpCpL9aBOd9Hj2l8/nUoqeHCGEZU1H+m H0T2pZ+nYJWr1/0g= X-Received: by 2002:a1c:f219:: with SMTP id s25mr3943475wmc.31.1621330610847; Tue, 18 May 2021 02:36:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHgvm7mNxU7rvM3nwKIqBXfSx5GKwv8DaFEITcLiWypqwjHdhENemquBQXO5aHMSDQ29V/Kg== X-Received: by 2002:a1c:f219:: with SMTP id s25mr3943456wmc.31.1621330610641; Tue, 18 May 2021 02:36:50 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id g5sm7307677wmi.8.2021.05.18.02.36.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 May 2021 02:36:50 -0700 (PDT) Subject: Re: [PATCH v2 26/50] target/i386: Reduce DisasContext jmp_opt, repz_opt to bool To: Richard Henderson , qemu-devel@nongnu.org References: <20210514151342.384376-1-richard.henderson@linaro.org> <20210514151342.384376-27-richard.henderson@linaro.org> From: Paolo Bonzini Message-ID: <6f3a7d01-4d34-8814-0298-bcdd5373d341@redhat.com> Date: Tue, 18 May 2021 11:36:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210514151342.384376-27-richard.henderson@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cfontana@suse.de, f4bug@amsat.org, ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 14/05/21 17:13, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/i386/tcg/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c > index 3f6214c624..b9b94f0625 100644 > --- a/target/i386/tcg/translate.c > +++ b/target/i386/tcg/translate.c > @@ -101,8 +101,8 @@ typedef struct DisasContext { > uint8_t vex_v; /* vex vvvv register, without 1's complement. */ > CCOp cc_op; /* current CC operation */ > bool cc_op_dirty; > - int jmp_opt; /* use direct block chaining for direct jumps */ > - int repz_opt; /* optimize jumps within repz instructions */ > + bool jmp_opt; /* use direct block chaining for direct jumps */ > + bool repz_opt; /* optimize jumps within repz instructions */ > int mem_index; /* select memory access functions */ > uint32_t flags; /* all execution flags */ > uint8_t popl_esp_hack; /* for correct popl with esp base handling */ > Reviewed-by: Paolo Bonzini