From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
daniel@ffwll.ch, airlied@linux.ie,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
jani.nikula@linux.intel.com, lyude@redhat.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 7/8] drm/display: Move HDMI helpers into display-helper module
Date: Wed, 20 Apr 2022 14:02:04 +0200 [thread overview]
Message-ID: <6f4c5894-a154-b0f8-084a-4ba8f66cd4ea@redhat.com> (raw)
In-Reply-To: <20220420110900.8707-8-tzimmermann@suse.de>
Hello Thomas,
On 4/20/22 13:08, Thomas Zimmermann wrote:
[snip]
> --- a/drivers/gpu/drm/bridge/synopsys/Kconfig
> +++ b/drivers/gpu/drm/bridge/synopsys/Kconfig
> @@ -1,6 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_DW_HDMI
> tristate
> + select DRM_DISPLAY_HDMI_HELPER
> + select DRM_DISPLAY_HELPER
> select DRM_KMS_HELPER
> select REGMAP_MMIO
> select CEC_CORE if CEC_NOTIFIER
[snip]
> +config DRM_DISPLAY_HDMI_HELPER
> + bool
> + select DRM_DISPLAY_HELPER
> + help
> + DRM display helpers for HDMI.
> +
Maybe you mentioned already when we discussed it in v1, but could
you please remember me why we need to select both symbols for the
drivers, even when DRM_DISPLAY_HELPER is already selected here ?
Or are select operations not transitive ?
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-04-20 12:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 11:08 [PATCH v2 0/8] drm: Introduce display-helper library Thomas Zimmermann
2022-04-20 11:08 ` [PATCH v2 1/8] drm: Put related statements next to each other in Makefile Thomas Zimmermann
2022-04-20 11:08 ` [PATCH v2 2/8] drm: Rename dp/ to display/ Thomas Zimmermann
2022-04-20 11:08 ` [PATCH v2 3/8] drm/display: Introduce a DRM display-helper module Thomas Zimmermann
2022-04-20 11:08 ` [PATCH v2 4/8] drm/display: Split DisplayPort header into core and helper Thomas Zimmermann
2022-04-20 11:08 ` [PATCH v2 5/8] drm/display: Move DSC header and helpers into display-helper module Thomas Zimmermann
2022-04-20 11:08 ` [PATCH v2 6/8] drm/display: Move HDCP " Thomas Zimmermann
2022-04-20 11:08 ` [PATCH v2 7/8] drm/display: Move HDMI " Thomas Zimmermann
2022-04-20 12:02 ` Javier Martinez Canillas [this message]
2022-04-20 12:21 ` Thomas Zimmermann
2022-04-20 12:26 ` Javier Martinez Canillas
2022-04-20 13:12 ` Thomas Zimmermann
2022-04-20 13:22 ` Javier Martinez Canillas
2022-04-20 11:09 ` [PATCH v2 8/8] drm/display: Move SCDC helpers into display-helper library Thomas Zimmermann
2022-04-20 12:06 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f4c5894-a154-b0f8-084a-4ba8f66cd4ea@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.