From: Randy Dunlap <rdunlap@infradead.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Dave Hansen <dave.hansen@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
linux-mm@kvack.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP
Date: Tue, 21 Mar 2023 08:29:16 -0700 [thread overview]
Message-ID: <6f5fd9d9-f247-a7c0-a5e5-c40c37c76281@infradead.org> (raw)
In-Reply-To: <67261c513706241d479b8b4cf46eb4e6fb0417ba.1679387262.git.geert+renesas@glider.be>
On 3/21/23 01:30, Geert Uytterhoeven wrote:
> sh/migor_defconfig:
>
> mm/slab.c: In function ‘slab_memory_callback’:
> mm/slab.c:1127:23: error: implicit declaration of function ‘init_cache_node_node’; did you mean ‘drain_cache_node_node’? [-Werror=implicit-function-declaration]
> 1127 | ret = init_cache_node_node(nid);
> | ^~~~~~~~~~~~~~~~~~~~
> | drain_cache_node_node
>
> The #ifdef condition protecting the definition of init_cache_node_node()
> no longer matches the conditions protecting the (multiple) users.
>
> Fix this by syncing the conditions.
>
> Fixes: 76af6a054da40553 ("mm/migrate: add CPU hotplug to demotion #ifdef")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Link: https://lore.kernel.org/r/b5bdea22-ed2f-3187-6efe-0c72330270a4@infradead.org
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> mm/slab.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index ba454246ee13dd4d..de1523a78f2e7367 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -839,7 +839,7 @@ static int init_cache_node(struct kmem_cache *cachep, int node, gfp_t gfp)
> return 0;
> }
>
> -#if (defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG)) || defined(CONFIG_SMP)
> +#if defined(CONFIG_NUMA) || defined(CONFIG_SMP)
> /*
> * Allocates and initializes node for a node on each slab cache, used for
> * either memory or cpu hotplug. If memory is being hot-added, the kmem_cache_node
--
~Randy
next prev parent reply other threads:[~2023-03-21 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 8:30 [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP Geert Uytterhoeven
2023-03-21 8:41 ` John Paul Adrian Glaubitz
2023-03-21 8:50 ` Geert Uytterhoeven
2023-03-21 15:07 ` Vlastimil Babka
2023-03-21 15:29 ` Randy Dunlap [this message]
2023-03-21 16:40 ` Matthew Wilcox
2023-03-21 16:43 ` Randy Dunlap
2023-03-22 16:16 ` Dave Hansen
2023-03-22 16:46 ` Matthew Wilcox
2023-03-22 16:49 ` Dave Hansen
2023-03-23 8:25 ` Geert Uytterhoeven
2023-03-23 8:28 ` John Paul Adrian Glaubitz
2023-03-23 8:36 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f5fd9d9-f247-a7c0-a5e5-c40c37c76281@infradead.org \
--to=rdunlap@infradead.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=dave.hansen@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=glaubitz@physik.fu-berlin.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.