Re: [PATCH] eal: add Bus log type

[Shreyansh Jain <shreyansh.jain@nxp.com>]

On Tuesday 20 June 2017 02:24 AM, Thomas Monjalon wrote:
> 19/06/2017 13:03, Shreyansh Jain:
>>> --- a/lib/librte_eal/common/include/rte_log.h
>>> +++ b/lib/librte_eal/common/include/rte_log.h
>>> @@ -87,6 +87,7 @@ extern struct rte_logs rte_logs;
>>>   #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
>>>   #define RTE_LOGTYPE_EFD       18 /**< Log related to EFD. */
>>>   #define RTE_LOGTYPE_EVENTDEV  19 /**< Log related to eventdev. */
>>> +#define RTE_LOGTYPE_BUS       20 /**< Log related to Bus. */
>>
>> Just wanted to ping - is there something wrong/unacceptable about this?
> 
> Sorry for not replying before.

And I am sorry for spotting your reply so late.

> 
> The strange thing is that it is not used.

Yes, because somehow I forgot this while pushing bus/fslmc. I (had (*)) plan to change this for bus/fslmc in subsequent patches.

> At least, the existing bus logs should be converted.
> I've spotted few lines in drivers/bus/fslmc/.
> 
> And more importantly, we must switch to the new dynamic types
> using rte_log_register().
> 

(*)
ok. In which case, this patch would become redundant. I will add support for this in dpaa (and dpaa2 driver, next).

-
Shreyansh