[MPTCP] Re: [PATCH v2 mptcp-next 0/5] mptcp: netlink event support

[MPTCP] Re: [PATCH v2 mptcp-next 0/5] mptcp: netlink event support

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

Hi Florian, Mat,

On 26/01/2021 18:01, Mat Martineau wrote:
> 
> On Wed, 20 Jan 2021, Florian Westphal wrote:
> 
>> This is round 2 of the netlink event series.
>> No changes here except in patch 4 (minor checkpatch format nit)
>> and patch 5.
> 
> Just clarifying tags after my reply to the patch 5 thread, Matthieu 
> please tag patches 1, 2, 3, and 5 with:
> 
> Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
> 
> (patch 4 tag is different, in a separate email)

Thank you for the patches and the series!

Just applied to our tree with the RvB and Acked-by tags, the 
modification of the group (mptcp_pm_events) and a micro checkpatch 
format nit (blank line after enum like the previous ones in mptcp.h).

- 57b1e8d7873c: mptcp: split __mptcp_close_ssk helper
- 37f87493bc63: mptcp: pass subflow socket to a few helpers
- 5e2330f127b5: mptcp: avoid lock_fast usage in accept path
- edd4b6f8f6ac: genetlink: add CAP_NET_ADMIN test for multicast bind
- f15cd5fd4c26: mptcp: add netlink event support
- Results: de7588363638..daa6a08b00eb

Tests + export are in progress!

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[MPTCP] Re: [PATCH v2 mptcp-next 0/5] mptcp: netlink event support

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Hi Florian, Mat,

On 26/01/2021 21:28, Matthieu Baerts wrote:
> - f15cd5fd4c26: mptcp: add netlink event support

I did a small extra modification on top of this patch to keep the 
alignment with the rest. Nothing important but still, if you need to 
copy the content of include/uapi/linux/mptcp.h elsewhere (i.e. iproute2 
and mptcpd), please make sure to use the latest version :)

- 1f2bcf78ff83: mptcp: use tab to align mptcp_pm_events
- (of course no co-dev-by tag added for that)
- Results: 331067123e0c..1d8e7211c639

Tests + export are in progress.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[MPTCP] Re: [PATCH v2 mptcp-next 0/5] mptcp: netlink event support

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]


On Wed, 20 Jan 2021, Florian Westphal wrote:

> This is round 2 of the netlink event series.
> No changes here except in patch 4 (minor checkpatch format nit)
> and patch 5.
>
> Changes since v1:
> - add missing export of ssk->sk_err.
>  This is now done for subflow related events (Mathieu)
> - fix a few indendations (Mathieu)
> - Update uapi comments (Mathieu)
> - fix checkpatch complaints
> - fix REM/LOC_ID, its NLA_U8 (Mat, Mathieu)
>
> Florian Westphal (5):
>  mptcp: split __mptcp_close_ssk helper
>  mptcp: pass subflow socket to a few helpers
>  mptcp: avoid lock_fast usage in accept path
>  genetlink: add CAP_NET_ADMIN test for multicast bind
>  mptcp: add netlink event support
>
> include/net/genetlink.h    |   1 +
> include/uapi/linux/mptcp.h |  73 ++++++++++
> net/mptcp/options.c        |   2 +-
> net/mptcp/pm.c             |  24 +++-
> net/mptcp/pm_netlink.c     | 265 ++++++++++++++++++++++++++++++++++++-
> net/mptcp/protocol.c       |  30 +++--
> net/mptcp/protocol.h       |  14 +-
> net/mptcp/subflow.c        |   2 +-
> net/netlink/genetlink.c    |  32 +++++
> 9 files changed, 418 insertions(+), 25 deletions(-)
>
> -- 
> 2.26.2

Just clarifying tags after my reply to the patch 5 thread, Matthieu please 
tag patches 1, 2, 3, and 5 with:

Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>


(patch 4 tag is different, in a separate email)

--
Mat Martineau
Intel