All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/2] a couple of userspace MSR filtering improvements
@ 2020-08-21 12:10 Chris Down
  2020-08-21 12:10 ` [PATCH v2 1/2] x86: Prevent userspace MSR access from dominating the console Chris Down
  2020-08-21 12:10 ` [PATCH v2 2/2] x86: Make source of unrecognised MSR writes unambiguous Chris Down
  0 siblings, 2 replies; 3+ messages in thread
From: Chris Down @ 2020-08-21 12:10 UTC (permalink / raw)
  To: linux-kernel
  Cc: Borislav Petkov, Jakub Kicinski, Andrew Morton, kernel-team,
	sean.j.christopherson, tony.luck, torvalds, x86

As discussed in Message-ID <20200714165621.GA3622@nazgul.tnic>.

We all agree that userspace MSR twiddling is non-ideal, but we should be
a bit cautious of taking up too much kmsg buffer if applications do
repeated writes. `allow_writes=1` is possible, but is non-ideal (see
patch 1 changelog).

Also added pid information to the message, since it makes identification
of the source (more or less) unambiguous.

Changes in v2:

- Fixed mostly aesthetic suggestions from Boris. Thanks! :-)

Chris Down (2):
  x86: Prevent userspace MSR access from dominating the console
  x86: Make source of unrecognised MSR writes unambiguous

 arch/x86/kernel/msr.c | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

-- 
2.28.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 1/2] x86: Prevent userspace MSR access from dominating the console
  2020-08-21 12:10 [PATCH v2 0/2] a couple of userspace MSR filtering improvements Chris Down
@ 2020-08-21 12:10 ` Chris Down
  2020-08-21 12:10 ` [PATCH v2 2/2] x86: Make source of unrecognised MSR writes unambiguous Chris Down
  1 sibling, 0 replies; 3+ messages in thread
From: Chris Down @ 2020-08-21 12:10 UTC (permalink / raw)
  To: linux-kernel
  Cc: Borislav Petkov, Jakub Kicinski, Andrew Morton, kernel-team,
	sean.j.christopherson, tony.luck, torvalds, x86

Applications which manipulate MSRs from userspace often do so
infrequently, and all at once. As such, the default printk ratelimit
architecture supplied by pr_err_ratelimited doesn't do enough to prevent
kmsg becoming completely overwhelmed with their messages and pushing
other salient information out of the circular buffer. In one case, I saw
over 80% of kmsg being filled with these messages, and the default kmsg
buffer being completely filled less than 5 minutes after boot(!).

Make things much less aggressive, while still achieving the original
goal of fiter_write(). Operators will still get warnings that MSRs are
being manipulated from userspace, but they won't have other also
potentially useful messages pushed out of the kmsg buffer.

Of course, one can boot with `allow_writes=1` to avoid these messages at
all, but that then has the downfall that one doesn't get _any_
notification at all about these problems in the first place, and so is
much less likely to forget to fix it. One might rather it was less
binary: it was still logged, just less often, so that application
developers _do_ have the incentive to improve their current methods,
without us having to push other useful stuff out of the kmsg buffer.

This one example isn't the point, of course: I'm sure there are plenty
of other non-ideal-but-pragmatic cases where people are writing to MSRs
from userspace right now, and it will take time for those people to find
other solutions.

Overall, keep the intent of the original patch, while mitigating its
sometimes heavy effects on kmsg composition.

Signed-off-by: Chris Down <chris@chrisdown.name>
Cc: Borislav Petkov <bp@suse.de>
Cc: Jakub Kicinski <kuba@kernel.org>
---
 arch/x86/kernel/msr.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
index 49dcfb85e773..eaf375245549 100644
--- a/arch/x86/kernel/msr.c
+++ b/arch/x86/kernel/msr.c
@@ -80,18 +80,30 @@ static ssize_t msr_read(struct file *file, char __user *buf,
 
 static int filter_write(u32 reg)
 {
+	/*
+	 * MSRs writes usually happen all at once, and can easily saturate kmsg.
+	 * Only allow 1 MSR message every 30 seconds.
+	 *
+	 * It's possible to be smarter here and do it (for example) per-MSR, but
+	 * it would certainly be more complex, and this is enough at least to
+	 * avoid saturating the ring buffer.
+	 */
+	static DEFINE_RATELIMIT_STATE(fw_rs, 30 * HZ, 1);
+
 	switch (allow_writes) {
 	case MSR_WRITES_ON:  return 0;
 	case MSR_WRITES_OFF: return -EPERM;
 	default: break;
 	}
 
+	if (!__ratelimit(&fw_rs))
+		return 0;
+
 	if (reg == MSR_IA32_ENERGY_PERF_BIAS)
 		return 0;
 
-	pr_err_ratelimited("Write to unrecognized MSR 0x%x by %s\n"
-			   "Please report to x86@kernel.org\n",
-			   reg, current->comm);
+	pr_err("Write to unrecognized MSR 0x%x by %s\n"
+	       "Please report to x86@kernel.org\n", reg, current->comm);
 
 	return 0;
 }
-- 
2.28.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 2/2] x86: Make source of unrecognised MSR writes unambiguous
  2020-08-21 12:10 [PATCH v2 0/2] a couple of userspace MSR filtering improvements Chris Down
  2020-08-21 12:10 ` [PATCH v2 1/2] x86: Prevent userspace MSR access from dominating the console Chris Down
@ 2020-08-21 12:10 ` Chris Down
  1 sibling, 0 replies; 3+ messages in thread
From: Chris Down @ 2020-08-21 12:10 UTC (permalink / raw)
  To: linux-kernel
  Cc: Borislav Petkov, Jakub Kicinski, Andrew Morton, kernel-team,
	sean.j.christopherson, tony.luck, torvalds, x86

In many cases the comm enough isn't enough to distinguish the offender,
since for interpreted languages it's likely just going to be "python3"
or whatever. Add the pid to make it unambiguous.

Signed-off-by: Chris Down <chris@chrisdown.name>
Cc: Borislav Petkov <bp@suse.de>
Cc: Jakub Kicinski <kuba@kernel.org>
---
 arch/x86/kernel/msr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
index eaf375245549..812e64ef5ff5 100644
--- a/arch/x86/kernel/msr.c
+++ b/arch/x86/kernel/msr.c
@@ -102,8 +102,9 @@ static int filter_write(u32 reg)
 	if (reg == MSR_IA32_ENERGY_PERF_BIAS)
 		return 0;
 
-	pr_err("Write to unrecognized MSR 0x%x by %s\n"
-	       "Please report to x86@kernel.org\n", reg, current->comm);
+	pr_err("Write to unrecognized MSR 0x%x by %s (pid: %d)\n"
+	       "Please report to x86@kernel.org\n",
+	       reg, current->comm, current->pid);
 
 	return 0;
 }
-- 
2.28.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-21 12:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-21 12:10 [PATCH v2 0/2] a couple of userspace MSR filtering improvements Chris Down
2020-08-21 12:10 ` [PATCH v2 1/2] x86: Prevent userspace MSR access from dominating the console Chris Down
2020-08-21 12:10 ` [PATCH v2 2/2] x86: Make source of unrecognised MSR writes unambiguous Chris Down

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.