All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: kettenis@openbsd.org, u-boot@lists.denx.de,
	patrick.delaunay@foss.st.com,  sjg@chromium.org
Subject: Re: [PATCH] power: domain: apple: Restore reset ops that return 0
Date: Tue, 26 Apr 2022 23:44:44 +0200	[thread overview]
Message-ID: <6f7c0a14-1f00-bfbd-6235-9e5a58cb4f44@denx.de> (raw)
In-Reply-To: <d3cd255800b55e2f@bloch.sibelius.xs4all.nl>

On 4/26/22 22:54, Mark Kettenis wrote:
>> Date: Tue, 26 Apr 2022 21:01:01 +0200
>> From: Marek Vasut <marex@denx.de>
>>
>> On 4/26/22 20:21, Mark Kettenis wrote:
>>>> Date: Tue, 26 Apr 2022 20:04:19 +0200
>>>> From: Marek Vasut <marex@denx.de>
>>>>
>>>> On 4/26/22 19:14, Mark Kettenis wrote:
>>>>> These were removed inadvertently in commit 20874a60722b.
>>>>> Fixes a crash on Apple M1 systems.
>>>>
>>>> The drivers/power/domain/power-domain-uclass.c should handle empty
>>>> implementation of request/rfree callback in exactly the commit you
>>>> reference above.
>>>
>>> Yes, but drivers/reset/reset-uclass.c doesn't and you also removed the
>>> request/rfree callbacks for that part of the apple_pmgr driver.
>>
>> Ah, sigh. Would it rather make sense to change the reset uclass ?
>> It would reduce the amount of empty callbacks.
> 
> Maybe.  But that should probably done as a single sweep like you did
> for the power domains.  Let's fix this crash first.

Try:
[PATCH] reset: Return 0 if ops unimplemented and remove empty functions

If this patch gets applied first, then please make sure it is also 
un-applied once the above is applied, so we don't grow useless empty 
functions again.

      reply	other threads:[~2022-04-26 21:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 17:14 [PATCH] power: domain: apple: Restore reset ops that return 0 Mark Kettenis
2022-04-26 18:04 ` Marek Vasut
2022-04-26 18:21   ` Mark Kettenis
2022-04-26 19:01     ` Marek Vasut
2022-04-26 20:54       ` Mark Kettenis
2022-04-26 21:44         ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f7c0a14-1f00-bfbd-6235-9e5a58cb4f44@denx.de \
    --to=marex@denx.de \
    --cc=kettenis@openbsd.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=patrick.delaunay@foss.st.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.