From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keerthy Subject: Re: [PATCH] pinctrl: pinctrl-single: Avoid divisions in context save/restore Date: Fri, 8 Jun 2018 12:18:05 +0530 Message-ID: <6f7fd157-8d49-d61d-c959-1f60c4dc5e8e@ti.com> References: <1528374274-26385-1-git-send-email-geert+renesas@glider.be> <20180608062602.GK5738@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180608062602.GK5738@atomide.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tony Lindgren , Geert Uytterhoeven Cc: linux-gpio@vger.kernel.org, Linus Walleij , linux-omap@vger.kernel.org, Haojian Zhuang , linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org On Friday 08 June 2018 11:56 AM, Tony Lindgren wrote: > * Geert Uytterhoeven [180607 13:40]: >> The divisions (and multiplications) can be avoided by changing the loops >> to use increments of mux_bytes instead of 1. >> While at it, remove the unneeded casts when assigning void pointers. >> >> This saves +100 bytes of kernel size on arm32/arm64. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> Compile-tested only. > > Makes sense to me: > > Acked-by: Tony Lindgren > > Keerthy can you please test? Tested on AM437x-gp-evm for Deep Sleep0. Tested-by: Keerthy Reviewed-by: Keerthy Thanks Geert! > > Regards, > > Tony > From mboxrd@z Thu Jan 1 00:00:00 1970 From: j-keerthy@ti.com (Keerthy) Date: Fri, 8 Jun 2018 12:18:05 +0530 Subject: [PATCH] pinctrl: pinctrl-single: Avoid divisions in context save/restore In-Reply-To: <20180608062602.GK5738@atomide.com> References: <1528374274-26385-1-git-send-email-geert+renesas@glider.be> <20180608062602.GK5738@atomide.com> Message-ID: <6f7fd157-8d49-d61d-c959-1f60c4dc5e8e@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 08 June 2018 11:56 AM, Tony Lindgren wrote: > * Geert Uytterhoeven [180607 13:40]: >> The divisions (and multiplications) can be avoided by changing the loops >> to use increments of mux_bytes instead of 1. >> While at it, remove the unneeded casts when assigning void pointers. >> >> This saves +100 bytes of kernel size on arm32/arm64. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> Compile-tested only. > > Makes sense to me: > > Acked-by: Tony Lindgren > > Keerthy can you please test? Tested on AM437x-gp-evm for Deep Sleep0. Tested-by: Keerthy Reviewed-by: Keerthy Thanks Geert! > > Regards, > > Tony >