From: Laura Abbott <labbott@redhat.com>
To: Yisheng Xie <xieyisheng1@huawei.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, sumit.semwal@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: android: ion: Remove lable debugfs_done
Date: Tue, 6 Feb 2018 15:00:22 -0800 [thread overview]
Message-ID: <6fa110ed-afab-b707-a2e9-7a1a94ccf92f@redhat.com> (raw)
In-Reply-To: <1517488447-41252-2-git-send-email-xieyisheng1@huawei.com>
On 02/01/2018 04:34 AM, Yisheng Xie wrote:
> When failed to create debug_root, we will go on initail other part of
> ion, so we can just info this message to user and do not need a lable
> to jump.
>
Acked-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> ---
> drivers/staging/android/ion/ion.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 3e41644..70a70f5 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -601,12 +601,9 @@ static int ion_device_create(void)
> }
>
> idev->debug_root = debugfs_create_dir("ion", NULL);
> - if (!idev->debug_root) {
> + if (!idev->debug_root)
> pr_err("ion: failed to create debugfs root directory.\n");
> - goto debugfs_done;
> - }
>
> -debugfs_done:
> idev->buffers = RB_ROOT;
> mutex_init(&idev->buffer_lock);
> init_rwsem(&idev->lock);
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-02-06 23:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 12:34 [PATCH 1/2] staging: android: ion: Avoid NULL point in error path Yisheng Xie
2018-02-01 12:34 ` [PATCH 2/2] staging: android: ion: Remove lable debugfs_done Yisheng Xie
2018-02-06 23:00 ` Laura Abbott [this message]
2018-02-06 22:59 ` [PATCH 1/2] staging: android: ion: Avoid NULL point in error path Laura Abbott
2018-02-12 11:40 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fa110ed-afab-b707-a2e9-7a1a94ccf92f@redhat.com \
--to=labbott@redhat.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.