All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@dell.com>
To: dvhart@infradead.org, Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	platform-driver-x86@vger.kernel.org,
	Andy Lutomirski <luto@kernel.org>,
	quasisec@google.com, pali.rohar@gmail.com, rjw@rjwysocki.net,
	mjg59@google.com, hch@lst.de, Greg KH <greg@kroah.com>,
	Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
	Mario Limonciello <mario.limonciello@dell.com>
Subject: [PATCH v12 08/16] platform/x86: dell-smbios: only run if proper oem string is detected
Date: Wed,  1 Nov 2017 14:25:29 -0500	[thread overview]
Message-ID: <6fa8c8ea9e3a7d67f9fc8c27322019e8489f6a32.1509561822.git.mario.limonciello@dell.com> (raw)
In-Reply-To: <cover.1509561822.git.mario.limonciello@dell.com>
In-Reply-To: <cover.1509561822.git.mario.limonciello@dell.com>

The proper way to indicate that a system is a 'supported' Dell System
is by the presence of this string in OEM strings.

Allowing the driver to load on non-Dell systems will have undefined
results.

Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Reviewed-by: Edward O'Callaghan <quasisec@google.com>
---
 drivers/platform/x86/dell-smbios.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
index ffc174638aa4..12a3eb153911 100644
--- a/drivers/platform/x86/dell-smbios.c
+++ b/drivers/platform/x86/dell-smbios.c
@@ -172,8 +172,15 @@ static void __init find_tokens(const struct dmi_header *dm, void *dummy)
 
 static int __init dell_smbios_init(void)
 {
+	const struct dmi_device *valid;
 	int ret;
 
+	valid = dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL);
+	if (!valid) {
+		pr_err("Unable to run on non-Dell system\n");
+		return -ENODEV;
+	}
+
 	dmi_walk(find_tokens, NULL);
 
 	if (!da_tokens)  {
-- 
2.14.1

  parent reply	other threads:[~2017-11-01 19:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01 19:25 [PATCH v12 00/16] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 01/16] platform/x86: dell-smbios: Prefix class/select with cmd_ Mario Limonciello
2017-11-02  0:30   ` Edward O'Callaghan
2017-11-01 19:25 ` [PATCH v12 02/16] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 03/16] platform/x86: dell-wmi: increase severity of some failures Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 04/16] platform/x86: dell-wmi: clean up wmi descriptor check Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 05/16] platform/x86: dell-wmi: don't check length returned Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 06/16] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 07/16] platform/x86: wmi: Don't allow drivers to get each other's GUIDs Mario Limonciello
2017-11-01 19:25 ` Mario Limonciello [this message]
2017-11-01 19:25 ` [PATCH v12 09/16] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 10/16] platform/x86: dell-smbios: Introduce dispatcher for SMM calls Mario Limonciello
2018-01-27 14:48   ` Pali Rohár
2017-11-01 19:25 ` [PATCH v12 11/16] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 12/16] platform/x86: dell-smbios-smm: test for WSMT Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 13/16] platform/x86: dell-smbios: Add filtering support Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 14/16] platform/x86: wmi: create userspace interface for drivers Mario Limonciello
2017-11-02  0:31   ` Edward O'Callaghan
2017-11-01 19:25 ` [PATCH v12 15/16] platform/x86: dell-smbios-wmi: introduce userspace interface Mario Limonciello
2017-11-01 19:25 ` [PATCH v12 16/16] tools/wmi: add a sample for dell smbios communication over WMI Mario Limonciello
2017-11-03  0:50 ` [PATCH v12 00/16] Introduce support for Dell SMBIOS " Darren Hart
2017-11-03 16:30   ` Mario.Limonciello
2017-11-03 16:30     ` Mario.Limonciello
2017-11-03 21:00     ` Darren Hart
2017-11-03 21:02       ` Mario.Limonciello
2017-11-03 21:02         ` Mario.Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fa8c8ea9e3a7d67f9fc8c27322019e8489f6a32.1509561822.git.mario.limonciello@dell.com \
    --to=mario.limonciello@dell.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mjg59@google.com \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=quasisec@google.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.