From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 700BAC433F5 for ; Tue, 15 Feb 2022 15:56:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240931AbiBOP4O (ORCPT ); Tue, 15 Feb 2022 10:56:14 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235409AbiBOP4M (ORCPT ); Tue, 15 Feb 2022 10:56:12 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 573A19E57A for ; Tue, 15 Feb 2022 07:56:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644940561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i3mIIOmXcj6/r/dAaawDN7xnH7QVCOcxOFFmz07jm+Q=; b=OT1q3wKoPv90JN00KVgyBTxXXS1dFQFZi7OIwA1PemgCjmqaPjoFKwFLt/hp+nzVGJqBW6 gvHIdTnElfy+eQkpzaRAgIRg0ZrOkNaYDNa9dcSI8VGPP1sQWwKjaXHfw0c0zGrsddbdXI pe/mjNkUwHhDbO1ogaelP6UYiK7YtOM= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-619-lDyREnfeN_GpajxffMtZnA-1; Tue, 15 Feb 2022 10:56:00 -0500 X-MC-Unique: lDyREnfeN_GpajxffMtZnA-1 Received: by mail-oi1-f197.google.com with SMTP id bx17-20020a0568081b1100b002d2e2df9e60so4822209oib.22 for ; Tue, 15 Feb 2022 07:56:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=i3mIIOmXcj6/r/dAaawDN7xnH7QVCOcxOFFmz07jm+Q=; b=n7C/C5VbvQyjyqqdlP/QLsM/OFTjQqvRTdDUCVqswXz01X5Wf135svuwWPPqsGr/9D yV5gZA6JddMJSK4NuQw5V+hUDOG3BFJPg7rx8TPt9SWqjCcxW5E0Sx5c91n9tZrsuQ1w ljukxwG9pd2SFrvfSnzZkL9urYMWR3zR0T3nLW+18u+l7EiSvltabXNwdDlXRk8kSLp6 MYPyNycnY66+cwEQ3Y5mMdMxHFELfenNKC5MrQ2fOg75WByQ0r36v5zqnhzXfL5l8p41 BJSueoEj+9M+m55TxCVuqtFEQt/ZEX/fePtNcbaTPh/wGLlpZiptwqdO3//U9E1XVZ31 vJ8Q== X-Gm-Message-State: AOAM533KO0/hk47osuuGP59GesL1fmgtlMIBbz6tBJ/XnjwMA54QWKZT 7V/vsJzIljbgU7mrBrMtPbDS0iLdZtlMfAR8ejgt9EcfMzoNQ19ipilyzb3IwFxtvciSt0cmU0X RjjjRNcoxCX26SoQwixoMYSxr X-Received: by 2002:a05:6808:1205:b0:2ce:6ee7:2ce3 with SMTP id a5-20020a056808120500b002ce6ee72ce3mr1776993oil.273.1644940559468; Tue, 15 Feb 2022 07:55:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzT0N7UWtM9bq6RTOfVUzIg8R4uTIT/1lOf1KSFNx+RJEg3jRIhK+L4cRvOG7rSTMshuEG3UQ== X-Received: by 2002:a05:6808:1205:b0:2ce:6ee7:2ce3 with SMTP id a5-20020a056808120500b002ce6ee72ce3mr1776983oil.273.1644940559280; Tue, 15 Feb 2022 07:55:59 -0800 (PST) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id e11sm637030oiw.3.2022.02.15.07.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 07:55:58 -0800 (PST) Subject: Re: [PATCH v1 5/7] drivers: fpga: dfl: handle empty port list To: Tianfei zhang , hao.wu@intel.com, mdf@kernel.org, yilun.xu@intel.com, linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: corbet@lwn.net, Matthew Gerlach References: <20220214112619.219761-1-tianfei.zhang@intel.com> <20220214112619.219761-6-tianfei.zhang@intel.com> From: Tom Rix Message-ID: <6fae1b06-f275-fc11-8a3f-92fd7c666396@redhat.com> Date: Tue, 15 Feb 2022 07:55:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220214112619.219761-6-tianfei.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/22 3:26 AM, Tianfei zhang wrote: > From: Matthew Gerlach > > Not all FPGA designs managed by the DFL driver have a port. > In these cases, don't write the Port Access Control register > when enabling SRIOV. Drop the 'drivers:' in the subject line. This patch likely needs to moved to 4/7 since the last patch also iterated over the list. Tom > > Signed-off-by: Matthew Gerlach > Signed-off-by: Tianfei Zhang > --- > drivers/fpga/dfl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c > index cfc539a656f0..a5263ac258c5 100644 > --- a/drivers/fpga/dfl.c > +++ b/drivers/fpga/dfl.c > @@ -1708,6 +1708,8 @@ int dfl_fpga_cdev_config_ports_vf(struct dfl_fpga_cdev *cdev, int num_vfs) > int ret = 0, port_count = 0; > > mutex_lock(&cdev->lock); > + if (list_empty(&cdev->port_dev_list)) > + goto done; > > list_for_each_entry(pdata, &cdev->port_dev_list, node) { > if (pdata->dev)