From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5C0D321243BA5 for ; Thu, 2 May 2019 14:18:57 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id e6so1636227pgc.4 for ; Thu, 02 May 2019 14:18:57 -0700 (PDT) Subject: Re: [PATCH v2 04/17] kunit: test: add kunit_stream a std::stream like logger References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-5-brendanhiggins@google.com> <20190502110008.GC12416@kroah.com> From: Frank Rowand Message-ID: <6fcf1218-a026-fd7b-236f-ea95f6312e1d@gmail.com> Date: Thu, 2 May 2019 14:18:53 -0700 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins , Greg KH Cc: Petr Mladek , linux-doc@vger.kernel.org, Amir Goldstein , dri-devel , Sasha Levin , Michael Ellerman , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , linux-nvdimm , Kevin Hilman , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild@vger.kernel.org, "Bird, Timothy , linux-um@lists.infradead.org, Steven Rostedt" , Julia Lawall , kunit-dev@googlegroups.com, Richard Weinberger , Stephen Boyd , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org List-ID: On 5/2/19 1:25 PM, Brendan Higgins wrote: > On Thu, May 2, 2019 at 4:00 AM Greg KH wrote: >> >> On Wed, May 01, 2019 at 04:01:13PM -0700, Brendan Higgins wrote: >>> A lot of the expectation and assertion infrastructure prints out fairly >>> complicated test failure messages, so add a C++ style log library for >>> for logging test results. >> >> Ideally we would always use a standard logging format, like the >> kselftest tests all are aiming to do. That way the output can be easily >> parsed by tools to see if the tests succeed/fail easily. >> >> Any chance of having this logging framework enforcing that format as >> well? > > I agree with your comment on the later patch that we should handle > this at the wrapper script layer (KUnit tool). This discussion is a little confusing, because it is spread across two patches. I do not agree that this should be handled in the wrapper script, as noted in my reply to patch 12, so not repeating it here. -Frank _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62652C43219 for ; Thu, 2 May 2019 21:19:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 289E120651 for ; Thu, 2 May 2019 21:19:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F6aEAFFT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726138AbfEBVS6 (ORCPT ); Thu, 2 May 2019 17:18:58 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:44989 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbfEBVS5 (ORCPT ); Thu, 2 May 2019 17:18:57 -0400 Received: by mail-pf1-f195.google.com with SMTP id y13so1738499pfm.11; Thu, 02 May 2019 14:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IMDXeiJnZScTm/Z2fnilFyDCMvT/so814pMi9HZOjlE=; b=F6aEAFFTMEY1A2qy1v4j/PN2GP6GkE/6G2UBiv6QtH3csxGy/tWQz9UyALBQT0H1TD MeqU6hM9umqY0cg0Apce+C6xD7p/xobhUeh9MvWiRshhDTYwjMCFPRJXDlmB1nI2J9BP OzIBfpWyS6JYvMDV31/EOZgJHoSWDTYYtNA+I4V1u8ppBrJn22kX8LSoN6iqCo9WhEY7 d+Gb6Xl5Xs5otxILTZsg9XkKBj+kf5e2zhHYN3mehnTBbPBGx+Rmo9Huu3e7g+KZRBMy FLtK+ZKMR1Bm1xie5Eekig7pGAK9pe7NuFPMeA4bw49W6KmIoFN+i8IYZC8Mr/CFaKXa I9Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IMDXeiJnZScTm/Z2fnilFyDCMvT/so814pMi9HZOjlE=; b=hDDN271P8NcMcvALdq2P5oOss1i/8EkzQNfhiYOq9TDxmhwIbkUswQ9nggKntqUBbZ uHejWkd4ExzGsZg5FKf5x85Iw/MtoCQLinOqq51GQNYKZ5sJMnvYDc67vx/5KJXmfWBw IeteT6r0VdqaiVo67CpfPrnuVzfo67JBGnwyW9PSPaZnTmWGFMDRmMmePjRXb5bPSW2v HFWW9t08ynkAryy34hvkMSH8+wXHe+iPSbEJ3E0O3kwuoZHSVdB7J1DdyUkeq5Rb7uc8 IwWyTKrHno2KlydOK39cbpKSpOR3YFKhXyT/aL1qWj7t5LfZlk0SWIdW06pWdg3I8t2m Ep+w== X-Gm-Message-State: APjAAAWzlhg9+Fslm+jgPdxOwzs5uJB73aLecIUreuApi2JPPLA2yOkB gnKVcsaAeAMKGopqX15eNh8= X-Google-Smtp-Source: APXvYqyX3j/ct3IijwmpxxuiCJMGeDGeHP5eVJgN3Sl6Ovmj2WM37sI+ZAhRzZjNxXrFUHk4WRTuBA== X-Received: by 2002:a65:5089:: with SMTP id r9mr6248599pgp.14.1556831937028; Thu, 02 May 2019 14:18:57 -0700 (PDT) Received: from [192.168.1.70] (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id l1sm232976pgp.9.2019.05.02.14.18.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2019 14:18:56 -0700 (PDT) Subject: Re: [PATCH v2 04/17] kunit: test: add kunit_stream a std::stream like logger To: Brendan Higgins , Greg KH Cc: Kees Cook , Kieran Bingham , Luis Chamberlain , Rob Herring , Stephen Boyd , shuah@kernel.org, devicetree , dri-devel , kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, Linux Kernel Mailing List , linux-kselftest@vger.kernel.org, linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Dan Williams , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-5-brendanhiggins@google.com> <20190502110008.GC12416@kroah.com> From: Frank Rowand Message-ID: <6fcf1218-a026-fd7b-236f-ea95f6312e1d@gmail.com> Date: Thu, 2 May 2019 14:18:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/2/19 1:25 PM, Brendan Higgins wrote: > On Thu, May 2, 2019 at 4:00 AM Greg KH wrote: >> >> On Wed, May 01, 2019 at 04:01:13PM -0700, Brendan Higgins wrote: >>> A lot of the expectation and assertion infrastructure prints out fairly >>> complicated test failure messages, so add a C++ style log library for >>> for logging test results. >> >> Ideally we would always use a standard logging format, like the >> kselftest tests all are aiming to do. That way the output can be easily >> parsed by tools to see if the tests succeed/fail easily. >> >> Any chance of having this logging framework enforcing that format as >> well? > > I agree with your comment on the later patch that we should handle > this at the wrapper script layer (KUnit tool). This discussion is a little confusing, because it is spread across two patches. I do not agree that this should be handled in the wrapper script, as noted in my reply to patch 12, so not repeating it here. -Frank From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH v2 04/17] kunit: test: add kunit_stream a std::stream like logger Date: Thu, 2 May 2019 14:18:53 -0700 Message-ID: <6fcf1218-a026-fd7b-236f-ea95f6312e1d@gmail.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-5-brendanhiggins@google.com> <20190502110008.GC12416@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Brendan Higgins , Greg KH Cc: Kees Cook , Kieran Bingham , Luis Chamberlain , Rob Herring , Stephen Boyd , shuah@kernel.org, devicetree , dri-devel , kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, Linux Kernel Mailing List , linux-kselftest@vger.kernel.org, linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Dan Williams List-Id: devicetree@vger.kernel.org On 5/2/19 1:25 PM, Brendan Higgins wrote: > On Thu, May 2, 2019 at 4:00 AM Greg KH wrote: >> >> On Wed, May 01, 2019 at 04:01:13PM -0700, Brendan Higgins wrote: >>> A lot of the expectation and assertion infrastructure prints out fairly >>> complicated test failure messages, so add a C++ style log library for >>> for logging test results. >> >> Ideally we would always use a standard logging format, like the >> kselftest tests all are aiming to do. That way the output can be easily >> parsed by tools to see if the tests succeed/fail easily. >> >> Any chance of having this logging framework enforcing that format as >> well? > > I agree with your comment on the later patch that we should handle > this at the wrapper script layer (KUnit tool). This discussion is a little confusing, because it is spread across two patches. I do not agree that this should be handled in the wrapper script, as noted in my reply to patch 12, so not repeating it here. -Frank From mboxrd@z Thu Jan 1 00:00:00 1970 From: frowand.list at gmail.com (Frank Rowand) Date: Thu, 2 May 2019 14:18:53 -0700 Subject: [PATCH v2 04/17] kunit: test: add kunit_stream a std::stream like logger In-Reply-To: References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-5-brendanhiggins@google.com> <20190502110008.GC12416@kroah.com> Message-ID: <6fcf1218-a026-fd7b-236f-ea95f6312e1d@gmail.com> On 5/2/19 1:25 PM, Brendan Higgins wrote: > On Thu, May 2, 2019 at 4:00 AM Greg KH wrote: >> >> On Wed, May 01, 2019 at 04:01:13PM -0700, Brendan Higgins wrote: >>> A lot of the expectation and assertion infrastructure prints out fairly >>> complicated test failure messages, so add a C++ style log library for >>> for logging test results. >> >> Ideally we would always use a standard logging format, like the >> kselftest tests all are aiming to do. That way the output can be easily >> parsed by tools to see if the tests succeed/fail easily. >> >> Any chance of having this logging framework enforcing that format as >> well? > > I agree with your comment on the later patch that we should handle > this at the wrapper script layer (KUnit tool). This discussion is a little confusing, because it is spread across two patches. I do not agree that this should be handled in the wrapper script, as noted in my reply to patch 12, so not repeating it here. -Frank From mboxrd@z Thu Jan 1 00:00:00 1970 From: frowand.list@gmail.com (Frank Rowand) Date: Thu, 2 May 2019 14:18:53 -0700 Subject: [PATCH v2 04/17] kunit: test: add kunit_stream a std::stream like logger In-Reply-To: References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-5-brendanhiggins@google.com> <20190502110008.GC12416@kroah.com> Message-ID: <6fcf1218-a026-fd7b-236f-ea95f6312e1d@gmail.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190502211853.1PW7s8TyFACWBAx-un3clF8UEuYUEzqpuSYNe23rzfY@z> On 5/2/19 1:25 PM, Brendan Higgins wrote: > On Thu, May 2, 2019@4:00 AM Greg KH wrote: >> >> On Wed, May 01, 2019@04:01:13PM -0700, Brendan Higgins wrote: >>> A lot of the expectation and assertion infrastructure prints out fairly >>> complicated test failure messages, so add a C++ style log library for >>> for logging test results. >> >> Ideally we would always use a standard logging format, like the >> kselftest tests all are aiming to do. That way the output can be easily >> parsed by tools to see if the tests succeed/fail easily. >> >> Any chance of having this logging framework enforcing that format as >> well? > > I agree with your comment on the later patch that we should handle > this at the wrapper script layer (KUnit tool). This discussion is a little confusing, because it is spread across two patches. I do not agree that this should be handled in the wrapper script, as noted in my reply to patch 12, so not repeating it here. -Frank From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMJ6X-00084E-Gm for linux-um@lists.infradead.org; Thu, 02 May 2019 21:18:58 +0000 Received: by mail-pg1-x543.google.com with SMTP id h1so1640281pgs.2 for ; Thu, 02 May 2019 14:18:57 -0700 (PDT) Subject: Re: [PATCH v2 04/17] kunit: test: add kunit_stream a std::stream like logger References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-5-brendanhiggins@google.com> <20190502110008.GC12416@kroah.com> From: Frank Rowand Message-ID: <6fcf1218-a026-fd7b-236f-ea95f6312e1d@gmail.com> Date: Thu, 2 May 2019 14:18:53 -0700 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins , Greg KH Cc: Petr Mladek , linux-doc@vger.kernel.org, Amir Goldstein , dri-devel , Sasha Levin , Michael Ellerman , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , linux-nvdimm , Kevin Hilman , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild@vger.kernel.org, "Bird, Timothy , linux-um@lists.infradead.org, Steven Rostedt" , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Richard Weinberger , Stephen Boyd , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org, Logan Gunthorpe On 5/2/19 1:25 PM, Brendan Higgins wrote: > On Thu, May 2, 2019 at 4:00 AM Greg KH wrote: >> >> On Wed, May 01, 2019 at 04:01:13PM -0700, Brendan Higgins wrote: >>> A lot of the expectation and assertion infrastructure prints out fairly >>> complicated test failure messages, so add a C++ style log library for >>> for logging test results. >> >> Ideally we would always use a standard logging format, like the >> kselftest tests all are aiming to do. That way the output can be easily >> parsed by tools to see if the tests succeed/fail easily. >> >> Any chance of having this logging framework enforcing that format as >> well? > > I agree with your comment on the later patch that we should handle > this at the wrapper script layer (KUnit tool). This discussion is a little confusing, because it is spread across two patches. I do not agree that this should be handled in the wrapper script, as noted in my reply to patch 12, so not repeating it here. -Frank _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um