From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B27C28E83 for ; Fri, 4 Sep 2020 07:00:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8A332067C for ; Fri, 4 Sep 2020 07:00:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbgIDHAg (ORCPT ); Fri, 4 Sep 2020 03:00:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:35444 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbgIDHAU (ORCPT ); Fri, 4 Sep 2020 03:00:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 10272AD5F; Fri, 4 Sep 2020 07:00:20 +0000 (UTC) Subject: Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: linux-kernel@vger.kernel.org, Oleksandr Andrushchenko , David Airlie , Daniel Vetter , Boris Ostrovsky , Stefano Stabellini , Dan Carpenter , Wei Liu , Yan Yankovskyi , dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, David Hildenbrand , Michal Hocko , Dan Williams References: <20200901083326.21264-1-roger.pau@citrix.com> <20200901083326.21264-4-roger.pau@citrix.com> <20200903163837.GM753@Air-de-Roger> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <6fd73d30-5525-7f00-1e9c-d7bb96ea34a6@suse.com> Date: Fri, 4 Sep 2020 09:00:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200903163837.GM753@Air-de-Roger> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.09.20 18:38, Roger Pau Monné wrote: > On Thu, Sep 03, 2020 at 05:30:07PM +0200, Jürgen Groß wrote: >> On 01.09.20 10:33, Roger Pau Monne wrote: >>> To be used in order to create foreign mappings. This is based on the >>> ZONE_DEVICE facility which is used by persistent memory devices in >>> order to create struct pages and kernel virtual mappings for the IOMEM >>> areas of such devices. Note that on kernels without support for >>> ZONE_DEVICE Xen will fallback to use ballooned pages in order to >>> create foreign mappings. >>> >>> The newly added helpers use the same parameters as the existing >>> {alloc/free}_xenballooned_pages functions, which allows for in-place >>> replacement of the callers. Once a memory region has been added to be >>> used as scratch mapping space it will no longer be released, and pages >>> returned are kept in a linked list. This allows to have a buffer of >>> pages and prevents resorting to frequent additions and removals of >>> regions. >>> >>> If enabled (because ZONE_DEVICE is supported) the usage of the new >>> functionality untangles Xen balloon and RAM hotplug from the usage of >>> unpopulated physical memory ranges to map foreign pages, which is the >>> correct thing to do in order to avoid mappings of foreign pages depend >>> on memory hotplug. >>> >>> Note the driver is currently not enabled on Arm platforms because it >>> would interfere with the identity mapping required on some platforms. >>> >>> Signed-off-by: Roger Pau Monné >> >> Sorry, I just got a build error for x86 32-bit build: >> >> WARNING: unmet direct dependencies detected for ZONE_DEVICE >> Depends on [n]: MEMORY_HOTPLUG [=n] && MEMORY_HOTREMOVE [=n] && >> SPARSEMEM_VMEMMAP [=n] && ARCH_HAS_PTE_DEVMAP [=n] >> Selected by [y]: >> - XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86 [=y] >> GEN Makefile >> CC kernel/bounds.s >> CALL /home/gross/korg/src/scripts/atomic/check-atomics.sh >> UPD include/generated/bounds.h >> CC arch/x86/kernel/asm-offsets.s >> In file included from /home/gross/korg/src/include/linux/mmzone.h:19:0, >> from /home/gross/korg/src/include/linux/gfp.h:6, >> from /home/gross/korg/src/include/linux/slab.h:15, >> from /home/gross/korg/src/include/linux/crypto.h:19, >> from /home/gross/korg/src/arch/x86/kernel/asm-offsets.c:9: >> /home/gross/korg/src/include/linux/page-flags-layout.h:95:2: error: #error >> "Not enough bits in page flags" >> #error "Not enough bits in page flags" >> ^~~~~ >> make[2]: *** [/home/gross/korg/src/scripts/Makefile.build:114: >> arch/x86/kernel/asm-offsets.s] Error 1 >> make[1]: *** [/home/gross/korg/src/Makefile:1175: prepare0] Error 2 >> make[1]: Leaving directory '/home/gross/korg/x8632' >> make: *** [Makefile:185: __sub-make] Error 2 > > Sorry for this. I've tested a 32bit build but I think it was before > the last Kconfig changes. I'm a little unsure how to solve this, as > ZONE_DEVICE doesn't select the required options for it to run, but > rather depends on them to be available. > > You can trigger something similar on x86-64 by doing: > > $ make ARCH=x86_64 xen.config > Using .config as base > Merging ./kernel/configs/xen.config > Merging ./arch/x86/configs/xen.config > # > # merged configuration written to .config (needs make) > # > scripts/kconfig/conf --olddefconfig Kconfig > > WARNING: unmet direct dependencies detected for ZONE_DEVICE > Depends on [n]: MEMORY_HOTPLUG [=y] && MEMORY_HOTREMOVE [=n] && SPARSEMEM_VMEMMAP [=y] && ARCH_HAS_PTE_DEVMAP [=y] > Selected by [y]: > - XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86_64 [=y] > # > # configuration written to .config > # > > I think the only solution is to have XEN_UNPOPULATED_ALLOC depend on > ZONE_DEVICE rather than select it? Yes, I think so. I've folded that in and now build is fine. Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE44C43461 for ; Fri, 4 Sep 2020 07:00:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF5CC20722 for ; Fri, 4 Sep 2020 07:00:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF5CC20722 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 202F66E8EC; Fri, 4 Sep 2020 07:00:22 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9420A6E8EC for ; Fri, 4 Sep 2020 07:00:20 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 10272AD5F; Fri, 4 Sep 2020 07:00:20 +0000 (UTC) Subject: Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20200901083326.21264-1-roger.pau@citrix.com> <20200901083326.21264-4-roger.pau@citrix.com> <20200903163837.GM753@Air-de-Roger> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <6fd73d30-5525-7f00-1e9c-d7bb96ea34a6@suse.com> Date: Fri, 4 Sep 2020 09:00:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200903163837.GM753@Air-de-Roger> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Oleksandr Andrushchenko , David Airlie , Yan Yankovskyi , David Hildenbrand , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Hocko , linux-mm@kvack.org, xen-devel@lists.xenproject.org, Boris Ostrovsky , Dan Williams , Dan Carpenter Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMDMuMDkuMjAgMTg6MzgsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6Cj4gT24gVGh1LCBTZXAg MDMsIDIwMjAgYXQgMDU6MzA6MDdQTSArMDIwMCwgSsO8cmdlbiBHcm/DnyB3cm90ZToKPj4gT24g MDEuMDkuMjAgMTA6MzMsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPj4+IFRvIGJlIHVzZWQgaW4g b3JkZXIgdG8gY3JlYXRlIGZvcmVpZ24gbWFwcGluZ3MuIFRoaXMgaXMgYmFzZWQgb24gdGhlCj4+ PiBaT05FX0RFVklDRSBmYWNpbGl0eSB3aGljaCBpcyB1c2VkIGJ5IHBlcnNpc3RlbnQgbWVtb3J5 IGRldmljZXMgaW4KPj4+IG9yZGVyIHRvIGNyZWF0ZSBzdHJ1Y3QgcGFnZXMgYW5kIGtlcm5lbCB2 aXJ0dWFsIG1hcHBpbmdzIGZvciB0aGUgSU9NRU0KPj4+IGFyZWFzIG9mIHN1Y2ggZGV2aWNlcy4g Tm90ZSB0aGF0IG9uIGtlcm5lbHMgd2l0aG91dCBzdXBwb3J0IGZvcgo+Pj4gWk9ORV9ERVZJQ0Ug WGVuIHdpbGwgZmFsbGJhY2sgdG8gdXNlIGJhbGxvb25lZCBwYWdlcyBpbiBvcmRlciB0bwo+Pj4g Y3JlYXRlIGZvcmVpZ24gbWFwcGluZ3MuCj4+Pgo+Pj4gVGhlIG5ld2x5IGFkZGVkIGhlbHBlcnMg dXNlIHRoZSBzYW1lIHBhcmFtZXRlcnMgYXMgdGhlIGV4aXN0aW5nCj4+PiB7YWxsb2MvZnJlZX1f eGVuYmFsbG9vbmVkX3BhZ2VzIGZ1bmN0aW9ucywgd2hpY2ggYWxsb3dzIGZvciBpbi1wbGFjZQo+ Pj4gcmVwbGFjZW1lbnQgb2YgdGhlIGNhbGxlcnMuIE9uY2UgYSBtZW1vcnkgcmVnaW9uIGhhcyBi ZWVuIGFkZGVkIHRvIGJlCj4+PiB1c2VkIGFzIHNjcmF0Y2ggbWFwcGluZyBzcGFjZSBpdCB3aWxs IG5vIGxvbmdlciBiZSByZWxlYXNlZCwgYW5kIHBhZ2VzCj4+PiByZXR1cm5lZCBhcmUga2VwdCBp biBhIGxpbmtlZCBsaXN0LiBUaGlzIGFsbG93cyB0byBoYXZlIGEgYnVmZmVyIG9mCj4+PiBwYWdl cyBhbmQgcHJldmVudHMgcmVzb3J0aW5nIHRvIGZyZXF1ZW50IGFkZGl0aW9ucyBhbmQgcmVtb3Zh bHMgb2YKPj4+IHJlZ2lvbnMuCj4+Pgo+Pj4gSWYgZW5hYmxlZCAoYmVjYXVzZSBaT05FX0RFVklD RSBpcyBzdXBwb3J0ZWQpIHRoZSB1c2FnZSBvZiB0aGUgbmV3Cj4+PiBmdW5jdGlvbmFsaXR5IHVu dGFuZ2xlcyBYZW4gYmFsbG9vbiBhbmQgUkFNIGhvdHBsdWcgZnJvbSB0aGUgdXNhZ2Ugb2YKPj4+ IHVucG9wdWxhdGVkIHBoeXNpY2FsIG1lbW9yeSByYW5nZXMgdG8gbWFwIGZvcmVpZ24gcGFnZXMs IHdoaWNoIGlzIHRoZQo+Pj4gY29ycmVjdCB0aGluZyB0byBkbyBpbiBvcmRlciB0byBhdm9pZCBt YXBwaW5ncyBvZiBmb3JlaWduIHBhZ2VzIGRlcGVuZAo+Pj4gb24gbWVtb3J5IGhvdHBsdWcuCj4+ Pgo+Pj4gTm90ZSB0aGUgZHJpdmVyIGlzIGN1cnJlbnRseSBub3QgZW5hYmxlZCBvbiBBcm0gcGxh dGZvcm1zIGJlY2F1c2UgaXQKPj4+IHdvdWxkIGludGVyZmVyZSB3aXRoIHRoZSBpZGVudGl0eSBt YXBwaW5nIHJlcXVpcmVkIG9uIHNvbWUgcGxhdGZvcm1zLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6 IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgo+Pgo+PiBTb3JyeSwgSSBq dXN0IGdvdCBhIGJ1aWxkIGVycm9yIGZvciB4ODYgMzItYml0IGJ1aWxkOgo+Pgo+PiBXQVJOSU5H OiB1bm1ldCBkaXJlY3QgZGVwZW5kZW5jaWVzIGRldGVjdGVkIGZvciBaT05FX0RFVklDRQo+PiAg ICBEZXBlbmRzIG9uIFtuXTogTUVNT1JZX0hPVFBMVUcgWz1uXSAmJiBNRU1PUllfSE9UUkVNT1ZF IFs9bl0gJiYKPj4gU1BBUlNFTUVNX1ZNRU1NQVAgWz1uXSAmJiBBUkNIX0hBU19QVEVfREVWTUFQ IFs9bl0KPj4gICAgU2VsZWN0ZWQgYnkgW3ldOgo+PiAgICAtIFhFTl9VTlBPUFVMQVRFRF9BTExP QyBbPXldICYmIFhFTiBbPXldICYmIFg4NiBbPXldCj4+ICAgIEdFTiAgICAgTWFrZWZpbGUKPj4g ICAgQ0MgICAgICBrZXJuZWwvYm91bmRzLnMKPj4gICAgQ0FMTCAgICAvaG9tZS9ncm9zcy9rb3Jn L3NyYy9zY3JpcHRzL2F0b21pYy9jaGVjay1hdG9taWNzLnNoCj4+ICAgIFVQRCAgICAgaW5jbHVk ZS9nZW5lcmF0ZWQvYm91bmRzLmgKPj4gICAgQ0MgICAgICBhcmNoL3g4Ni9rZXJuZWwvYXNtLW9m ZnNldHMucwo+PiBJbiBmaWxlIGluY2x1ZGVkIGZyb20gL2hvbWUvZ3Jvc3Mva29yZy9zcmMvaW5j bHVkZS9saW51eC9tbXpvbmUuaDoxOTowLAo+PiAgICAgICAgICAgICAgICAgICBmcm9tIC9ob21l L2dyb3NzL2tvcmcvc3JjL2luY2x1ZGUvbGludXgvZ2ZwLmg6NiwKPj4gICAgICAgICAgICAgICAg ICAgZnJvbSAvaG9tZS9ncm9zcy9rb3JnL3NyYy9pbmNsdWRlL2xpbnV4L3NsYWIuaDoxNSwKPj4g ICAgICAgICAgICAgICAgICAgZnJvbSAvaG9tZS9ncm9zcy9rb3JnL3NyYy9pbmNsdWRlL2xpbnV4 L2NyeXB0by5oOjE5LAo+PiAgICAgICAgICAgICAgICAgICBmcm9tIC9ob21lL2dyb3NzL2tvcmcv c3JjL2FyY2gveDg2L2tlcm5lbC9hc20tb2Zmc2V0cy5jOjk6Cj4+IC9ob21lL2dyb3NzL2tvcmcv c3JjL2luY2x1ZGUvbGludXgvcGFnZS1mbGFncy1sYXlvdXQuaDo5NToyOiBlcnJvcjogI2Vycm9y Cj4+ICJOb3QgZW5vdWdoIGJpdHMgaW4gcGFnZSBmbGFncyIKPj4gICAjZXJyb3IgIk5vdCBlbm91 Z2ggYml0cyBpbiBwYWdlIGZsYWdzIgo+PiAgICBefn5+fgo+PiBtYWtlWzJdOiAqKiogWy9ob21l L2dyb3NzL2tvcmcvc3JjL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6MTE0Ogo+PiBhcmNoL3g4Ni9r ZXJuZWwvYXNtLW9mZnNldHMuc10gRXJyb3IgMQo+PiBtYWtlWzFdOiAqKiogWy9ob21lL2dyb3Nz L2tvcmcvc3JjL01ha2VmaWxlOjExNzU6IHByZXBhcmUwXSBFcnJvciAyCj4+IG1ha2VbMV06IExl YXZpbmcgZGlyZWN0b3J5ICcvaG9tZS9ncm9zcy9rb3JnL3g4NjMyJwo+PiBtYWtlOiAqKiogW01h a2VmaWxlOjE4NTogX19zdWItbWFrZV0gRXJyb3IgMgo+IAo+IFNvcnJ5IGZvciB0aGlzLiBJJ3Zl IHRlc3RlZCBhIDMyYml0IGJ1aWxkIGJ1dCBJIHRoaW5rIGl0IHdhcyBiZWZvcmUKPiB0aGUgbGFz dCBLY29uZmlnIGNoYW5nZXMuIEknbSBhIGxpdHRsZSB1bnN1cmUgaG93IHRvIHNvbHZlIHRoaXMs IGFzCj4gWk9ORV9ERVZJQ0UgZG9lc24ndCBzZWxlY3QgdGhlIHJlcXVpcmVkIG9wdGlvbnMgZm9y IGl0IHRvIHJ1biwgYnV0Cj4gcmF0aGVyIGRlcGVuZHMgb24gdGhlbSB0byBiZSBhdmFpbGFibGUu Cj4gCj4gWW91IGNhbiB0cmlnZ2VyIHNvbWV0aGluZyBzaW1pbGFyIG9uIHg4Ni02NCBieSBkb2lu ZzoKPiAKPiAkIG1ha2UgQVJDSD14ODZfNjQgeGVuLmNvbmZpZwo+IFVzaW5nIC5jb25maWcgYXMg YmFzZQo+IE1lcmdpbmcgLi9rZXJuZWwvY29uZmlncy94ZW4uY29uZmlnCj4gTWVyZ2luZyAuL2Fy Y2gveDg2L2NvbmZpZ3MveGVuLmNvbmZpZwo+ICMKPiAjIG1lcmdlZCBjb25maWd1cmF0aW9uIHdy aXR0ZW4gdG8gLmNvbmZpZyAobmVlZHMgbWFrZSkKPiAjCj4gc2NyaXB0cy9rY29uZmlnL2NvbmYg IC0tb2xkZGVmY29uZmlnIEtjb25maWcKPiAKPiBXQVJOSU5HOiB1bm1ldCBkaXJlY3QgZGVwZW5k ZW5jaWVzIGRldGVjdGVkIGZvciBaT05FX0RFVklDRQo+ICAgIERlcGVuZHMgb24gW25dOiBNRU1P UllfSE9UUExVRyBbPXldICYmIE1FTU9SWV9IT1RSRU1PVkUgWz1uXSAmJiBTUEFSU0VNRU1fVk1F TU1BUCBbPXldICYmIEFSQ0hfSEFTX1BURV9ERVZNQVAgWz15XQo+ICAgIFNlbGVjdGVkIGJ5IFt5 XToKPiAgICAtIFhFTl9VTlBPUFVMQVRFRF9BTExPQyBbPXldICYmIFhFTiBbPXldICYmIFg4Nl82 NCBbPXldCj4gIwo+ICMgY29uZmlndXJhdGlvbiB3cml0dGVuIHRvIC5jb25maWcKPiAjCj4gCj4g SSB0aGluayB0aGUgb25seSBzb2x1dGlvbiBpcyB0byBoYXZlIFhFTl9VTlBPUFVMQVRFRF9BTExP QyBkZXBlbmQgb24KPiBaT05FX0RFVklDRSByYXRoZXIgdGhhbiBzZWxlY3QgaXQ/CgpZZXMsIEkg dGhpbmsgc28uCgpJJ3ZlIGZvbGRlZCB0aGF0IGluIGFuZCBub3cgYnVpbGQgaXMgZmluZS4KCgpK dWVyZ2VuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK