From: Eric Blake <eblake@redhat.com>
To: Zhengui li <lizhengui@huawei.com>,
pbonzini@redhat.com, stefanha@redhat.com, mreitz@redhat.com
Cc: qemu-block@nongnu.org, eric.fangyi@huawei.com,
qemu-devel@nongnu.org, zhengxiang9@huawei.com,
wangjie88@huawei.com
Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Fix crash if request is invaild or disk is no medium
Date: Thu, 7 Mar 2019 10:42:26 -0600 [thread overview]
Message-ID: <6fe0e2cf-cff9-6884-2a71-ec506f00c8da@redhat.com> (raw)
In-Reply-To: <1551949966-20092-1-git-send-email-lizhengui@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On 3/7/19 3:12 AM, Zhengui li wrote:
> From: Zhengui Li <lizhengui@huawei.com>
>
> Qemu will crash with the assertion error that "assert(r->req.aiocb !=
> NULL)" in scsi_read_complete if request is invaild or disk is no medium.
s/invaild/invalid/
> The error is below:
> qemu-kvm: hw/scsi/scsi_disk.c:299: scsi_read_complete: Assertion
> `r->req.aiocb != NULL' failed.
>
> This patch add a funtion scsi_read_complete_noio to fix it.
>
s/funtion/function/
> Signed-off-by: Zhengui Li <lizhengui@huawei.com>
> ---
> hw/scsi/scsi-disk.c | 37 ++++++++++++++++++++++++-------------
> 1 file changed, 24 insertions(+), 13 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-07 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 9:12 [Qemu-devel] [PATCH] scsi-disk: Fix crash if request is invaild or disk is no medium Zhengui li
2019-03-07 16:42 ` Eric Blake [this message]
2019-03-07 17:00 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2019-03-07 8:57 Zhengui li
2019-03-07 9:01 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fe0e2cf-cff9-6884-2a71-ec506f00c8da@redhat.com \
--to=eblake@redhat.com \
--cc=eric.fangyi@huawei.com \
--cc=lizhengui@huawei.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wangjie88@huawei.com \
--cc=zhengxiang9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.