From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90918C5ACC4 for ; Thu, 20 Feb 2020 02:11:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F70E2465D for ; Thu, 20 Feb 2020 02:11:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbgBTCLY (ORCPT ); Wed, 19 Feb 2020 21:11:24 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:33716 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727280AbgBTCLX (ORCPT ); Wed, 19 Feb 2020 21:11:23 -0500 X-IronPort-AV: E=Sophos;i="5.70,462,1574092800"; d="scan'208";a="83593124" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 20 Feb 2020 10:11:19 +0800 Received: from G08CNEXMBPEKD04.g08.fujitsu.local (unknown [10.167.33.201]) by cn.fujitsu.com (Postfix) with ESMTP id 10E8950A996A; Thu, 20 Feb 2020 10:01:40 +0800 (CST) Received: from [10.167.220.84] (10.167.220.84) by G08CNEXMBPEKD04.g08.fujitsu.local (10.167.33.201) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 20 Feb 2020 10:11:18 +0800 Subject: Re: [PATCH] xfs/029: filter out "extended-header: cycle: 1" from output To: "Darrick J. Wong" CC: References: <1581922940-14074-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> <20200219003204.GA9511@magnolia> <20200219050729.GC9504@magnolia> <20200219220935.GD9511@magnolia> From: Yang Xu Message-ID: <6fe881eb-5e0e-1e74-5399-4e8204d5b30f@cn.fujitsu.com> Date: Thu, 20 Feb 2020 10:11:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <20200219220935.GD9511@magnolia> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.220.84] X-ClientProxiedBy: G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.203) To G08CNEXMBPEKD04.g08.fujitsu.local (10.167.33.201) X-yoursite-MailScanner-ID: 10E8950A996A.AF1A4 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: xuyang2018.jy@cn.fujitsu.com Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org on 2020/02/20 6:09, Darrick J. Wong wrote: > On Wed, Feb 19, 2020 at 05:49:30PM +0800, Yang Xu wrote: >> >> on 2020/02/19 13:07, Darrick J. Wong wrote: >>> On Wed, Feb 19, 2020 at 09:27:29AM +0800, Yang Xu wrote: >>>> >>>> >>>> on 2020/02/19 8:32, Darrick J. Wong wrote: >>>>> On Mon, Feb 17, 2020 at 03:02:20PM +0800, Yang Xu wrote: >>>>>> When I test this case under GPT disklabel type, this case will fail, >>>>>> as below: >>>>>> cycle: 1 version: 2 lsn: 1,0 tail_lsn: 1,0 >>>>>> length of Log Record: 258048 prev offset: -1 num ops: 1 >>>>>> >>>>>> ... >>>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>>> extended-header: cycle: 1 >>>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>>> ... >>>>>> >>>>>> my mkfs information as below: >>>>>> meta-data=/dev/sda7 isize=512 agcount=16, agsize=327680 blks >>>>>> = sectsz=512 attr=2, projid32bit=1 >>>>>> = crc=1 finobt=1, sparse=1, rmapbt=0 >>>>>> = reflink=1 >>>>>> data = bsize=4096 blocks=5242880, imaxpct=25 >>>>>> = sunit=64 swidth=64 blks >>>>>> naming =version 2 bsize=4096 ascii-ci=0, ftype=1 >>>>>> log =internal log bsize=4096 blocks=5184, version=2 >>>>>> = sectsz=512 sunit=64 blks, lazy-count=1 >>>>>> realtime =none extsz=4096 blocks=0, rtextents=0 >>>>>> >>>>>> It reports this info because xfs_logprint only read 32k header every time, so it >>>>>> needs to read more times. We can filter this useless info. >>>>>> >>>>>> Signed-off-by: Yang Xu >>>>>> --- >>>>>> tests/xfs/029 | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/tests/xfs/029 b/tests/xfs/029 >>>>>> index f532a21b..99742792 100755 >>>>>> --- a/tests/xfs/029 >>>>>> +++ b/tests/xfs/029 >>>>>> @@ -45,7 +45,7 @@ echo >>>>>> _scratch_mkfs_xfs | _filter_mkfs 2>/dev/null >>>>>> echo >>>>>> -_scratch_xfs_logprint | _filter_logprint >>>>>> +_scratch_xfs_logprint | _filter_logprint | sed -e "/^~~~/d" -e "/extended-header/d" >>>>> >>>>> Is there a reason not to add that to _filter_logprint? >>>> I haven't mastered perl(never used). Can you add that to filter_logprint? >>> >>> That helper function does not call perl. >> Hi Darrick >> xfs/029 used itself filter_logprint(perl) not used common/log >> filter_logprint(sed) function. > > Ok, that function in xfs/029 shouldn't be prefixed with "_". also for xfs/044. I will fix that. > >> Do we should use common/log and change >> xfs/029.out? Also, common/log filter_logprint has considered "~~~" and >> "extended-header: cycle: 1" output. > > I'm not much of a perl hacker either. OK. I will think about this. Thanks Best Regards Yang Xu > > --D > >> Best Regards >> Yang Xu >>> >>> --D >>> >>>> Best Regards >>>> Yang Xu >>>>> >>>>> --D >>>>> >>>>>> status=0 >>>>>> exit >>>>>> -- >>>>>> 2.18.0 >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>> >>>> >>> >>> >> >> > >