From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v6 1/3] btrfs: declare seeding_dev in init_new_device as bool
Date: Wed, 13 Oct 2021 16:00:06 +0800 [thread overview]
Message-ID: <6fea27d3-1eb7-4725-b894-1a742d6e5c3d@oracle.com> (raw)
In-Reply-To: <d0e619aa1de4c142d5b12a41045cc60df0d1c8dc.1632179897.git.anand.jain@oracle.com>
Ping?
On 21/09/2021 12:33, Anand Jain wrote:
> This patch declares int seeding_dev as a bool. Also, move its declaration
> a line below to adjust packing.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> v6: new
> fs/btrfs/volumes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 5117c5816922..c4bc49e58b69 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -2532,8 +2532,8 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
> struct btrfs_fs_devices *fs_devices = fs_info->fs_devices;
> u64 orig_super_total_bytes;
> u64 orig_super_num_devices;
> - int seeding_dev = 0;
> int ret = 0;
> + bool seeding_dev = false;
> bool locked = false;
>
> if (sb_rdonly(sb) && !fs_devices->seeding)
> @@ -2550,7 +2550,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
> }
>
> if (fs_devices->seeding) {
> - seeding_dev = 1;
> + seeding_dev = true;
> down_write(&sb->s_umount);
> mutex_lock(&uuid_mutex);
> locked = true;
>
next prev parent reply other threads:[~2021-10-13 8:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 4:33 [PATCH v6 0/3] btrfs: cleanup prepare_sprout Anand Jain
2021-09-21 4:33 ` [PATCH v6 1/3] btrfs: declare seeding_dev in init_new_device as bool Anand Jain
2021-09-21 11:01 ` Nikolay Borisov
2021-10-13 8:00 ` Anand Jain [this message]
2021-10-28 4:39 ` Anand Jain
2021-11-08 20:06 ` David Sterba
2021-09-21 4:33 ` [PATCH v6 2/3] btrfs: remove unused device_list_mutex for seed fs_devices Anand Jain
2021-09-21 6:44 ` Nikolay Borisov
2021-09-22 11:29 ` Anand Jain
2021-09-21 4:33 ` [PATCH v6 3/3] btrfs: consolidate device_list_mutex in prepare_sprout to its parent Anand Jain
2021-09-21 11:01 ` Nikolay Borisov
2021-09-22 11:41 ` Anand Jain
2021-09-23 6:52 ` Nikolay Borisov
2021-09-23 11:55 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fea27d3-1eb7-4725-b894-1a742d6e5c3d@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.