From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Packham Date: Wed, 05 Jul 2017 20:44:50 +0000 Subject: Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements Message-Id: <6ff4113ecb49476081826306d7e7d9c9@svr-chch-ex1.atlnz.lc> List-Id: References: <20170705101358.17458-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andy Shevchenko Cc: Wolfram Sang , Yoshinori Sato , linux-i2c , Linux-SH , "linux-kernel@vger.kernel.org" On 05/07/17 23:49, Andy Shevchenko wrote: > On Wed, Jul 5, 2017 at 1:13 PM, Chris Packham > wrote: >> This series addresses some of the points identified by Andy. The series is >> based on top of i2c/for-next. 2 of the patches from v1 have already been >> applied so I've dropped them from this version. >> >> I have compile tested patch 1/1 but I don't have access to sh hardware >> to actually test the changes on. > > > Entire series looks good to me: > Reviewed-by: Andy Shevchenko > > Further improvement is to get timeout value via device properties API > and get rid of legacy platform data completely. This can be done in > further series. Actually the timeout can probably go now. The two in-tree platforms that set it via platform_data set it to HZ which is (now) the default. > >> >> Chris Packham (4): >> sh: sh7785lcr: add GPIO lookup table for i2c controller reset >> i2c: pca-platform: unconditionally use devm_gpiod_get_optional >> i2c: pca-platform: use device_property_read_u32 >> i2c: pca-platform: drop gpio from platform data >> >> arch/blackfin/mach-bf561/boards/acvilon.c | 1 - >> arch/sh/boards/board-sh7785lcr.c | 11 +++++++++- >> drivers/i2c/busses/i2c-pca-platform.c | 34 +++++++++---------------------- >> include/linux/i2c-pca-platform.h | 3 --- >> 4 files changed, 20 insertions(+), 29 deletions(-) >> >> -- >> 2.13.0 >> > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbdGEUo5 (ORCPT ); Wed, 5 Jul 2017 16:44:57 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:57300 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752545AbdGEUoz (ORCPT ); Wed, 5 Jul 2017 16:44:55 -0400 From: Chris Packham To: Andy Shevchenko CC: Wolfram Sang , Yoshinori Sato , linux-i2c , Linux-SH , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 0/4] i2c: pca-platform: additional improvements Thread-Topic: [PATCH v2 0/4] i2c: pca-platform: additional improvements Thread-Index: AQHS9XdxjhgoGSTbFEG3Cn1zYNucCw== Date: Wed, 5 Jul 2017 20:44:50 +0000 Message-ID: <6ff4113ecb49476081826306d7e7d9c9@svr-chch-ex1.atlnz.lc> References: <20170705101358.17458-1-chris.packham@alliedtelesis.co.nz> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [2001:df5:b000:22:7840:a36:62d2:2c28] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v65KjJ8d005842 On 05/07/17 23:49, Andy Shevchenko wrote: > On Wed, Jul 5, 2017 at 1:13 PM, Chris Packham > wrote: >> This series addresses some of the points identified by Andy. The series is >> based on top of i2c/for-next. 2 of the patches from v1 have already been >> applied so I've dropped them from this version. >> >> I have compile tested patch 1/1 but I don't have access to sh hardware >> to actually test the changes on. > > > Entire series looks good to me: > Reviewed-by: Andy Shevchenko > > Further improvement is to get timeout value via device properties API > and get rid of legacy platform data completely. This can be done in > further series. Actually the timeout can probably go now. The two in-tree platforms that set it via platform_data set it to HZ which is (now) the default. > >> >> Chris Packham (4): >> sh: sh7785lcr: add GPIO lookup table for i2c controller reset >> i2c: pca-platform: unconditionally use devm_gpiod_get_optional >> i2c: pca-platform: use device_property_read_u32 >> i2c: pca-platform: drop gpio from platform data >> >> arch/blackfin/mach-bf561/boards/acvilon.c | 1 - >> arch/sh/boards/board-sh7785lcr.c | 11 +++++++++- >> drivers/i2c/busses/i2c-pca-platform.c | 34 +++++++++---------------------- >> include/linux/i2c-pca-platform.h | 3 --- >> 4 files changed, 20 insertions(+), 29 deletions(-) >> >> -- >> 2.13.0 >> > > >