From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Simek <michal.simek@xilinx.com>
Date: Tue, 30 Jan 2018 14:58:24 +0100
Subject: [U-Boot] [PATCH] arm64: zynqmp: Fix misspelled choice default
In-Reply-To: <CAFkk2KTLVX3+WSXe5vz5TCvU5kpxivJVnO9Qf7Nb5Qgo8_yETw@mail.gmail.com>
References: <20180130130201.6291-1-ulfalizer@gmail.com>
 <32aaac2a-453f-30c8-7382-fb833a6e3224@xilinx.com>
 <CAFkk2KTLVX3+WSXe5vz5TCvU5kpxivJVnO9Qf7Nb5Qgo8_yETw@mail.gmail.com>
Message-ID: <6ff6da03-5e8c-f0a3-84d6-43d16a0319a9@xilinx.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 30.1.2018 14:38, Ulf Magnusson wrote:
> On Tue, Jan 30, 2018 at 2:25 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>> On 30.1.2018 14:02, Ulf Magnusson wrote:
>>> There is no JTAG symbol in the "Boot mode" choice. JTAG_MODE was
>>> probably intended.
>>>
>>> No functional changes. Kconfig choices fall back on using the first
>>> (visible) symbol in the choice as the default if the default symbol is
>>> not visible.
>>>
>>> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
>>> which prints the following warning:
>>>
>>>       warning: the default selection JTAG (undefined) of <choice> (defined at arch/arm/cpu/armv8/zynqmp/Kconfig:107) is not contained in the choice
>>>
>>> I've added a corresponding warning to the C tools too, which is
>>> currently in linux-next: https://patchwork.kernel.org/patch/9983667/
>>>
>>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>>> ---
>>>  arch/arm/cpu/armv8/zynqmp/Kconfig | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/cpu/armv8/zynqmp/Kconfig b/arch/arm/cpu/armv8/zynqmp/Kconfig
>>> index 3f922b4097..56b7846f63 100644
>>> --- a/arch/arm/cpu/armv8/zynqmp/Kconfig
>>> +++ b/arch/arm/cpu/armv8/zynqmp/Kconfig
>>> @@ -107,7 +107,7 @@ config SPL_ZYNQMP_ALT_BOOTMODE
>>>  choice
>>>       prompt "Boot mode"
>>>       depends on SPL_ZYNQMP_ALT_BOOTMODE_ENABLED
>>> -     default JTAG
>>> +     default JTAG_MODE
>>>
>>>  config JTAG_MODE
>>>       bool "JTAG_MODE"
>>>
>>
>> Applied. How to run this tool inside u-boot?
>>
>> Thanks,
>> Michal
> 
> Thanks.
> 
> The following should work, in the U-Boot root:
> 
>         $ pip install kconfiglib
>         $ UBOOTVERSION=2018.03-rc1 python
>         >>> import kconfiglib
>         >>> kconf = kconfiglib.Kconfig()

Nice.

> 
> That will parse the Kconfig files (and generate any parsing-related
> errors and warnings). See the documentation for what functionality is
> available.
> 
> I just set the UBOOTVERSION environment variable to avoid a warning,
> since it's referenced inside the Kconfig files (ordinarily it would be
> exported from the makefiles). Not sure what actually depends on it.
> 
> There's already an old version of Kconfiglib that's used by
> tools/genboardscfg.py and some other scripts in U-Boot by the way. If
> that one ever starts to feel slow, Kconfiglib 2 should be faster
> (though it would require updating genboardscfg.py to the new API).

I see this as the part of buildman and I use this tool quite often but
have never seen this zynqmp error.
I see it as part of genboardscfg and moveconfig but not buildman.

Thanks,
Michal