From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933907AbcHJWMu (ORCPT ); Wed, 10 Aug 2016 18:12:50 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35191 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933656AbcHJWMr (ORCPT ); Wed, 10 Aug 2016 18:12:47 -0400 From: Salah Triki To: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, luisbg@osg.samsung.com Cc: linux-kernel@vger.kernel.org, salah.triki@gmail.com Subject: [PATCH 3/4] befs: remove the validation of allocation group number Date: Wed, 10 Aug 2016 23:12:32 +0100 Message-Id: <7008e2c3fbeb855b1670487959f13ffb776ac31c.1470867071.git.salah.triki@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <8f7f9b76ead677bdc834867e549ea6c4d1c04ccd.1470867071.git.salah.triki@gmail.com> References: <8f7f9b76ead677bdc834867e549ea6c4d1c04ccd.1470867071.git.salah.triki@gmail.com> In-Reply-To: <8f7f9b76ead677bdc834867e549ea6c4d1c04ccd.1470867071.git.salah.triki@gmail.com> References: <8f7f9b76ead677bdc834867e549ea6c4d1c04ccd.1470867071.git.salah.triki@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Validating the allocation group number is unnecessary since it will be done by iaddr2blockno(). Signed-off-by: Salah Triki --- fs/befs/io.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/fs/befs/io.c b/fs/befs/io.c index 14eef7d..f9790f5 100644 --- a/fs/befs/io.c +++ b/fs/befs/io.c @@ -28,18 +28,11 @@ befs_bread_iaddr(struct super_block *sb, befs_inode_addr iaddr) { struct buffer_head *bh; befs_blocknr_t block = 0; - struct befs_sb_info *befs_sb = BEFS_SB(sb); befs_debug(sb, "---> Enter %s " "[%u, %hu, %hu]", __func__, iaddr.allocation_group, iaddr.start, iaddr.len); - if (iaddr.allocation_group > befs_sb->num_ags) { - befs_error(sb, "BEFS: Invalid allocation group %u, max is %u", - iaddr.allocation_group, befs_sb->num_ags); - goto error; - } - block = iaddr2blockno(sb, &iaddr); if (block == BEFS_ERR) -- 1.9.1