From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97561C433DB for ; Tue, 2 Mar 2021 12:17:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E43D664F2C for ; Tue, 2 Mar 2021 12:17:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E43D664F2C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH3y3-0001aG-0t for qemu-devel@archiver.kernel.org; Tue, 02 Mar 2021 07:17:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH3wd-0000ka-MR for qemu-devel@nongnu.org; Tue, 02 Mar 2021 07:16:07 -0500 Received: from mx2.suse.de ([195.135.220.15]:40378) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH3wc-00082L-2f for qemu-devel@nongnu.org; Tue, 02 Mar 2021 07:16:07 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 57B32AF19; Tue, 2 Mar 2021 12:16:04 +0000 (UTC) Subject: Re: [RFC v2 15/24] target/arm: move arm_mmu_idx* to get-phys-addr To: Richard Henderson References: <20210301164936.19446-1-cfontana@suse.de> <20210301164936.19446-16-cfontana@suse.de> From: Claudio Fontana Message-ID: <7012d1cf-cd8b-36d8-c91d-9b23af87384c@suse.de> Date: Tue, 2 Mar 2021 13:16:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/2/21 5:35 AM, Richard Henderson wrote: > On 3/1/21 8:49 AM, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana >> --- >> target/arm/get-phys-addr.c | 95 ++++++++++++++++++++++++++++++++++++++ >> target/arm/tcg/helper.c | 95 -------------------------------------- >> 2 files changed, 95 insertions(+), 95 deletions(-) > > So... get-phys-addr.c is now gaining stuff not related to get_phys_addr? > What's your end goal? > > Is there a better a better name, like mmu_helper.c? Should these in fact go > into a second file, leaving get-phys-addr to itself? > > > r~ > These are all good questions; I would like to avoid the word "helper", as it triggers tcg/ HELPER() stuff for me, but I am not excluding it if we don't have a better idea. The alternative to put this stuff into their own file is open for me. Thanks, Claudio