From: Nadav Amit <namit@vmware.com>
To: lkp@lists.01.org
Subject: Re: [x86/mm/tlb] 2f4305b19f: will-it-scale.per_thread_ops 23.3% improvement
Date: Sun, 07 Nov 2021 21:47:46 +0000 [thread overview]
Message-ID: <7030ECD9-B2A8-4483-AEC1-549C14D5558B@vmware.com> (raw)
In-Reply-To: <20211107142859.GB13541@xsang-OptiPlex-9020>
[-- Attachment #1: Type: text/plain, Size: 2239 bytes --]
> On Nov 7, 2021, at 6:28 AM, kernel test robot <oliver.sang@intel.com> wrote:
>
>
>
> Greeting,
>
> FYI, we noticed a 23.3% improvement of will-it-scale.per_thread_ops due to commit:
>
>
> commit: 2f4305b19fe6a2a261d76c21856c5598f7d878fe ("x86/mm/tlb: Privatize cpu_tlbstate")
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fcgit%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git&data=04%7C01%7Cnamit%40vmware.com%7Cfb2bd9a47e794ec3898508d9a1faf794%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637718921590793957%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=cw6sFeT6qAQSSaG7nCIWm19Yi9RPZqyr2bQPwSBuzzs%3D&reserved=0 master
>
> will-it-scale.per_thread_ops
>
> 4000 +--------------------------------------------------------------------+
> | |
> 3500 |-O O O O O O O O O O O O O O OO O O O O O O O O O O O O O O O O |
> 3000 |-+ .+. .+. |
> |.+.+.+.+.+.+ +.+.+.+.+.+.+.+ ++ +.+.+.+.+.+.+.+.+.+.+.+ |
> 2500 |-+ : : |
> | : : |
> 2000 |-+ : : |
> | : : |
> 1500 |-+ : : |
> 1000 |-+ : : |
> | : : |
> 500 |-+ : |
> | : |
> 0 +--------------------------------------------------------------------+
Am I to understand that the following commit somehow reverted the performance
improvement of this patch? The graph shows it as a “spike”, no?
next prev parent reply other threads:[~2021-11-07 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 14:28 [x86/mm/tlb] 2f4305b19f: will-it-scale.per_thread_ops 23.3% improvement kernel test robot
2021-11-07 21:47 ` Nadav Amit [this message]
2021-11-25 5:02 ` Carel Si
2021-11-29 3:59 ` Carel Si
2021-11-29 17:34 ` Nadav Amit
2021-12-06 13:45 ` Carel Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7030ECD9-B2A8-4483-AEC1-549C14D5558B@vmware.com \
--to=namit@vmware.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.