From: "Kai Wasserbäch" <kai-1ZKVMVCtJ2dx9oSEVPI0kiST3g8Odh+X@public.gmane.org>
To: Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>,
amd-gfx list
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH v2] drm/amdgpu: Read vram width from integrated system info table
Date: Mon, 3 Apr 2017 18:29:55 +0200 [thread overview]
Message-ID: <7039d294-d6af-76dd-e129-854013ab4947@dev.carbon-project.org> (raw)
In-Reply-To: <BN6PR12MB1652CE82ACBFD409F3829D35F7080-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 1171 bytes --]
Deucher, Alexander wrote on 03.04.2017 17:43:
>> -----Original Message-----
>> From: amd-gfx [mailto:amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org] On Behalf
>> Of Kai Wasserbäch
>> Sent: Monday, April 03, 2017 11:20 AM
>> To: Wentland, Harry; amd-gfx list
>> Subject: Re: [PATCH v2] drm/amdgpu: Read vram width from integrated
>> system info table
>>
>> [...]
>>
>> I might miss something subtle here, but after reading this a couple of times,
>> I've convinced myself this is exactly the same switch statement as in
>> gmc_v7_0_mc_init() above, right? If so: why not move that part to common
>> code as
>> well?
>
> The register offsets and bitfields may change across different IP revisions. The actual switch statement itself could be common I guess (minus the registers), but I'm not sure if it's worth the effort.
Thanks to both of you for the explanation. Since everything was named exactly
the same I assumed the definitions for the registers matched as well. Still if
large chunks of code are common helpers might still be nice and reduce the
overall LOCs. Anyway, that's obviously your decision.
Cheers,
Kai
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-04-03 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 15:01 [PATCH v2] drm/amdgpu: Read vram width from integrated system info table Harry Wentland
[not found] ` <20170403150107.13253-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2017-04-03 15:20 ` Kai Wasserbäch
[not found] ` <8623a5d4-1e10-fc46-aaa2-0777b500c3a2-1ZKVMVCtJ2dx9oSEVPI0kiST3g8Odh+X@public.gmane.org>
2017-04-03 15:29 ` Harry Wentland
2017-04-03 15:43 ` Deucher, Alexander
[not found] ` <BN6PR12MB1652CE82ACBFD409F3829D35F7080-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-04-03 16:29 ` Kai Wasserbäch [this message]
2017-04-03 15:37 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7039d294-d6af-76dd-e129-854013ab4947@dev.carbon-project.org \
--to=kai-1zkvmvctj2dx9osevpi0kist3g8odh+x@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=harry.wentland-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.