From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0065EC433FE for ; Wed, 30 Mar 2022 10:44:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245556AbiC3Kqf (ORCPT ); Wed, 30 Mar 2022 06:46:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245552AbiC3Kqc (ORCPT ); Wed, 30 Mar 2022 06:46:32 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8234::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84EBCDFCE; Wed, 30 Mar 2022 03:44:46 -0700 (PDT) Received: from ip4d144895.dynamic.kabel-deutschland.de ([77.20.72.149] helo=[192.168.66.200]); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1nZVoi-00031c-II; Wed, 30 Mar 2022 12:44:44 +0200 Message-ID: <703ad976-a504-eded-41b6-cd4f9f74e8df@leemhuis.info> Date: Wed, 30 Mar 2022 12:44:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: Bug 215726 - si2157.c: mention name of the missing firmware file Content-Language: en-US To: Piotr Chmura , Robert Schlabbach Cc: Antti Palosaari , Mauro Carvalho Chehab , Linux Media Mailing List , Linux Kernel Mailing List References: <5f660108-8812-383c-83e4-29ee0558d623@leemhuis.info> <1fc02de2-890e-e8e8-0ab6-aba62a333de5@leemhuis.info> <2ce6dc15-51a8-e59c-26ab-4380cdca6209@gmail.com> From: Thorsten Leemhuis In-Reply-To: <2ce6dc15-51a8-e59c-26ab-4380cdca6209@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1648637086;9e57a89c; X-HE-SMSGID: 1nZVoi-00031c-II Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.03.22 12:35, Piotr Chmura wrote: > > W dniu 30.03.2022 o 11:55, Thorsten Leemhuis pisze: >> On 29.03.22 21:21, Robert Schlabbach wrote: >>> the patch linked in the bugzilla ticket: >>> https://lore.kernel.org/linux-media/6f84b7f4-3ede-ae55-e99b-a9d4108c80e2@gmail.com/ >>> >>> should indeed fix the issue. >> Ahh, the comment mentioning it was added shortly after I sent my mail. >> #regzbot monitor: >> https://lore.kernel.org/linux-media/6f84b7f4-3ede-ae55-e99b-a9d4108c80e2@gmail.com/ >> >> >> Adding Piotr, the patches' author to the CC, who also replied. >> >> BTW: that patch is afaics missing a Fixes tag specifying the culprit and >> a `Cc: stable@vger.kernel.org # 5.17.x` tag to make sure it's quickly >> backported to the stable tree, as among others explained here: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/handling-regressions.rst >> > Sorry for my inconvenience. Don't worry, everything fine. In a case like... > I just fixed my device and wanted to share > solution with the "world". I'm not familiar with all kernel development > convention (yet). ...this someone else should point such details out to the submitter and/or add these tags when applying the patch. @Robert: Do you know which commit causes this regression and could tell us for a proper Fixes: tag? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I'm getting a lot of reports on my table. I can only look briefly into most of them and lack knowledge about most of the areas they concern. I thus unfortunately will sometimes get things wrong or miss something important. I hope that's not the case here; if you think it is, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight. >>> The error was that the rom_id and required >>> fields were swapped in the table, so the non-zero rom_id was taken as a >>> "true" required boolean value, thus incorrectly evaluating that the >>> chip requires a firmware file to operate when in fact it does not. >>> I have tested the patch and found it worked for me. But I do not know >>> how to push this further along: >>> https://patchwork.linuxtv.org/project/linux-media/patch/6f84b7f4-3ede-ae55-e99b-a9d4108c80e2@gmail.com/ >>> >> Mauro, what's up here? The patch fixes a regression and thus afaics >> should quickly find its way towards mainline to get it into the stable >> tree, as explained in the (bran new) document linked above. >> >> Ciao, Thorsten >> >>> Gesendet: Dienstag, 29. März 2022 um 10:33 Uhr >>> Von: "Thorsten Leemhuis" >>> An: "Antti Palosaari" , "Mauro Carvalho Chehab" >>> , "Robert Schlabbach" >>> Cc: "regressions@lists.linux.dev" , >>> az0123456@gmx.de, "Linux Media Mailing List" >>> , "Linux Kernel Mailing List" >>> >>> Betreff: Bug 215726 - si2157.c: mention name of the missing firmware >>> file >>> Hi, this is your Linux kernel regression tracker. >>> >>> I noticed a regression report in bugzilla.kernel.org that afaics nobody >>> acted upon since it was reported about a week ago, that's why I decided >>> to forward it to the lists and all people that seemed to be relevant >>> here. To quote from https://bugzilla.kernel.org/show_bug.cgi?id=215726 : >>> >>>> I get the following error messages when trying to use si2157.ko in >>>> linux 5.17: >>>> si2157 13-0060: found a 'Silicon Labs Si2157-A30 ROM 0x50' >>>> si2157 13-0060: Can't continue without a firmware >>>> I did work in linux 5.16.16 without a firmware file. Unfortunately >>>> the driver does not tell me the name of the missing firmware file. >>> Could somebody take a look into this? Or was this discussed somewhere >>> else already? Or even fixed? >>> >>> > >