From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E567C4332F for ; Tue, 5 Oct 2021 16:48:21 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id DD2F5611C5 for ; Tue, 5 Oct 2021 16:48:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DD2F5611C5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4390841407; Tue, 5 Oct 2021 18:48:20 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 9396241405 for ; Tue, 5 Oct 2021 18:48:19 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 471CB580FF8; Tue, 5 Oct 2021 12:48:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 05 Oct 2021 12:48:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= /aR4u700qsqErQUtJL2sBYDIayS9vhS3eOAzGxbzozE=; b=foAOghPTsrynbkZw +ETtE+wDxMilo5+WXOIrE8wwjrljaTrpU71X9hHr/rnaqmTtphdXrxPxC+9LQddE HUmn7bu441ilnNa5zwEu61bWnX8I1Yi8MHcpfSWGfIwVlhBiF7m+iZhnkz+u7Wnv AHMlLJ93Nw//o0rf7hjHi1GdN23814ql7vRjsWGXQjO+FPb56EThprBBbDqls1oy clXjmoAqDeSCEMFKj4//6HK7KdezUtTQii9j1TtM05kfY15kfnl4VLt0in3wWbVh 6aIBK8NvOcAx78WSjIsm3yB5C0dQTA+WnSg+Djff/sOgwXuBRRgcumUu1u9MkBgJ NA/svQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/aR4u700qsqErQUtJL2sBYDIayS9vhS3eOAzGxbzo zE=; b=dsDd0ey0kLPWD69yabR0FjVLTGJwuvbPXKViEwt5+G8WB9c7HIkO1pj6T ZGJmjfNzIMPe76Al7PEJONfGHU8LsTEuj3tn/zkpbdjITaS7thd2dgdgylHEaMUV i0aFlS6dtpYZQWuDHrEqWCEDNPFK1k1vJn+chm7lWR9J9KfOqPO27YGjhgxQYGQT r+bMi3IevWBm/rAGHJRfD8lLh96rkZQxx/SkZmsLxXv4fxccDPar8SO6UrB/sshp DdcNqTrjjiITCZOtpYoGCzYcSDs7R6b/YuKE7y1T+NqlX40Gg0uAucGEYR5uMnxG 7HyWzPuCHv84VyGuBw+yKA3Mv07xA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelgedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Oct 2021 12:48:09 -0400 (EDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Cc: "dev@dpdk.org" , "Li, Xiaoyun" , "anoobj@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "adwivedi@marvell.com" , "shepard.siegel@atomicrules.com" , "ed.czeck@atomicrules.com" , "john.miller@atomicrules.com" , "irusskikh@marvell.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "rahul.lakkireddy@chelsio.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "Wang, Haiyue" , "Daley, John" , "hyonkim@cisco.com" , "Zhang, Qi Z" , "Wang, Xiao W" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "sthemmin@microsoft.com" , "longli@microsoft.com" , "heinrich.kuhn@corigine.com" , "kirankumark@marvell.com" , "andrew.rybchenko@oktetlabs.ru" , "mczekaj@marvell.com" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" , "maxime.coquelin@redhat.com" , "Xia, Chenbo" , "Yigit, Ferruh" , "mdr@ashroe.eu" , "Jayatheerthan, Jay" Date: Tue, 05 Oct 2021 18:48:06 +0200 Message-ID: <7042975.2VkKJPXxgV@thomas> In-Reply-To: References: <20211001140255.5726-1-konstantin.ananyev@intel.com> <2386814.hQzPKX2lIG@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 3/7] ethdev: copy ethdev 'fast' API into separate structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/10/2021 18:41, Ananyev, Konstantin: > > > +struct rte_eth_fp_ops { > > > + > > > + /** first 64B line */ > > > + eth_rx_burst_t rx_pkt_burst; > > > + /**< PMD receive function. */ > > > + eth_tx_burst_t tx_pkt_burst; > > > + /**< PMD transmit function. */ > > > + eth_tx_prep_t tx_pkt_prepare; > > > + /**< PMD transmit prepare function. */ > > > + eth_rx_queue_count_t rx_queue_count; > > > + /**< Get the number of used RX descriptors. */ > > > + eth_rx_descriptor_status_t rx_descriptor_status; > > > + /**< Check the status of a Rx descriptor. */ > > > + eth_tx_descriptor_status_t tx_descriptor_status; > > > + /**< Check the status of a Tx descriptor. */ > > > + uintptr_t reserved[2]; > > > > uintptr_t size is not fix. > > I think you mean uint64_t. > > Nope, I meant 'uintptr_t' here. > That way it fits really nicely to both 64-bit and 32-bit systems. > For 64-bit systems we have all function pointers on first 64B line, > and all data pointers on second 64B line. > For 32-bit systems we have all fields within first 64B line. OK but then the next comment is partially wrong: > > > + > > > + /** second 64B line */ > > > + struct rte_ethdev_qdata rxq; > > > + struct rte_ethdev_qdata txq; > > > + uintptr_t reserved2[4]; > > > + > > > +} __rte_cache_aligned;