From: John Garry <john.garry@huawei.com>
To: Andrew Kilroy <andrew.kilroy@arm.com>,
<linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>, <acme@kernel.org>,
<irogers@google.com>, <ak@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>
Subject: Re: [RFC PATCH v2 1/5] perf stat: Implement --topdown with metrics
Date: Fri, 28 Jan 2022 13:44:08 +0000 [thread overview]
Message-ID: <70433fdc-831e-8afa-68c3-6d75a4f8c75a@huawei.com> (raw)
In-Reply-To: <20220111150749.13365-2-andrew.kilroy@arm.com>
On 11/01/2022 15:07, Andrew Kilroy wrote:
> }
> +
> +bool topdown_can_use_json_metrics(void)
nit: maybe topdown_can_use_metricgroups() could be better
> +{
> +#if defined(__aarch64__)
> + return true;
> +#else
> + return false;
> +#endif
it might be worth just having !x86, just that is prob too much forward
looking
> +}
> +
next prev parent reply other threads:[~2022-01-28 13:44 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 12:37 [PATCH v2 0/2] perf vendor events: Arm Neoverse N2 Andrew Kilroy
2021-12-10 12:37 ` Andrew Kilroy
2021-12-10 12:37 ` [PATCH v2 1/2] perf vendor events: For the " Andrew Kilroy
2021-12-10 12:37 ` Andrew Kilroy
2021-12-10 13:21 ` John Garry
2021-12-10 13:21 ` John Garry
2021-12-14 18:42 ` [RFC PATCH 0/1] topdown with metrics Andrew Kilroy
2021-12-14 18:42 ` Andrew Kilroy
2021-12-14 18:42 ` [RFC PATCH 1/1] perf arm64: Implement --topdown " Andrew Kilroy
2021-12-14 18:42 ` Andrew Kilroy
2021-12-14 20:32 ` Ian Rogers
2021-12-14 20:32 ` Ian Rogers
2021-12-15 10:38 ` James Clark
2021-12-15 10:38 ` James Clark
2021-12-15 10:52 ` John Garry
2021-12-15 10:52 ` John Garry
2021-12-15 12:38 ` Andrew Kilroy
2021-12-15 12:38 ` Andrew Kilroy
2021-12-15 12:53 ` John Garry
2021-12-15 12:53 ` John Garry
2022-01-06 16:33 ` Andrew Kilroy
2022-01-06 16:33 ` Andrew Kilroy
2022-01-06 18:24 ` John Garry
2022-01-06 18:24 ` John Garry
2022-01-11 15:07 ` [RFC PATCH v2 0/5] topdown " Andrew Kilroy
2022-01-11 15:07 ` [RFC PATCH v2 1/5] perf stat: Implement --topdown " Andrew Kilroy
2022-01-28 13:44 ` John Garry [this message]
2022-01-11 15:07 ` [RFC PATCH v2 2/5] perf stat: Topdown kernel events setup function Andrew Kilroy
2022-01-11 15:07 ` [RFC PATCH v2 3/5] perf stat: Topdown json metrics " Andrew Kilroy
2022-01-11 15:07 ` [RFC PATCH v2 4/5] perf stat: Detect if topdown kernel events supported Andrew Kilroy
2022-01-11 15:07 ` [RFC PATCH v2 5/5] perf stat: Ensure only topdown kernel events used on x86 Andrew Kilroy
2022-01-20 9:26 ` [RFC PATCH v2 0/5] topdown with metrics John Garry
2022-01-20 16:22 ` Al Grant
2022-01-27 11:42 ` Andrew Kilroy
2022-02-08 15:58 ` Andrew Kilroy
2021-12-20 17:21 ` [RFC PATCH 1/1] perf arm64: Implement --topdown " Andrew Kilroy
2021-12-20 17:21 ` Andrew Kilroy
2021-12-21 14:03 ` Andi Kleen
2021-12-21 14:03 ` Andi Kleen
2022-01-27 11:11 ` Andrew Kilroy
2022-01-27 11:11 ` Andrew Kilroy
2021-12-17 10:19 ` John Garry
2021-12-17 10:19 ` John Garry
2021-12-21 14:31 ` Andrew Kilroy
2021-12-21 14:31 ` Andrew Kilroy
2022-01-05 16:58 ` Andrew Kilroy
2022-01-05 16:58 ` Andrew Kilroy
2022-01-28 18:00 ` John Garry
2022-01-28 18:00 ` John Garry
2021-12-10 12:37 ` [PATCH v2 2/2] perf vendor events: Rename arm64 arch std event files Andrew Kilroy
2021-12-10 12:37 ` Andrew Kilroy
2021-12-10 13:46 ` John Garry
2021-12-10 13:46 ` John Garry
2021-12-10 19:01 ` Arnaldo Carvalho de Melo
2021-12-10 19:01 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70433fdc-831e-8afa-68c3-6d75a4f8c75a@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.kilroy@arm.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.