Re: [B.A.T.M.A.N.] [PATCH v5 0/6] Optimizations for setups running dat and bla

From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v5 0/6] Optimizations for setups running dat and bla
Date: Fri, 10 Jun 2016 13:51:45 +0200	[thread overview]
Message-ID: <7048408.piSH5dZvnO@bentobox> (raw)
In-Reply-To: <1465557064-24406-1-git-send-email-apape@phoenixcontact.com>

[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]

On Friday 10 June 2016 13:10:58 Andreas Pape wrote:
> This patchset introduces optimizations for batman-adv in setups having several
> gateways into a common (switched) Ethernet backbone network especially if dat
> is additionally enabled.
> 
> Using the current implementation with bla and dat enabled, several problems
> can be observed in a real setup:
> 1. Multiplication of ARP replies from dat enabled gateways and dat enabled
> mesh nodes leading to an "ARP reply storm" in the common backbone network.
> 2. In rare corner cases bla does not fully prevent looping of unicast frames
> in the direction Backbone --> mesh --> backbone and looping of multicast
> frames in the direction mesh --> backbone --> mesh.
> The latter can lead to temporary confusion in the switched backbone resulting
> in packet loss and communication timeouts.
> 
> The observed problems are solved by introduction of additional rules for the
> dat handling, bla packet forwarding and bla claiming/unclaiming of clients.
> 
> v5:
>  - changed function name to batadv_bla_check_claim
>  - put added include file in alphabetical order
>  - added check to exclude ip address 0.0.0.0 from snooping

Doesn't seem to apply:

    $ git describe 
    v2016.2-50-g3ce003c
    $ git am ~/bundle-11-datbla.mbox
    Applying: batman-adv: prevent multiple ARP replies sent by gateways if dat enbled
    error: patch failed: net/batman-adv/distributed-arp-table.c:43
    error: net/batman-adv/distributed-arp-table.c: patch does not apply
    Patch failed at 0001 batman-adv: prevent multiple ARP replies sent by gateways if dat enbled
    The copy of the patch that failed is found in: .git/rebase-apply/patch
    When you have resolved this problem, run "git am --continue".
    If you prefer to skip this patch, run "git am --skip" instead.
    To restore the original branch and stop patching, run "git am --abort".

Btw. there seems to be an "a" missing in "enabled" of the Subject
of the first patch :)

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]