From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5] eal: fix allocating all free hugepages
Date: Thu, 30 Jun 2016 15:34:51 +0200
Message-ID: <7052044.2d0khXtSiK@xps13>
References: <1453661393-85704-1-git-send-email-jianfeng.tan@intel.com>
 <1464665827-24965-1-git-send-email-jianfeng.tan@intel.com>
 <5e903b16-453e-100f-fea4-75229e33344f@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>, dev@dpdk.org,
 nhorman@tuxdriver.com, david.marchand@6wind.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 9F4A4DE0
 for <dev@dpdk.org>; Thu, 30 Jun 2016 15:34:56 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id a66so119028463wme.0
 for <dev@dpdk.org>; Thu, 30 Jun 2016 06:34:56 -0700 (PDT)
In-Reply-To: <5e903b16-453e-100f-fea4-75229e33344f@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > EAL memory init allocates all free hugepages of the whole system,
> > which seen from sysfs, even when applications do not ask so many.
> > When there is a limitation on how many hugepages an application can
> > use (such as cgroup.hugetlb), or hugetlbfs is specified with an
> > option of size (exceeding the quota of the fs), it just fails to
> > start even there are enough hugepages allocated.
> >
> > To fix above issue, this patch:
> >   - Changes the logic to continue memory init to see if hugetlb
> >     requirement of application can be addressed by already allocated
> >     hugepages.
> >   - To make sure each hugepage is allocated successfully, we add a
> >     recover mechanism, which relies on a mem access to fault-in
> >     hugepages, and if it fails with SIGBUS, recover to previously
> >     saved stack environment with siglongjmp().
> >
> > For the case of CONFIG_RTE_EAL_SINGLE_FILE_SEGMENTS (enabled by
> > default when compiling IVSHMEM target), it's indispensable to
> > mapp all free hugepages in the system. Under this case, it fails
> > to start when allocating fails.
[...]
> > Signed-off-by: Jianfeng Tan<jianfeng.tan@intel.com>
> > Acked-by: Neil Horman<nhorman@tuxdriver.com>
> 
> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

Applied, thanks