From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53C5CC433EF for ; Tue, 17 May 2022 16:28:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350898AbiEQQ2o (ORCPT ); Tue, 17 May 2022 12:28:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350886AbiEQQ2m (ORCPT ); Tue, 17 May 2022 12:28:42 -0400 Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A489827CFE for ; Tue, 17 May 2022 09:28:36 -0700 (PDT) Received: by mail-oo1-xc32.google.com with SMTP id s12-20020a4aeacc000000b0035ebb6d1a5fso4682504ooh.3 for ; Tue, 17 May 2022 09:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:content-language:to :cc:references:from:subject:in-reply-to:content-transfer-encoding; bh=JGModbwvdbE5jBbbQbzrPQ9LlQq2EU/3TBOC4UIz3ic=; b=QfNnxhTlZoMsavLnRP3bIaxMelttHF8XQH2Mn2YZ4O+VdTa368ft6TEdGy3j/VGNiu GLm6VIWCNyTRtC/+hZ1uour+CDaqoi9N7Pj1yeDbdCmRUSaKTtKMIJHccJblBRdiWQ6L 4M3y62UYM4pPS0zN4YgWekbUMEqiv+QeyKqaPkxaFv6jZdqoHcDZxczSzOXPEKcz2iRs orE5Kw2Co9LslUfgW1zl82gR3vgSxY792p1PnUfHP3n1Ee1QlJkOsWAWAsYUMdBOkzus /fiKo0iZZBViwWLnfq72Q9WAGipq5t3DqDUf9fTnkmMYTIoWkwJj3FPFhOGUEJBa0vDh LUKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=JGModbwvdbE5jBbbQbzrPQ9LlQq2EU/3TBOC4UIz3ic=; b=oBsfBm/RVQZeIDXCUJ5wnc00R4S7Kad7uPgHdORDyMWwG9FeT+/lUMtq2I1Yzfh/34 MYCM7jAULhdI2jem223asuFE5rEW2rstmjYS6Jq9V2xZdE9L6c30tbaC/S54iJmSREKE AAv78hj47xwg2pg12IROH7uIEgBPy2CkfAAjwv9u7OBVbfJOKeUbb0SrB0cjLAlEt8UH 3f2pq5T1+R3yzgJxCktwo4kvVbn2l+5d2Up6P/vcxPmJ+9CXQUlzRLb9RZz8bbrgAkny VWvKwD0MIeSKxFzmdMsA16PMxMiYYQDmKYouBj9wE7wCPtc9xIwbH8jy8OEgbt/Jpi4s PecA== X-Gm-Message-State: AOAM532+fv4U6n3kkg7PCxqYOJkoYrnQTZx3P2pzkcY2w1E60qiBVcdW 3AGtSyNo62aY9uixJepcKvBMz7PN3Gx8Mw== X-Google-Smtp-Source: ABdhPJxvJMqcZ1jfMb3A/nK2vF8v8pjW4GA0l/bngQFQDA7SIhunrblTxL4s8jg9/qRCsITZm2W7pg== X-Received: by 2002:a4a:430b:0:b0:35e:a582:5ba1 with SMTP id k11-20020a4a430b000000b0035ea5825ba1mr8341739ooj.75.1652804915868; Tue, 17 May 2022 09:28:35 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id p20-20020a4a8154000000b0035eb4e5a6c6sm2437oog.28.2022.05.17.09.28.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 09:28:34 -0700 (PDT) Sender: Guenter Roeck Message-ID: <70537c1d-dbd7-b8a4-0a02-e6773a5e68ef@roeck-us.net> Date: Tue, 17 May 2022 09:28:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: Liam Howlett Cc: Heiko Carstens , Sven Schnelle , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <20220428172040.GA3623323@roeck-us.net> <20220513165955.mkg5wvfi4dwpzoer@revolver> <973b908d-7098-cbae-8046-9a42cfabd570@roeck-us.net> <20220517150219.7mshct4jkne6c5el@revolver> From: Guenter Roeck Subject: Re: [PATCH] mapletree-vs-khugepaged In-Reply-To: <20220517150219.7mshct4jkne6c5el@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/17/22 08:03, Liam Howlett wrote: > * Guenter Roeck [220517 09:23]: >> On 5/17/22 04:53, Heiko Carstens wrote: >>> On Fri, May 13, 2022 at 05:00:31PM +0000, Liam Howlett wrote: >>>> * Sven Schnelle [220513 10:46]: >>>>> Heiko Carstens writes: >>>>>> FWIW, same on s390 - linux-next is completely broken. Note: I didn't >>>>>> bisect, but given that the call trace, and even the failing address >>>>>> match, I'm quite confident it is the same reason. >>>>> IS that issue supposed to be fixed? git bisect pointed me to >>>>> >>>>> # bad: [76535d42eb53485775a8c54ea85725812b75543f] Merge branch >>>>> 'mm-everything' of >>>>> git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm >>>>> >>>>> which isn't really helpful. >>>>> >>>>> Anything we could help with debugging this? >>>> >>>> I tested the maple tree on top of the s390 as it was the same crash and >>>> it was okay. I haven't tested the mm-everything branch though. Can you >>>> test mm-unstable? >>>> >>>> I'll continue setting up a sparc VM for testing here and test >>>> mm-everything on that and the s390 >>> >>> So due to reports here I did some sort of "special bisect": with today's >>> linux-next I did a hard reset to commit 562340595cbb ("Merge branch >>> 'for-next/kspp' of >>> git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git"), >>> started a bisect on Andrew's tree between mm-stable and mm-unstable, and >>> merged whatever commit was about to be bisected into 562340595cbb. >>> >>> This lead finally to commit f1297d3a2cb7 ("mm/mmap: reorganize munmap to >>> use maple states") as "first bad commit". >>> >>> So given that we are shortly before the merge window and linux-next is >>> completely broken for s390, how do we proceed? Right now I have no idea if >>> there is anything else in linux-next that would break s390 because of this. >>> >>> Even though I'm sure you won't like to hear this, but I'd appreciate if >>> this code could be removed from linux-next again. >> >> I finally found some time to bisect the alpha boot failures in -next. >> Bisect results below. >> >> Guenter >> >> --- > ... >> # first bad commit: [f1297d3a2cb77261c10fbbd69d92bbca700108e0] mm/mmap: reorganize munmap to use maple states > > Thanks for all the work on this. > > I was able to reproduce on a sparc64 VM. I was returning node metadata > in a rare case. I just CC'ed you all on a patch [1]. It should apply > cleanly to whatever branch you want since it only changes > lib/maple_tree.c > FWIW, below is my bisect log for the sparc64 problem. It looks like your patch does fix this problem. Guenter --- # bad: [47c1c54d1bcd0a69a56b49473bc20f17b70e5242] Add linux-next specific files for 20220517 # good: [42226c989789d8da4af1de0c31070c96726d990c] Linux 5.18-rc7 git bisect start 'HEAD' 'v5.18-rc7' # good: [27d9fca0814b912f762dd5adeb81d9ab250705a9] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git git bisect good 27d9fca0814b912f762dd5adeb81d9ab250705a9 # good: [c57a4cecd8f02b365109fc326c7cde5ec6020a54] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git git bisect good c57a4cecd8f02b365109fc326c7cde5ec6020a54 # good: [0389ffdcdd4eacf5cfcef2a5e25b49a1662f8a8b] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git git bisect good 0389ffdcdd4eacf5cfcef2a5e25b49a1662f8a8b # good: [c506c5c327711f8bb522c10262ec3a932fe91cd2] Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/mic/linux.git git bisect good c506c5c327711f8bb522c10262ec3a932fe91cd2 # bad: [b24964a75c5c0129fd6a0d9bcb0fb6e84fbac126] mm/mmap: drop range_has_overlap() function git bisect bad b24964a75c5c0129fd6a0d9bcb0fb6e84fbac126 # good: [3cbab4ca1ea8752912d8719d72059869b4c18045] mm/damon/sysfs: use enum for 'state' input handling git bisect good 3cbab4ca1ea8752912d8719d72059869b4c18045 # good: [9113eaf331bf44579882c001867773cf1b3364fd] mm/memory-failure.c: add hwpoison_filter for soft offline git bisect good 9113eaf331bf44579882c001867773cf1b3364fd # good: [2b2adc303cebc213072520eb2e86e4beb65e9499] mm: remove rb tree. git bisect good 2b2adc303cebc213072520eb2e86e4beb65e9499 # bad: [bbd9f664c351fbe61afa949abaaa03aed5c84af9] fs/proc/task_mmu: stop using linked list and highest_vm_end git bisect bad bbd9f664c351fbe61afa949abaaa03aed5c84af9 # bad: [3b150cc8ab608f7a7da76b036b0ba7513628b0be] arm64: remove mmap linked list from vdso git bisect bad 3b150cc8ab608f7a7da76b036b0ba7513628b0be # good: [282a3e65bd1dece042bb8cf3a1666d79af1553b0] mm: use maple tree operations for find_vma_intersection() git bisect good 282a3e65bd1dece042bb8cf3a1666d79af1553b0 # good: [d175d2cc268623e3e68181235a4aa068b50a8213] mm: convert vma_lookup() to use mtree_load() git bisect good d175d2cc268623e3e68181235a4aa068b50a8213 # bad: [f1297d3a2cb77261c10fbbd69d92bbca700108e0] mm/mmap: reorganize munmap to use maple states git bisect bad f1297d3a2cb77261c10fbbd69d92bbca700108e0 # good: [a897bb88e1e61df70f350a51f51cade3930adc3c] mm/mmap: move mmap_region() below do_munmap() git bisect good a897bb88e1e61df70f350a51f51cade3930adc3c # first bad commit: [f1297d3a2cb77261c10fbbd69d92bbca700108e0] mm/mmap: reorganize munmap to use maple states