From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69CD2C433F5 for ; Mon, 11 Oct 2021 15:00:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B7F560EE2 for ; Mon, 11 Oct 2021 15:00:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236927AbhJKPC5 (ORCPT ); Mon, 11 Oct 2021 11:02:57 -0400 Received: from foss.arm.com ([217.140.110.172]:60808 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231356AbhJKPC5 (ORCPT ); Mon, 11 Oct 2021 11:02:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0EB10101E; Mon, 11 Oct 2021 08:00:57 -0700 (PDT) Received: from [10.57.95.157] (unknown [10.57.95.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D1E353F694; Mon, 11 Oct 2021 08:00:54 -0700 (PDT) Subject: Re: [PATCH v7 9/9] iommu/dma: Reserve any RMR regions associated with a dev To: Jon Nettleton Cc: Shameer Kolothum , linux-arm-kernel , ACPI Devel Maling List , Linux IOMMU , Linuxarm , Lorenzo Pieralisi , Joerg Roedel , Will Deacon , wanghuiqiang , Hanjun Guo , Steven Price , Sami Mujawar , Eric Auger , yangyicong References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> <20210805080724.480-10-shameerali.kolothum.thodi@huawei.com> <44e00e32-be89-1174-beb5-9a2fca85a683@arm.com> From: Robin Murphy Message-ID: <706e2dc8-37af-2344-0d99-6da1f27ba0fb@arm.com> Date: Mon, 11 Oct 2021 16:00:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 2021-10-09 08:07, Jon Nettleton wrote: > On Fri, Oct 8, 2021 at 3:10 PM Robin Murphy wrote: >> >> On 2021-08-05 09:07, Shameer Kolothum wrote: >>> Get ACPI IORT RMR regions associated with a dev reserved >>> so that there is a unity mapping for them in SMMU. >> >> This feels like most of it belongs in the IORT code rather than >> iommu-dma (which should save the temporary list copy as well). > > See previous comment. The original intent was for device-tree to also > be able to use these mechanisms to create RMR's and support them > in the SMMU. Can you clarify how code behind an "if (!is_of_node(...))" check alongside other IORT-specific code is expected to be useful for DT? Yes, iommu_dma_get_resv_regions() itself wants to end up serving as an abstraction layer, but that still doesn't mean it has to do much more than dispatch into firmware-specific backends as appropriate. Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F373C433F5 for ; Mon, 11 Oct 2021 15:01:02 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0421760EE5 for ; Mon, 11 Oct 2021 15:01:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0421760EE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C468E80F51; Mon, 11 Oct 2021 15:01:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6KEhv4-wG4qW; Mon, 11 Oct 2021 15:01:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id A32D880F28; Mon, 11 Oct 2021 15:01:00 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 68683C0011; Mon, 11 Oct 2021 15:01:00 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id D6A14C000D for ; Mon, 11 Oct 2021 15:00:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B880F4049B for ; Mon, 11 Oct 2021 15:00:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yYq6x6L8k4rW for ; Mon, 11 Oct 2021 15:00:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp4.osuosl.org (Postfix) with ESMTP id EFB0C40496 for ; Mon, 11 Oct 2021 15:00:57 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0EB10101E; Mon, 11 Oct 2021 08:00:57 -0700 (PDT) Received: from [10.57.95.157] (unknown [10.57.95.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D1E353F694; Mon, 11 Oct 2021 08:00:54 -0700 (PDT) Subject: Re: [PATCH v7 9/9] iommu/dma: Reserve any RMR regions associated with a dev To: Jon Nettleton References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> <20210805080724.480-10-shameerali.kolothum.thodi@huawei.com> <44e00e32-be89-1174-beb5-9a2fca85a683@arm.com> From: Robin Murphy Message-ID: <706e2dc8-37af-2344-0d99-6da1f27ba0fb@arm.com> Date: Mon, 11 Oct 2021 16:00:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Cc: Linuxarm , Steven Price , ACPI Devel Maling List , Linux IOMMU , wanghuiqiang , Hanjun Guo , yangyicong , Sami Mujawar , Will Deacon , linux-arm-kernel X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2021-10-09 08:07, Jon Nettleton wrote: > On Fri, Oct 8, 2021 at 3:10 PM Robin Murphy wrote: >> >> On 2021-08-05 09:07, Shameer Kolothum wrote: >>> Get ACPI IORT RMR regions associated with a dev reserved >>> so that there is a unity mapping for them in SMMU. >> >> This feels like most of it belongs in the IORT code rather than >> iommu-dma (which should save the temporary list copy as well). > > See previous comment. The original intent was for device-tree to also > be able to use these mechanisms to create RMR's and support them > in the SMMU. Can you clarify how code behind an "if (!is_of_node(...))" check alongside other IORT-specific code is expected to be useful for DT? Yes, iommu_dma_get_resv_regions() itself wants to end up serving as an abstraction layer, but that still doesn't mean it has to do much more than dispatch into firmware-specific backends as appropriate. Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A46D6C433EF for ; Mon, 11 Oct 2021 15:03:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 757C360EE9 for ; Mon, 11 Oct 2021 15:03:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 757C360EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IGBo56zSIvQhdlycbW5qXulNnRPD7SMRMfQ3ynUfNRI=; b=vlvoHBASGhD2+SfrBISsguARr5 BwZCPPhlZoaIpu3kjoq5tbovBKMM9VkOh5NUz2W/QNPibbzkcIst8jzO1Dfj2v3iNnXQr6s81M5h3 AhsHaVUgdZ40vhu2sLsjnEW0RiauH4ziJ5ze85W1xcigwp57IyKHB695VCsKPrgAw6ein3NdheD3H /Vxt7plyiuhtD6Z+HCecubH7M9uHAgXQFeGRmG0Gs78JwZZ2gAcd/pfp11TCxsc3M4AOq9FAVV12K lzQETXQTkqL5+CCdtx5ls5+oK9i+YOmJWlFJ8OvENrsvOZ0yBKFQ+WHckh3i2I+vOLmtwo1n6WV+v w1ltCwlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZwnY-009sGS-Ms; Mon, 11 Oct 2021 15:01:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZwnT-009sF6-R5 for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 15:01:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0EB10101E; Mon, 11 Oct 2021 08:00:57 -0700 (PDT) Received: from [10.57.95.157] (unknown [10.57.95.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D1E353F694; Mon, 11 Oct 2021 08:00:54 -0700 (PDT) Subject: Re: [PATCH v7 9/9] iommu/dma: Reserve any RMR regions associated with a dev To: Jon Nettleton Cc: Shameer Kolothum , linux-arm-kernel , ACPI Devel Maling List , Linux IOMMU , Linuxarm , Lorenzo Pieralisi , Joerg Roedel , Will Deacon , wanghuiqiang , Hanjun Guo , Steven Price , Sami Mujawar , Eric Auger , yangyicong References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> <20210805080724.480-10-shameerali.kolothum.thodi@huawei.com> <44e00e32-be89-1174-beb5-9a2fca85a683@arm.com> From: Robin Murphy Message-ID: <706e2dc8-37af-2344-0d99-6da1f27ba0fb@arm.com> Date: Mon, 11 Oct 2021 16:00:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_080059_963101_FD327D2A X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-10-09 08:07, Jon Nettleton wrote: > On Fri, Oct 8, 2021 at 3:10 PM Robin Murphy wrote: >> >> On 2021-08-05 09:07, Shameer Kolothum wrote: >>> Get ACPI IORT RMR regions associated with a dev reserved >>> so that there is a unity mapping for them in SMMU. >> >> This feels like most of it belongs in the IORT code rather than >> iommu-dma (which should save the temporary list copy as well). > > See previous comment. The original intent was for device-tree to also > be able to use these mechanisms to create RMR's and support them > in the SMMU. Can you clarify how code behind an "if (!is_of_node(...))" check alongside other IORT-specific code is expected to be useful for DT? Yes, iommu_dma_get_resv_regions() itself wants to end up serving as an abstraction layer, but that still doesn't mean it has to do much more than dispatch into firmware-specific backends as appropriate. Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel