From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 508F9C004D4 for ; Thu, 19 Jan 2023 15:32:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231124AbjASPcb (ORCPT ); Thu, 19 Jan 2023 10:32:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230457AbjASPc2 (ORCPT ); Thu, 19 Jan 2023 10:32:28 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7A90681014 for ; Thu, 19 Jan 2023 07:32:25 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C93FA2F; Thu, 19 Jan 2023 07:33:06 -0800 (PST) Received: from [10.1.196.40] (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 95B433F445; Thu, 19 Jan 2023 07:32:24 -0800 (PST) Message-ID: <7071a073-08f5-104b-f10f-e1013d1b5390@arm.com> Date: Thu, 19 Jan 2023 15:32:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] perf/arm-cmn: Add shutdown routine To: Geoff Blake Cc: Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <2bb86e97-6cef-700e-70ed-4f303da10fd9@amazon.com> <20221215180039.18035-1-blakgeof@amazon.com> Content-Language: en-GB From: Robin Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/01/2023 3:55 pm, Geoff Blake wrote: > Robin, Will, > > Happy new year! Hope I can get some attention back on this patch. > Only difference from Robin's is it will do limited logging if spurious > interrupts still happen to occur on current or future CMN implementations. In all honesty I'm not sure what you want me to say... now you've written the same patch that I already sent, but still with an incorrect commit message, and with some unrelated changes that aren't mentioned and have nothing to do with shutdown anyway. Please see: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes If you have a convincing argument that returning IRQ_NONE for unexpected spurious interrupts is a real and important concern, then please propose a general solution, because if it matters for arm-cmn then it matters for hundreds of other drivers too, by rough estimate: $ git grep -l IRQ_NONE '*.c' | xargs git grep -L IRQF_SHARED | wc -l 834 Thanks, Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC91FC00A5A for ; Thu, 19 Jan 2023 15:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9JztTcaIfSIBvv0m+M8Q1yl4nrZyF5QICIbEHs0oTZU=; b=RTmimDSaGe3Rdc tNB9Oq/zT8+WjJtHiFP1MOQJjQPTb4ObWG4fyb+SlD2Kh5N23U6Ia5LrGob9ADVOgRjrIaBz+w+KO CC+Cek6fOL7ChUrW+g2fyqn2nYyh+6kp4TBXMzMNxLalCwzDC7d45x9XwCmXPSw5GoleVzxBQQ+51 F9VV70oGZOWPH0RgNpSpEEjVjwxLxgbge1EyGt7QC9JYh9oy9T/ndOM0sXqmSCNw3LfAnNkq/T+g6 WerAP0QIyqvEWILqC9ZvFedtBjyAwS3/9LyedS8f7Cb0NZh6nvXJ6QxlEYSVR8io+6lWYFE5Exx8t NVo27Mtbs/IfxcT79fjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIWu4-005fPS-O8; Thu, 19 Jan 2023 15:32:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIWu1-005fNG-Mp for linux-arm-kernel@lists.infradead.org; Thu, 19 Jan 2023 15:32:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C93FA2F; Thu, 19 Jan 2023 07:33:06 -0800 (PST) Received: from [10.1.196.40] (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 95B433F445; Thu, 19 Jan 2023 07:32:24 -0800 (PST) Message-ID: <7071a073-08f5-104b-f10f-e1013d1b5390@arm.com> Date: Thu, 19 Jan 2023 15:32:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] perf/arm-cmn: Add shutdown routine To: Geoff Blake Cc: Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <2bb86e97-6cef-700e-70ed-4f303da10fd9@amazon.com> <20221215180039.18035-1-blakgeof@amazon.com> Content-Language: en-GB From: Robin Murphy In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_073233_835948_B49CCDB7 X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/01/2023 3:55 pm, Geoff Blake wrote: > Robin, Will, > > Happy new year! Hope I can get some attention back on this patch. > Only difference from Robin's is it will do limited logging if spurious > interrupts still happen to occur on current or future CMN implementations. In all honesty I'm not sure what you want me to say... now you've written the same patch that I already sent, but still with an incorrect commit message, and with some unrelated changes that aren't mentioned and have nothing to do with shutdown anyway. Please see: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes If you have a convincing argument that returning IRQ_NONE for unexpected spurious interrupts is a real and important concern, then please propose a general solution, because if it matters for arm-cmn then it matters for hundreds of other drivers too, by rough estimate: $ git grep -l IRQ_NONE '*.c' | xargs git grep -L IRQF_SHARED | wc -l 834 Thanks, Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel