From: Trond Myklebust <trondmy@hammerspace.com>
To: "brauner@kernel.org" <brauner@kernel.org>,
"xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Cc: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"ntfs3@lists.linux.dev" <ntfs3@lists.linux.dev>,
"david@fromorbit.com" <david@fromorbit.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
"chao@kernel.org" <chao@kernel.org>,
"djwong@kernel.org" <djwong@kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
"jlayton@kernel.org" <jlayton@kernel.org>
Subject: Re: [PATCH v4 4/8] NFSv3: only do posix_acl_create under CONFIG_NFS_V3_ACL
Date: Tue, 19 Apr 2022 14:11:59 +0000 [thread overview]
Message-ID: <707fc9d665b44943d4235a51450bff880248eda6.camel@hammerspace.com> (raw)
In-Reply-To: <20220419135938.flv776f36v6xb6sj@wittgenstein>
On Tue, 2022-04-19 at 15:59 +0200, Christian Brauner wrote:
> On Tue, Apr 19, 2022 at 07:47:10PM +0800, Yang Xu wrote:
> > Since nfs3_proc_create/nfs3_proc_mkdir/nfs3_proc_mknod these rpc
> > ops are called
> > by nfs_create/nfs_mkdir/nfs_mkdir these inode ops, so they are all
> > in control of
> > vfs.
> >
> > nfs3_proc_setacls does nothing in the !CONFIG_NFS_V3_ACL case, so
> > we put
> > posix_acl_create under CONFIG_NFS_V3_ACL and it also doesn't affect
> > sattr->ia_mode value because vfs has did umask strip.
> >
> > Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> > ---
>
> I have the same comment as on the xfs patch. If the filesystem has
> opted
> out of acls and SB_POSIXACL isn't set in sb->s_flags then
> posix_acl_create() is a nop. Why bother placing it under an ifdef?
>
> It adds visual noise and it implies that posix_acl_create() actually
> does something even if the filesystem doesn't support posix acls.
>
Agreed and NACKed...
Any patch that gratuitously adds #ifdefs in situations where cleaner
alternatives exist is not going going to be applied by the NFS
maintainers.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy@hammerspace.com>
To: "brauner@kernel.org" <brauner@kernel.org>,
"xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"djwong@kernel.org" <djwong@kernel.org>,
"david@fromorbit.com" <david@fromorbit.com>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"jlayton@kernel.org" <jlayton@kernel.org>,
"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
"ntfs3@lists.linux.dev" <ntfs3@lists.linux.dev>
Subject: Re: [f2fs-dev] [PATCH v4 4/8] NFSv3: only do posix_acl_create under CONFIG_NFS_V3_ACL
Date: Tue, 19 Apr 2022 14:11:59 +0000 [thread overview]
Message-ID: <707fc9d665b44943d4235a51450bff880248eda6.camel@hammerspace.com> (raw)
In-Reply-To: <20220419135938.flv776f36v6xb6sj@wittgenstein>
On Tue, 2022-04-19 at 15:59 +0200, Christian Brauner wrote:
> On Tue, Apr 19, 2022 at 07:47:10PM +0800, Yang Xu wrote:
> > Since nfs3_proc_create/nfs3_proc_mkdir/nfs3_proc_mknod these rpc
> > ops are called
> > by nfs_create/nfs_mkdir/nfs_mkdir these inode ops, so they are all
> > in control of
> > vfs.
> >
> > nfs3_proc_setacls does nothing in the !CONFIG_NFS_V3_ACL case, so
> > we put
> > posix_acl_create under CONFIG_NFS_V3_ACL and it also doesn't affect
> > sattr->ia_mode value because vfs has did umask strip.
> >
> > Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> > ---
>
> I have the same comment as on the xfs patch. If the filesystem has
> opted
> out of acls and SB_POSIXACL isn't set in sb->s_flags then
> posix_acl_create() is a nop. Why bother placing it under an ifdef?
>
> It adds visual noise and it implies that posix_acl_create() actually
> does something even if the filesystem doesn't support posix acls.
>
Agreed and NACKed...
Any patch that gratuitously adds #ifdefs in situations where cleaner
alternatives exist is not going going to be applied by the NFS
maintainers.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-04-19 14:12 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 11:47 [PATCH v4 1/8] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip Yang Xu
2022-04-19 11:47 ` [f2fs-dev] " Yang Xu
2022-04-19 11:47 ` [PATCH v4 2/8] fs: Add missing umask strip in vfs_tmpfile Yang Xu
2022-04-19 11:47 ` [f2fs-dev] " Yang Xu
2022-04-19 11:47 ` [PATCH v4 3/8] xfs: only call posix_acl_create under CONFIG_XFS_POSIX_ACL Yang Xu
2022-04-19 11:47 ` [f2fs-dev] " Yang Xu
2022-04-19 13:53 ` Christian Brauner
2022-04-19 13:53 ` [f2fs-dev] " Christian Brauner
2022-04-20 1:12 ` xuyang2018.jy
2022-04-20 1:12 ` [f2fs-dev] " xuyang2018.jy
2022-04-20 4:49 ` Christoph Hellwig
2022-04-20 4:49 ` [f2fs-dev] " Christoph Hellwig
2022-04-19 11:47 ` [PATCH v4 4/8] NFSv3: only do posix_acl_create under CONFIG_NFS_V3_ACL Yang Xu
2022-04-19 11:47 ` [f2fs-dev] " Yang Xu
2022-04-19 13:59 ` Christian Brauner
2022-04-19 13:59 ` [f2fs-dev] " Christian Brauner
2022-04-19 14:11 ` Trond Myklebust [this message]
2022-04-19 14:11 ` Trond Myklebust
2022-04-20 1:12 ` xuyang2018.jy
2022-04-20 1:12 ` [f2fs-dev] " xuyang2018.jy
2022-04-19 11:47 ` [PATCH v4 5/8] f2fs: Remove useless NULL assign value for acl and default_acl Yang Xu
2022-04-19 11:47 ` [f2fs-dev] " Yang Xu
2022-04-19 14:02 ` Christian Brauner
2022-04-19 14:02 ` [f2fs-dev] " Christian Brauner
2022-04-20 1:14 ` xuyang2018.jy
2022-04-20 1:14 ` [f2fs-dev] " xuyang2018.jy
2022-04-19 11:47 ` [PATCH v4 6/8] ntfs3: Use the same order for acl pointer check in ntfs_init_acl Yang Xu
2022-04-19 11:47 ` [f2fs-dev] " Yang Xu
2022-04-19 14:03 ` Christian Brauner
2022-04-19 14:03 ` [f2fs-dev] " Christian Brauner
2022-04-20 1:15 ` xuyang2018.jy
2022-04-20 1:15 ` [f2fs-dev] " xuyang2018.jy
2022-04-19 11:47 ` [PATCH v4 7/8] fs: strip file's S_ISGID mode on vfs instead of on underlying filesystem Yang Xu
2022-04-19 11:47 ` [f2fs-dev] " Yang Xu
2022-04-19 14:09 ` Christian Brauner
2022-04-19 14:09 ` [f2fs-dev] " Christian Brauner
2022-04-20 1:16 ` xuyang2018.jy
2022-04-20 1:16 ` [f2fs-dev] " xuyang2018.jy
2022-04-19 11:47 ` [PATCH v4 8/8] ceph: Remove S_ISGID clear code in ceph_finish_async_create Yang Xu
2022-04-19 11:47 ` [f2fs-dev] " Yang Xu
2022-04-19 14:05 ` [PATCH v4 1/8] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip Christian Brauner
2022-04-19 14:05 ` [f2fs-dev] " Christian Brauner
2022-04-20 1:27 ` xuyang2018.jy
2022-04-20 1:27 ` [f2fs-dev] " xuyang2018.jy
2022-04-20 21:52 ` Dave Chinner
2022-04-20 21:52 ` [f2fs-dev] " Dave Chinner
2022-04-21 1:11 ` xuyang2018.jy
2022-04-21 1:11 ` [f2fs-dev] " xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=707fc9d665b44943d4235a51450bff880248eda6.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=chao@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.