From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
Subject: Re: [PATCH v2 11/15] net/avp: packet receive functions
Date: Wed, 1 Mar 2017 13:23:12 +0000
Message-ID: <70A7408C6E1BFB41B192A929744D85238A75943B@ALA-MBC.corp.ad.wrs.com>
References: <1487985795-136044-1-git-send-email-allain.legacy@windriver.com>
 <1488136143-116389-1-git-send-email-allain.legacy@windriver.com>
 <1488136143-116389-12-git-send-email-allain.legacy@windriver.com>
 <20170227084615.7ff06316@xeon-e3>
 <70A7408C6E1BFB41B192A929744D85238A757FBC@ALA-MBC.corp.ad.wrs.com>
 <20170228102701.GA141940@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Stephen Hemminger <stephen@networkplumber.org>, "YIGIT, FERRUH"
 <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "RICHARDSON, BRUCE" <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11])
 by dpdk.org (Postfix) with ESMTP id 001F32BFF
 for <dev@dpdk.org>; Wed,  1 Mar 2017 14:23:15 +0100 (CET)
In-Reply-To: <20170228102701.GA141940@bricha3-MOBL3.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> In my experience, checkpatch ignores long lines that are due to error
> messages. Perhaps you need to put the error message on a separate line,
> if other things before the message are of significant size.
I have gone through the entire patchset and reverted my previous changes to=
 reduce line length on any occurrences of debug log strings.   I kept the e=
rror message on the first line and all input variables on subsequent lines =
(and no longer than 80).   checkpatches.sh flags most of them as warnings, =
but since unbroken strings seems more important I will submit my next patch=
set version (v3) like this.=20

WARNING:LONG_LINE_STRING: line over 80 characters
#120: FILE: drivers/net/avp/avp_ethdev.c:236:
+			PMD_DRV_LOG(ERR, "Timeout while waiting for a response for %u\n",