From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
Subject: Re: [PATCH 1/5] cfgfile: configurable comment character
Date: Thu, 2 Mar 2017 21:22:59 +0000
Message-ID: <70A7408C6E1BFB41B192A929744D85238A75A938@ALA-MBC.corp.ad.wrs.com>
References: <1488482971-170522-1-git-send-email-allain.legacy@windriver.com>
 <1488482971-170522-2-git-send-email-allain.legacy@windriver.com>
 <20170302211015.GA18940@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "DUMITRESCU, CRISTIAN FLORIN" <cristian.dumitrescu@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Jolliffe, Ian" <Ian.Jolliffe@windriver.com>
To: "RICHARDSON, BRUCE" <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11])
 by dpdk.org (Postfix) with ESMTP id 0B1D42A5E
 for <dev@dpdk.org>; Thu,  2 Mar 2017 22:23:02 +0100 (CET)
Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com
 [147.11.189.40])
 by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id v22LN1gl010369
 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK)
 for <dev@dpdk.org>; Thu, 2 Mar 2017 13:23:01 -0800
In-Reply-To: <20170302211015.GA18940@bricha3-MOBL3.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> -----Original Message-----
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> We are trying to avoid adding in extra build-time options to DPDK, so
> can you please rework this patch to make it a run-time option instead.
> Perhaps just add a set_comment_char() API call to the library. If this
> is a setting per cfgfile instance it would then allow applications to
> simultaneously use files with different formats. For example, if in
> future we use cfgfile library to configure DPDK EAL, a preexisting file
> for that shipped with DPDK may conflict in format with an
> application-specific one.

Ok, sounds reasonable.