From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
Subject: Re: [PATCH v4 3/6] cfgfile: add support for configurable
 comment character
Date: Fri, 31 Mar 2017 11:08:18 +0000
Message-ID: <70A7408C6E1BFB41B192A929744D8523968FD6AF@ALA-MBC.corp.ad.wrs.com>
References: <20170328164431.12475-1-allain.legacy@windriver.com>
 <20170330185407.61220-1-allain.legacy@windriver.com>
 <20170330185407.61220-4-allain.legacy@windriver.com>
 <298208360.8PDEFbKV4o@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "DUMITRESCU, CRISTIAN FLORIN" <cristian.dumitrescu@intel.com>,
 "RICHARDSON, BRUCE" <bruce.richardson@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13])
 by dpdk.org (Postfix) with ESMTP id BDBA9FE5
 for <dev@dpdk.org>; Fri, 31 Mar 2017 13:08:21 +0200 (CEST)
In-Reply-To: <298208360.8PDEFbKV4o@xps13>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, March 31, 2017 6:08 AM
<...>=20
> > + * @return
> > + *   Handle to configuration file on success, NULL otherwise
> > + * @param
>=20
> This @param should be removed.

Ok.  I will remove it.

>=20
> > + *
> > + */
> > +struct rte_cfgfile *rte_cfgfile_load_with_params(const char *filename,
> > +       int flags, const struct rte_cfgfile_parameters *params);
> >
>=20
> The new public function must be exported in the map file in a 17.05 secti=
on.
> Otherwise link with the .so fails:
> 	undefined reference to `rte_cfgfile_load_with_params'

Ok.  I will send a v5 shortly.