From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Legacy, Allain" <Allain.Legacy@windriver.com>
Subject: Re: [PATCH v2 07/13] net/avp: fix errors in exported
	headers
Date: Tue, 25 Apr 2017 13:00:46 +0000
Message-ID: <70A7408C6E1BFB41B192A929744D85239690F322@ALA-MBC.corp.ad.wrs.com>
References: <cover.1493048352.git.adrien.mazarguil@6wind.com>
 <cover.1493108423.git.adrien.mazarguil@6wind.com>
 <046efd0fda00bfb5253586319fb9cfbf904a8f0a.1493108423.git.adrien.mazarguil@6wind.com>
 <70A7408C6E1BFB41B192A929744D85239690F2B7@ALA-MBC.corp.ad.wrs.com>
 <20170425124959.GJ3790@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Peters, Matt" <Matt.Peters@windriver.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.windriver.com (mail.windriver.com [147.11.1.11])
 by dpdk.org (Postfix) with ESMTP id B0F7D2C16
 for <dev@dpdk.org>; Tue, 25 Apr 2017 15:00:50 +0200 (CEST)
In-Reply-To: <20170425124959.GJ3790@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
> Sent: Tuesday, April 25, 2017 8:50 AM
<...>
> > 2) RTE_STD_C11 needs to be included in the #ifdef __KERNEL__.
>=20
> Missed that one, however I suggest either:
>=20
>  #ifndef __KERNEL__ around RTE_STD_C11
>=20
> or using __extension__ directly. Which do you prefer?

I would prefer if it was done as it is done in rte_kni_common.h to provide =
consistency with other similar files.  Like this:

	#ifdef __KERNEL__
	#include <linux/if.h>
	#define RTE_STD_C11
	#else
	#include <rte_common.h>
	#endif

...but if you disagree then I prefer the #ifndef __KERNEL__ option.


>=20
> By the way, is the kernel module that depends on rte_avp_common.h
> available somewhere to validate compilation against it?

There is an older version of the module available on github, but it has not=
 been updated since the AVP driver has been included in the DPDK.   Since t=
he AVP directory and files were significantly changed in order to meet the =
requirements of the DPDK it won't be much use to you.    Until we can updat=
e it please make sure both Matt Peters and I are CC'd on the patch requests=
 and we'll confirm compilation as quickly as possible.


> > Would you mind changing the brackets (<>) to quotes ("") since this is =
a
> local include file?
> >
> > 	#include "rte_avp_common.h"
>=20
> I will update it.


Thank you.